3368721537
This reverts commit 184f6d5d75c198cb7b70b8f9b75e0b5096c6e577. Reason for revert: Breaks downstream android projects. Original change's description: > Change clip_name -> clip_path in VideoQualityTestFixture::Params::Video. > > This allows external users of this test fixture to specify a custom > path, rather than just a custom file name. > > Bug: webrtc:10349 > Change-Id: I84e886c8bc28583017ce9ed7b9e7ee6a8e95730f > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126227 > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Reviewed-by: Åsa Persson <asapersson@webrtc.org> > Commit-Queue: Rasmus Brandt <brandtr@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#27033} TBR=brandtr@webrtc.org,kwiberg@webrtc.org,asapersson@webrtc.org Change-Id: I56af4c74e0c38b5a14a6151b230ada4349e931da No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:10349 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126620 Reviewed-by: Yves Gerey <yvesg@google.com> Commit-Queue: Yves Gerey <yvesg@google.com> Cr-Commit-Position: refs/heads/master@{#27046}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.