admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/pc
History
Tomas Gunnarsson ad3258647e Reland "Prepare to avoid hops to worker for network events." 
This is a reland of d48a2b14e7545d0a0778df753e062075c044e2a1

The diff of the reland (what caused the tsan error) can be seen
by diffing patch sets 2 and 3. Essentially I missed keeping the calls
to the transport controller on the worker thread. Note to self to add
thread/sequence checks to that code so that we won't have to rely on
tsan :)

Original change's description:
> Prepare to avoid hops to worker for network events.
>
> This moves the thread hop for network events, from BaseChannel and
> into Call. The reason for this is to move the control over those hops
> (including DeliverPacket[Async]) into the same class where the state
> is held that is affected by those hops. Once that's done, we can start
> moving the relevant network state over to the network thread and
> eventually remove the hops.
>
> I'm also adding several TODOs for tracking future steps and give
> developers a heads up.
>
> Bug: webrtc:11993
> Change-Id: Ice7ee3b5b6893532df52039324293979196d341d
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/204800
> Commit-Queue: Tommi <tommi@webrtc.org>
> Reviewed-by: Niels Moller <nisse@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#33138}

Bug: webrtc:11993, webrtc:12430
Change-Id: I4fccaa418d22c2087a55bbb3ddbb25fac3b4dfcc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/205580
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33153}
2021-02-03 17:44:47 +00:00
..
scenario_tests
Default enable sending transport sequence numbers on audio packets.
2020-11-24 09:19:54 +00:00
test
Replace rtc::ThreadChecker with webrtc::SequenceChecker
2021-02-02 14:56:27 +00:00
audio_rtp_receiver.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
audio_rtp_receiver.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
audio_track.cc
Avoid proxy thread hops for reading const properties.
2020-09-10 13:11:44 +00:00
audio_track.h
Replace rtc::ThreadChecker with webrtc::SequenceChecker
2021-02-02 14:56:27 +00:00
BUILD.gn
Replace rtc::ThreadChecker with webrtc::SequenceChecker
2021-02-02 14:56:27 +00:00
channel_interface.h
Revert "Do all BaseChannel operations within a single Thread::Invoke."
2021-01-29 21:56:38 +00:00
channel_manager_unittest.cc
Delete MediaTransportInterface and DatagramTransportInterface
2020-06-17 08:41:14 +00:00
channel_manager.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
channel_manager.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
channel_unittest.cc
Reland "Prepare to avoid hops to worker for network events."
2021-02-03 17:44:47 +00:00
channel.cc
Reland "Prepare to avoid hops to worker for network events."
2021-02-03 17:44:47 +00:00
channel.h
Get rid of unnecessary network thread Invoke in BaseChannel.
2021-02-02 02:48:08 +00:00
composite_rtp_transport_test.cc
Extend NetworkRoute with more info about local/remote endpoints
2020-03-20 16:55:38 +00:00
composite_rtp_transport.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
composite_rtp_transport.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
connection_context.cc
Prefix HAVE_SCTP macro with WEBRTC_.
2021-01-20 10:51:07 +00:00
connection_context.h
Move "options" from ConnectionContext to PeerConnectionFactory
2020-11-04 11:10:53 +00:00
data_channel_controller.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
data_channel_controller.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
data_channel_unittest.cc
Use rtc::CopyOnWriteBuffer::MutableData through webrtc
2021-01-11 11:31:33 +00:00
data_channel_utils.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
data_channel_utils.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
DEPS
…
dtls_srtp_transport_unittest.cc
Refactor ssl_stream_adapter API to show object ownership
2020-03-21 18:53:46 +00:00
dtls_srtp_transport.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
dtls_srtp_transport.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
dtls_transport_unittest.cc
Refactor ssl_stream_adapter API to show object ownership
2020-03-21 18:53:46 +00:00
dtls_transport.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
dtls_transport.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
dtmf_sender_unittest.cc
Allow DTMF delay configurability
2020-01-22 20:46:52 +00:00
dtmf_sender.cc
Allow DTMF delay configurability
2020-01-22 20:46:52 +00:00
dtmf_sender.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
external_hmac.cc
…
external_hmac.h
…
ice_server_parsing_unittest.cc
Add create function for PeerConnection that can return an error.
2020-11-27 11:08:10 +00:00
ice_server_parsing.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
ice_server_parsing.h
…
ice_transport_unittest.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
ice_transport.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
ice_transport.h
Replace rtc::ThreadChecker with webrtc::SequenceChecker
2021-02-02 14:56:27 +00:00
jitter_buffer_delay_interface.h
…
jitter_buffer_delay_proxy.h
…
jitter_buffer_delay_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
jitter_buffer_delay.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
jitter_buffer_delay.h
…
jsep_ice_candidate.cc
Make the JsepSessionDesription clone() method copy candidates.
2021-01-05 12:55:24 +00:00
jsep_session_description_unittest.cc
Make the JsepSessionDesription clone() method copy candidates.
2021-01-05 12:55:24 +00:00
jsep_session_description.cc
Make the JsepSessionDesription clone() method copy candidates.
2021-01-05 12:55:24 +00:00
jsep_transport_controller_unittest.cc
Remove DtlsHandShakeError and replace it with a Function Pointer.
2021-01-28 09:41:08 +00:00
jsep_transport_controller.cc
Use CallbackList in DtlsHandshakeError in dtls_transport.
2021-02-02 17:17:22 +00:00
jsep_transport_controller.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
jsep_transport_unittest.cc
Delete MediaTransportInterface and DatagramTransportInterface
2020-06-17 08:41:14 +00:00
jsep_transport.cc
Delete use of RecursiveCriticalSection in JsepTransport
2021-02-01 15:02:50 +00:00
jsep_transport.h
Replace rtc::ThreadChecker with webrtc::SequenceChecker
2021-02-02 14:56:27 +00:00
local_audio_source_unittest.cc
…
local_audio_source.cc
…
local_audio_source.h
…
media_protocol_names.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
media_protocol_names.h
…
media_session_unittest.cc
Signal extmap-allow-mixed by default on session level
2021-01-19 14:28:11 +00:00
media_session.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
media_session.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
media_stream_observer.cc
…
media_stream_observer.h
…
media_stream_unittest.cc
In pc/ replace mock macros with unified MOCK_METHOD macro
2020-05-18 17:06:25 +00:00
media_stream.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
media_stream.h
Avoid proxy thread hops for reading const properties.
2020-09-10 13:11:44 +00:00
OWNERS
Adding deadbeef back to OWNERS files
2020-02-25 14:45:04 +00:00
peer_connection_adaptation_integrationtest.cc
[Adaptation] Add ability to inject resources on the PeerConnection.
2020-06-11 14:17:01 +00:00
peer_connection_bundle_unittest.cc
Prefix HAVE_SCTP macro with WEBRTC_.
2021-01-20 10:51:07 +00:00
peer_connection_crypto_unittest.cc
reorder sdes suites to not prefer gcm
2020-05-12 14:43:43 +00:00
peer_connection_data_channel_unittest.cc
Reland "Make cricket::SctpTransportInternalFactory injectable through PeerConnectionFactory Deps"
2020-09-01 12:17:00 +00:00
peer_connection_end_to_end_unittest.cc
Prefix HAVE_SCTP macro with WEBRTC_.
2021-01-20 10:51:07 +00:00
peer_connection_factory_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
peer_connection_factory.cc
Inject network thread to Call.
2021-01-31 10:56:14 +00:00
peer_connection_factory.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
peer_connection_header_extension_unittest.cc
RtpTransceiverInterface: introduce HeaderExtensionsNegotiated.
2020-12-17 23:43:42 +00:00
peer_connection_histogram_unittest.cc
Prefix HAVE_SCTP macro with WEBRTC_.
2021-01-20 10:51:07 +00:00
peer_connection_ice_unittest.cc
[Perfect Negotiation] Fire onnegotiationneeded when chain is empty.
2020-08-25 09:56:39 +00:00
peer_connection_integrationtest.cc
Monitor the "concealed samples" stat for the audio during negotiation.
2021-01-22 13:18:05 +00:00
peer_connection_interface_unittest.cc
Destroy previous offer instead of leaking it in PeerConnectionInterfaceTest.ExtmapAllowMixedIsConfigurable
2021-01-26 09:52:14 +00:00
peer_connection_internal.h
Make Android/iOS local/remote description accessors thread safe.
2020-08-05 22:34:46 +00:00
peer_connection_jsep_unittest.cc
Reland "Remove stopped transceivers at both local and remote SetDescription"
2020-09-24 08:03:50 +00:00
peer_connection_media_unittest.cc
Reland "Implement transceiver.stop()"
2020-08-11 10:46:23 +00:00
peer_connection_message_handler.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
peer_connection_message_handler.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
peer_connection_rampup_tests.cc
Change gtest name to allow filtering based on the story name.
2020-09-11 14:11:27 +00:00
peer_connection_rtp_unittest.cc
Prefix HAVE_SCTP macro with WEBRTC_.
2021-01-20 10:51:07 +00:00
peer_connection_signaling_unittest.cc
Reland "introduce an unsupported content description type"
2020-10-21 08:20:05 +00:00
peer_connection_simulcast_unittest.cc
Reland "Implement transceiver.stop()"
2020-08-11 10:46:23 +00:00
peer_connection_wrapper.cc
Reland "[Perfect Negotiation] Implement non-racy version of SetLocalDescription."
2020-07-29 11:27:43 +00:00
peer_connection_wrapper.h
Reland "Implement rollback for setRemoteDescription"
2019-10-14 12:40:53 +00:00
peer_connection.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
peer_connection.h
add metrics for bundle usage
2021-01-28 14:22:52 +00:00
proxy_unittest.cc
In pc/ replace mock macros with unified MOCK_METHOD macro
2020-05-18 17:06:25 +00:00
remote_audio_source.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
remote_audio_source.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
rtc_stats_collector_unittest.cc
stats: add transportId to codec stats
2020-11-17 12:34:39 +00:00
rtc_stats_collector.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
rtc_stats_collector.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
rtc_stats_integrationtest.cc
Prefix HAVE_SCTP macro with WEBRTC_.
2021-01-20 10:51:07 +00:00
rtc_stats_traversal_unittest.cc
…
rtc_stats_traversal.cc
stats: add transportId to codec stats
2020-11-17 12:34:39 +00:00
rtc_stats_traversal.h
…
rtcp_mux_filter_unittest.cc
…
rtcp_mux_filter.cc
…
rtcp_mux_filter.h
…
rtp_data_channel.cc
Split DataChannel into two separate classes for RTP and SCTP.
2020-07-10 00:03:21 +00:00
rtp_data_channel.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
rtp_media_utils_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
rtp_media_utils.cc
Reland "Implement transceiver.stop()"
2020-08-11 10:46:23 +00:00
rtp_media_utils.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
rtp_parameters_conversion_unittest.cc
Delete obsolete unused rtp header extension conversion
2020-01-09 09:28:07 +00:00
rtp_parameters_conversion.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
rtp_parameters_conversion.h
Delete obsolete unused rtp header extension conversion
2020-01-09 09:28:07 +00:00
rtp_receiver.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
rtp_receiver.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
rtp_sender_receiver_unittest.cc
Delete MediaTransportInterface and DatagramTransportInterface
2020-06-17 08:41:14 +00:00
rtp_sender.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
rtp_sender.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
rtp_transceiver_unittest.cc
SetOfferedRtpHeaderExtensions: fix error code.
2021-01-14 17:46:25 +00:00
rtp_transceiver.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
rtp_transceiver.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
rtp_transmission_manager.cc
Eliminate sigslot from RtpTransmissionManager
2020-11-10 14:41:45 +00:00
rtp_transmission_manager.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
rtp_transport_internal.h
Remove rtp_ and rtcp_packet_transport() from the RtpTransport interface.
2019-05-24 23:58:46 +00:00
rtp_transport_unittest.cc
Extend NetworkRoute with more info about local/remote endpoints
2020-03-20 16:55:38 +00:00
rtp_transport.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
rtp_transport.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
sctp_data_channel_transport.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
sctp_data_channel_transport.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
sctp_data_channel.cc
Remove use of AsyncInvoker from SctpDataChannel
2020-09-21 08:12:50 +00:00
sctp_data_channel.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
sctp_transport_unittest.cc
Make SCTPtransport enter "closed" state when DTLStransport does.
2019-11-16 14:56:01 +00:00
sctp_transport.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
sctp_transport.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
sctp_utils_unittest.cc
Use rtc::CopyOnWriteBuffer::MutableData through webrtc
2021-01-11 11:31:33 +00:00
sctp_utils.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
sctp_utils.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
sdp_offer_answer.cc
Revert "Do all BaseChannel operations within a single Thread::Invoke."
2021-01-29 21:56:38 +00:00
sdp_offer_answer.h
Revert "Do all BaseChannel operations within a single Thread::Invoke."
2021-01-29 21:56:38 +00:00
sdp_serializer_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
sdp_serializer.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
sdp_serializer.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
sdp_state_provider.h
Break circular dependency on WebRtcSessionDescriptionFactory
2020-10-26 10:22:46 +00:00
sdp_utils.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
sdp_utils.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
session_description_unittest.cc
Signal extmap-allow-mixed by default on session level
2021-01-19 14:28:11 +00:00
session_description.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
session_description.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
simulcast_description.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
simulcast_description.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
srtp_filter_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
srtp_filter.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
srtp_filter.h
Replace rtc::ThreadChecker with webrtc::SequenceChecker
2021-02-02 14:56:27 +00:00
srtp_session_unittest.cc
Remove unused critical section includes.
2020-07-16 13:52:28 +00:00
srtp_session.cc
dump raw rtp packets in text2pcap format
2020-12-04 15:33:06 +00:00
srtp_session.h
Replace rtc::ThreadChecker with webrtc::SequenceChecker
2021-02-02 14:56:27 +00:00
srtp_transport_unittest.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
srtp_transport.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
srtp_transport.h
Format almost everything.
2019-07-08 13:45:15 +00:00
stats_collector_interface.h
Separate PeerConnection's self-message functions to a new file
2020-10-05 12:41:23 +00:00
stats_collector_unittest.cc
Move pc/media_stream_track.h to the api/ directory
2020-10-12 07:28:01 +00:00
stats_collector.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
stats_collector.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
stream_collection.h
…
track_media_info_map_unittest.cc
Don't wrap the main thread when running death tests.
2020-05-17 17:15:10 +00:00
track_media_info_map.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
track_media_info_map.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
transceiver_list.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
transceiver_list.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
transport_stats.cc
…
transport_stats.h
Implement crypto stats on DTLS transport
2019-10-28 11:30:23 +00:00
usage_pattern.cc
Move the PeerConnection's usage pattern concept to its own file.
2020-10-09 08:29:45 +00:00
usage_pattern.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
used_ids_unittest.cc
Always pass arguments to INSTANTIATE_TEST_SUITE_P.
2019-09-24 08:56:24 +00:00
used_ids.h
Add support for two-byte RTP header extensions to UsedRtpHeaderExtensionIds
2019-06-24 08:50:07 +00:00
video_rtp_receiver_unittest.cc
In pc/ replace mock macros with unified MOCK_METHOD macro
2020-05-18 17:06:25 +00:00
video_rtp_receiver.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
video_rtp_receiver.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
video_rtp_track_source_unittest.cc
In pc/ replace mock macros with unified MOCK_METHOD macro
2020-05-18 17:06:25 +00:00
video_rtp_track_source.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
video_rtp_track_source.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
video_track_source.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
video_track_source.h
Replace rtc::ThreadChecker with webrtc::SequenceChecker
2021-02-02 14:56:27 +00:00
video_track_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
video_track.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
video_track.h
Replace rtc::ThreadChecker with webrtc::SequenceChecker
2021-02-02 14:56:27 +00:00
webrtc_sdp_unittest.cc
sdp: check that sctp is on a application content type
2021-01-29 10:54:00 +00:00
webrtc_sdp.cc
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
webrtc_sdp.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00
webrtc_session_description_factory.cc
Remove one use of sigslot from webrtc_session_description_factory
2020-11-09 16:13:15 +00:00
webrtc_session_description_factory.h
Running apply-iwyu on ~all files in pc/
2021-01-29 16:14:10 +00:00