edacbd53de
This is a reland of fb6f975401972635a644c0db06c135b4c0aaef4a. Related issue in chromium is fixed here: https://chromium-review.googlesource.com/c/chromium/src/+/2287294 Original change's description: > Implement packets_(sent | received) for RTCTransportStats > > Bug: webrtc:11756 > Change-Id: Ic0caad6d4675969ef3ae886f50326e4a2e1cbfe7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178741 > Reviewed-by: Tommi <tommi@webrtc.org> > Reviewed-by: Henrik Boström <hbos@webrtc.org> > Commit-Queue: Artem Titov <titovartem@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#31643} Bug: webrtc:11756 Change-Id: I1e310e3d23248500eb7dabd23d0ce6c4ec4cb8c6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178871 Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31700}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.