1983458981
This reverts commit d5a7838926b839469db1072d72a92e6814f2faeb. Reason for revert: Causing errors in downstream tests. Original change's description: > Reland "Correct AEC3 multichannel functionality activation" > > This is a reland of 9dda1b3a484ebeef921e419406402039f3852427 > > Original change's description: > > Correct AEC3 multichannel functionality activation > > > > This CL corrects the AEC3 multichannel activation > > to also work for the case when a factory is used > > for the activation. > > > > Bug: webrtc:10913 > > Change-Id: Ic2807d8bcef759261fde14447cff30633ba248dc > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158794 > > Commit-Queue: Per Åhgren <peah@webrtc.org> > > Reviewed-by: Sam Zackrisson <saza@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#29676} > > Bug: webrtc:10913 > Change-Id: Ibfe4e8a51183390a4054514bb294c89c2ea201e9 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158880 > Reviewed-by: Sam Zackrisson <saza@webrtc.org> > Commit-Queue: Per Åhgren <peah@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29685} TBR=saza@webrtc.org,peah@webrtc.org Change-Id: I6e27bc7fd1c9d4d5550fdc6ae14c39ca84fb03f8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:10913 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158883 Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29687}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.