18b94b517d
This CL focuses on addressing the remaining TODO items in the `//rtc_base/bounded_inline_vector_impl.h` file, mainly involving the two functions `void DefaultInitializeElements` and `void MoveElements`. In the `void DefaultInitializeElements` function, the placement new usage is adopted. When using placement new, manual construction operations on objects are usually required, and a fair amount of logic needs to be written to ensure correct object construction. In contrast, the `std::uninitialized_default_construct_n()` function only requires passing in the starting address of the memory and the number of objects to be constructed, and it can automatically construct objects in batches. In the `void MoveElements` function, the original implementation also uses the placement new usage. When using placement new to move objects, manual handling of the moving operation for each object is required, and usually, `std::move` needs to be combined to achieve the object's move semantics. However, the `std::uninitialized_move_n()` function can automatically complete the object moving process just by passing in specific parameters. To improve the code's simplicity, it is considered to use `std::uninitialized_default_construct_n()` and `std::uninitialized_move_n()` to replace the original two placement new usages. Fixed: webrtc:392037564 Change-Id: If8edcd9ac8a4d85be0ce0a23f6433d7f91b39ad3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/375182 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Ho Cheung <hocheung@chromium.org> Cr-Commit-Position: refs/heads/main@{#43831}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
Development
See here for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.
More info
- Official web site: http://www.webrtc.org
- Master source code repo: https://webrtc.googlesource.com/src
- Samples and reference apps: https://github.com/webrtc
- Mailing list: http://groups.google.com/group/discuss-webrtc
- Continuous build: https://ci.chromium.org/p/webrtc/g/ci/console
- Coding style guide
- Code of conduct
- Reporting bugs
- Documentation