181ea6e414
According to the Google Objective-C style [1], category names should
start with an appropriate prefix. WebRTC has some category definitions
for system interfaces, but it doesn't use prefixes.
$ otool -ov WebRTC.framework/WebRTC | grep -E "^[0-9a-z]{16} 0x[0-9a-z]+ __OBJC_._CATEGORY" | grep -v "_RTC"
0000000002160840 0x217c3c0 __OBJC_$_CATEGORY_UIDevice_$_H264Profile
0000000002160850 0x21808b8 __OBJC_$_CATEGORY_AVCaptureSession_$_DevicePosition
0000000002160858 0x2180968 __OBJC_$_CATEGORY_NSString_$_StdString
0000000002160860 0x21809c8 __OBJC_$_CATEGORY_NSString_$_AbslStringView
To avoid conflicts, prefix the names and methods of those categories.
Also remove sdk/objc/Framework/Classes/Common/NSString+StdString.h as
it is not used by any other files.
[1] https://google.github.io/styleguide/objcguide.html#category-naming
Bug: webrtc:13884
Change-Id: I2cf2742af198ab4e0bfb15c0476d72971e50ceee
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262341
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36880}
58 lines
1.9 KiB
Plaintext
58 lines
1.9 KiB
Plaintext
/*
|
|
* Copyright 2015 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#import "RTCLegacyStatsReport+Private.h"
|
|
|
|
#import "base/RTCLogging.h"
|
|
#import "helpers/NSString+RTCStdString.h"
|
|
|
|
#include "rtc_base/checks.h"
|
|
|
|
@implementation RTC_OBJC_TYPE (RTCLegacyStatsReport)
|
|
|
|
@synthesize timestamp = _timestamp;
|
|
@synthesize type = _type;
|
|
@synthesize reportId = _reportId;
|
|
@synthesize values = _values;
|
|
|
|
- (NSString *)description {
|
|
return [NSString stringWithFormat:@"RTC_OBJC_TYPE(RTCLegacyStatsReport):\n%@\n%@\n%f\n%@",
|
|
_reportId,
|
|
_type,
|
|
_timestamp,
|
|
_values];
|
|
}
|
|
|
|
#pragma mark - Private
|
|
|
|
- (instancetype)initWithNativeReport:(const webrtc::StatsReport &)nativeReport {
|
|
if (self = [super init]) {
|
|
_timestamp = nativeReport.timestamp();
|
|
_type = [NSString rtc_stringForStdString:nativeReport.TypeToString()];
|
|
_reportId = [NSString rtc_stringForStdString:nativeReport.id()->ToString()];
|
|
|
|
NSUInteger capacity = nativeReport.values().size();
|
|
NSMutableDictionary *values =
|
|
[NSMutableDictionary dictionaryWithCapacity:capacity];
|
|
for (auto const &valuePair : nativeReport.values()) {
|
|
NSString *key = [NSString rtc_stringForStdString:valuePair.second->display_name()];
|
|
NSString *value = [NSString rtc_stringForStdString:valuePair.second->ToString()];
|
|
|
|
// Not expecting duplicate keys.
|
|
RTC_DCHECK(![values objectForKey:key]);
|
|
[values setObject:value forKey:key];
|
|
}
|
|
_values = values;
|
|
}
|
|
return self;
|
|
}
|
|
|
|
@end
|