The reason we are doing this is because the "committers" group grants access to Code-Review, and we now have a policy that such groups must only contain direct human users. However, we still want robot accounts to be able to CQ+2, so we now have the -submit-access group that includes anyone who can CQ+2, not just committers. Bug: chromium:356276684 Change-Id: I39c3b92110ff10f53a2825f5e12690580331364d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/363480 Reviewed-by: Christoffer Dewerin <jansson@webrtc.org> Auto-Submit: Joey Scarr <jsca@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#43073}
infra/config folder
This folder contains WebRTC project-wide configurations for Chrome infra services, mainly the CI system (console).
*.cfg files are the actual configuration that LUCI looks at.
They are in protocol buffer text format. For example,
cr-buildbucket.cfg defines builders.
However, they are all automatically generated from the Starlark script config.star that defines a unified config using lucicfg. The main body of the config is at the bottom of the file, following all the helper definitions.
lucicfg should be available as part of depot_tools. After editing
config.star you should run lucicfg generate config.star to
re-generate *.cfg files. Check the diffs in generated files to confirm that
your change worked as expected. Both the code change and the generated changes
need to be committed together.
Uploading changes
It is recommended to have a separate checkout for this branch, so switching to/from it does not populate/delete all files in the main branch.
Initial setup:
git clone https://webrtc.googlesource.com/src/
Now you can create a new branch to make changes:
git new-branch add-new-builder
# edit/generate files
git commit -a
git cl upload
Changes can be reviewed on Gerrit and submitted with commit queue as usual.
Activating the changes
Any changes to this directory go live soon after landing, without any additional steps. You can see the status or force a refresh of the config at luci-config.