15845af3cd
This reverts commit 727504cf493f9e03952a6e88348976385a49b9e2. Reason for revert: Added required INCLUDE to fix compile errors. Original change's description: > Revert "Another mock for GetSctpTransport" > > This reverts commit b2c4700d39fbedaff9bdbee934e1f3f8032bb35b. > > Reason for revert: Breaks Chrome build > > Original change's description: > > Another mock for GetSctpTransport > > > > Bug: chromium:818643 > > Change-Id: I4ae7826efa7afa8e7b2ecd8a5928071a1b913ded > > Reviewed-on: https://webrtc-review.googlesource.com/c/125340 > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#26941} > > TBR=kwiberg@webrtc.org,hta@webrtc.org > > Change-Id: I98ddc61ca1e76d69b84138419d91ad9e40b04b1d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:818643 > Reviewed-on: https://webrtc-review.googlesource.com/c/125380 > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#26943} TBR=kwiberg@webrtc.org,hta@webrtc.org Change-Id: I3eb410427f6660cd00319b43e7096bd634290e8a Bug: chromium:818643 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/125381 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26964}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.