5c8993cba0
This reverts commit b5ab062a3e384bf20e9d916211f824bc59b3f62d. Reason for revert: The CL was not the culprit. Original change's description: > Revert "Add 2 additional tests config in waterfalls.pyl." > > This reverts commit 429c1bd74d5b821a360be6a215bcbe7c422bedeb. > > Reason for revert: It breaks some CQ bots (e.g. https://ci.chromium.org/ui/p/webrtc/builders/try/linux_compile_rel/42825/overview). I am reverting to check is this is the culprit. > > Original change's description: > > Add 2 additional tests config in waterfalls.pyl. > > > > * Add a presubmit check that generate_builbot_json.py has been called. > > * Add a webrtc_mixins.pyl file. > > > > Bug: webrtc:13899 > > Change-Id: I7c4226ddd80bf9376bcb91476a1446a0392e7ec6 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257904 > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > > Commit-Queue: Jeremy Leconte <jleconte@google.com> > > Cr-Commit-Position: refs/heads/main@{#36428} > > Bug: webrtc:13899 > Change-Id: Ic79306688c26937a988a9eacb4799f53f7145c65 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257919 > Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#36431} Bug: webrtc:13899 Change-Id: Id0ac9a98744fa5019cbb69bbd1e53e138f887e9e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257980 Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36433}
infra/config folder
This folder contains WebRTC project-wide configurations for Chrome infra services, mainly the CI system (console).
*.cfg files are the actual configuration that LUCI looks at.
They are in protocol buffer text format. For example,
cr-buildbucket.cfg defines builders.
However, they are all automatically generated from the Starlark script config.star that defines a unified config using lucicfg. The main body of the config is at the bottom of the file, following all the helper definitions.
lucicfg should be available as part of depot_tools. After editing
config.star you should run lucicfg generate config.star to
re-generate *.cfg files. Check the diffs in generated files to confirm that
your change worked as expected. Both the code change and the generated changes
need to be committed together.
Uploading changes
It is recommended to have a separate checkout for this branch, so switching to/from it does not populate/delete all files in the master branch.
Initial setup:
git clone https://webrtc.googlesource.com/src/
Now you can create a new branch to make changes:
git new-branch add-new-builder
# edit/generate files
git commit -a
git cl upload
Changes can be reviewed on Gerrit and submitted with commit queue as usual.
Activating the changes
Any changes to this directory go live soon after landing, without any additional steps. You can see the status or force a refresh of the config at luci-config.