11a89c99e9
This is a reland of ba29ce320fe1f9ac69b0ff8eb50fbe402c2912a6 readding the origin to the CreateRelayPortArgs structure to not break downstream tests yet: https://webrtc-review.googlesource.com/c/src/+/235300/1..2 Original change's description: > remove stun origin support > > Bug: webrtc:12132 > Change-Id: I0f32e6af77e0c553b0c3b0d047ff03e14c492b31 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/234384 > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#35202} Bug: webrtc:12132 Change-Id: Ied840b59bb7c9497e98f9b80eb0a54d30008a40f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/235300 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35220}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.