111de34102
This reverts commit f2969fa868f4913583e79f74ceced5cc6b7d6b7d. Reason for revert: Breaks blink_platform_unittests; sample failure: https://ci.chromium.org/p/chromium/builders/try/linux-rel/500046 Original change's description: > Delete the non-const version of the EncodedImage::data() method. > > Bug: webrtc:9378 > Change-Id: I84ace3ca6a2eb4d0f7c3d4e62f815d77df581bfa > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185122 > Reviewed-by: Artem Titov <titovartem@webrtc.org> > Reviewed-by: Philip Eliasson <philipel@webrtc.org> > Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> > Commit-Queue: Niels Moller <nisse@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32197} TBR=ilnik@webrtc.org,nisse@webrtc.org,philipel@webrtc.org,titovartem@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:9378 Change-Id: I6374d263e2ee10da318ab1e040ed18bed7a96edd Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185507 Reviewed-by: Marina Ciocea <marinaciocea@webrtc.org> Commit-Queue: Marina Ciocea <marinaciocea@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32205}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.