This makes the delay manager interface significantly simpler and easier to expose. Bug: None Change-Id: Ie3d37c3b869eb17ca421a76e9d1af8f0a1a36ee5 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/364781 Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Cr-Commit-Position: refs/heads/main@{#43186}
119 lines
3.6 KiB
C++
119 lines
3.6 KiB
C++
/*
|
|
* Copyright (c) 2024 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "modules/audio_coding/neteq/delay_constraints.h"
|
|
|
|
#include <algorithm>
|
|
|
|
#include "rtc_base/logging.h"
|
|
#include "rtc_base/numerics/safe_minmax.h"
|
|
|
|
namespace webrtc {
|
|
|
|
constexpr int kMinBaseMinimumDelayMs = 0;
|
|
constexpr int kMaxBaseMinimumDelayMs = 10000;
|
|
|
|
DelayConstraints::DelayConstraints(int max_packets_in_buffer,
|
|
int base_minimum_delay_ms)
|
|
: max_packets_in_buffer_(max_packets_in_buffer),
|
|
base_minimum_delay_ms_(base_minimum_delay_ms),
|
|
effective_minimum_delay_ms_(base_minimum_delay_ms),
|
|
minimum_delay_ms_(0),
|
|
maximum_delay_ms_(0) {}
|
|
|
|
int DelayConstraints::Clamp(int delay_ms) const {
|
|
delay_ms = std::max(delay_ms, effective_minimum_delay_ms_);
|
|
if (maximum_delay_ms_ > 0) {
|
|
delay_ms = std::min(delay_ms, maximum_delay_ms_);
|
|
}
|
|
if (packet_len_ms_ > 0) {
|
|
// Limit to 75% of maximum buffer size.
|
|
delay_ms =
|
|
std::min(delay_ms, 3 * max_packets_in_buffer_ * packet_len_ms_ / 4);
|
|
}
|
|
return delay_ms;
|
|
}
|
|
|
|
bool DelayConstraints::SetPacketAudioLength(int length_ms) {
|
|
if (length_ms <= 0) {
|
|
RTC_LOG_F(LS_ERROR) << "length_ms = " << length_ms;
|
|
return false;
|
|
}
|
|
packet_len_ms_ = length_ms;
|
|
return true;
|
|
}
|
|
|
|
bool DelayConstraints::IsValidMinimumDelay(int delay_ms) const {
|
|
return 0 <= delay_ms && delay_ms <= MinimumDelayUpperBound();
|
|
}
|
|
|
|
bool DelayConstraints::IsValidBaseMinimumDelay(int delay_ms) const {
|
|
return kMinBaseMinimumDelayMs <= delay_ms &&
|
|
delay_ms <= kMaxBaseMinimumDelayMs;
|
|
}
|
|
|
|
bool DelayConstraints::SetMinimumDelay(int delay_ms) {
|
|
if (!IsValidMinimumDelay(delay_ms)) {
|
|
return false;
|
|
}
|
|
|
|
minimum_delay_ms_ = delay_ms;
|
|
UpdateEffectiveMinimumDelay();
|
|
return true;
|
|
}
|
|
|
|
bool DelayConstraints::SetMaximumDelay(int delay_ms) {
|
|
// If `delay_ms` is zero then it unsets the maximum delay and target level is
|
|
// unconstrained by maximum delay.
|
|
if (delay_ms != 0 && delay_ms < minimum_delay_ms_) {
|
|
// Maximum delay shouldn't be less than minimum delay or less than a packet.
|
|
return false;
|
|
}
|
|
|
|
maximum_delay_ms_ = delay_ms;
|
|
UpdateEffectiveMinimumDelay();
|
|
return true;
|
|
}
|
|
|
|
bool DelayConstraints::SetBaseMinimumDelay(int delay_ms) {
|
|
if (!IsValidBaseMinimumDelay(delay_ms)) {
|
|
return false;
|
|
}
|
|
|
|
base_minimum_delay_ms_ = delay_ms;
|
|
UpdateEffectiveMinimumDelay();
|
|
return true;
|
|
}
|
|
|
|
int DelayConstraints::GetBaseMinimumDelay() const {
|
|
return base_minimum_delay_ms_;
|
|
}
|
|
|
|
void DelayConstraints::UpdateEffectiveMinimumDelay() {
|
|
// Clamp `base_minimum_delay_ms_` into the range which can be effectively
|
|
// used.
|
|
const int base_minimum_delay_ms =
|
|
rtc::SafeClamp(base_minimum_delay_ms_, 0, MinimumDelayUpperBound());
|
|
effective_minimum_delay_ms_ =
|
|
std::max(minimum_delay_ms_, base_minimum_delay_ms);
|
|
}
|
|
|
|
int DelayConstraints::MinimumDelayUpperBound() const {
|
|
// Choose the lowest possible bound discarding 0 cases which mean the value
|
|
// is not set and unconstrained.
|
|
int q75 = max_packets_in_buffer_ * packet_len_ms_ * 3 / 4;
|
|
q75 = q75 > 0 ? q75 : kMaxBaseMinimumDelayMs;
|
|
const int maximum_delay_ms =
|
|
maximum_delay_ms_ > 0 ? maximum_delay_ms_ : kMaxBaseMinimumDelayMs;
|
|
return std::min(maximum_delay_ms, q75);
|
|
}
|
|
|
|
} // namespace webrtc
|