6c7f98472e
This cl/ adds the feature actually injecting a FieldTrialsView into PeerConnectionFactory, or into a PeerConnection or both. The field trials used for a PeerConnection is those specified in PeerConnectionDependencies. Otherwise will those from PeerConnectionFactoryDependencies be used (and until we're finished with this conversion, the global string fallback is used as last resort). Note that it is currently not possible to create 2 FieldTrials objects concurrently...due to global string, so this cl/ is mostly (but entirely) for show, i.e one _can_ realistically inject them into a PeerConnectionFactory. Bug: webrtc:10335 Change-Id: Id2e60525f48a1f8293c1dd0be771e3ed03790963 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258134 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Jonas Oreland <jonaso@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36578}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.