f25761d798
The 'Module' part of the implementation must not be called via the RtpRtcp interface, but is rather a part of the contract with ProcessThread. That in turn is an implementation detail for how timers are currently implemented in the default implementation. Along the way I'm deprecating away the factory function which was inside the interface and tied it to one specific implementation. Instead, I'm moving that to the implementation itself and down the line, we don't have to go through it if we just want to create an instance of the class. The key change is in rtp_rtcp.h and the new rtp_rtcp_interface.h header file (things moved from rtp_rtcp.h), the rest falls from that. Change-Id: I294f13e947b9e3e4e649400ee94a11a81e8071ce Bug: webrtc:11581 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176419 Reviewed-by: Magnus Flodman <mflodman@webrtc.org> Commit-Queue: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31440}
52 lines
1.6 KiB
C++
52 lines
1.6 KiB
C++
/*
|
|
* Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_
|
|
#define MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_
|
|
|
|
#include <memory>
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
#include "modules/include/module.h"
|
|
#include "modules/rtp_rtcp/source/rtp_rtcp_interface.h"
|
|
#include "rtc_base/deprecation.h"
|
|
|
|
namespace webrtc {
|
|
|
|
// DEPRECATED. Do not use.
|
|
class RtpRtcp : public Module, public RtpRtcpInterface {
|
|
public:
|
|
// Instantiates a deprecated version of the RtpRtcp module.
|
|
static std::unique_ptr<RtpRtcp> RTC_DEPRECATED
|
|
Create(const Configuration& configuration) {
|
|
return DEPRECATED_Create(configuration);
|
|
}
|
|
|
|
static std::unique_ptr<RtpRtcp> DEPRECATED_Create(
|
|
const Configuration& configuration);
|
|
|
|
// (De)registers RTP header extension type and id.
|
|
// Returns -1 on failure else 0.
|
|
RTC_DEPRECATED virtual int32_t RegisterSendRtpHeaderExtension(
|
|
RTPExtensionType type,
|
|
uint8_t id) = 0;
|
|
|
|
// Requests new key frame.
|
|
// using PLI, https://tools.ietf.org/html/rfc4585#section-6.3.1.1
|
|
void SendPictureLossIndication() { SendRTCP(kRtcpPli); }
|
|
// using FIR, https://tools.ietf.org/html/rfc5104#section-4.3.1.2
|
|
void SendFullIntraRequest() { SendRTCP(kRtcpFir); }
|
|
};
|
|
|
|
} // namespace webrtc
|
|
|
|
#endif // MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_
|