096ad02c02
This reverts commit 5ffefe9d2d743c66f8a8bcbc5ad9662a3138840a. Reason for revert: Breaks Chromium Android browser tests on fyi bots. Original change's description: > Fix race between enabled() and set_enabled() in VideoTrack. > > Along the way I introduced VideoSourceBaseGuarded, which is equivalent > to VideoSourceBase except that it applies thread checks. I found that > it's easy to use VideoSourceBase incorrectly and in fact there appear > to be tests that do this. > > I made the source object const in VideoTrack, as it already was in > AudioTrack, and that allowed for making the GetSource() accessors > bypass the proxy thread hop and give the caller direct access. > > Bug: webrtc:12773, b/188139639, webrtc:12780 > Change-Id: I022175c4239a1306ef54059c131d81411d5124fe > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219160 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Andrey Logvin <landrey@webrtc.org> > Commit-Queue: Tommi <tommi@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#34096} TBR=mbonadei@webrtc.org,tommi@webrtc.org,landrey@webrtc.org,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I16323d459c76eb6a87cc602a0048f6ee01c81626 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:12773 Bug: b/188139639 Bug: webrtc:12780 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219637 Reviewed-by: Evan Shrubsole <eshr@google.com> Commit-Queue: Evan Shrubsole <eshr@google.com> Cr-Commit-Position: refs/heads/master@{#34101}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.