fb98b9edb4
Reason for revert: Reverting temporarily. Need to fix tests downstream that pass invalid arguments. Original issue's description: > Adding a some checks and switching out a few assert for RTC_[D]CHECK. > These changes are around use of AudioFrame.data_ to help us catch issues earlier since assert() is left out in release builds, including builds with DCHECK enabled. I've also added a few full-on CHECKs to avoid reading past buffer boundaries or continuing on in a failed state. > > BUG=chromium:613482 > NOTRY=true > (using notry due to offline android_arm64_rel bot) > > Committed: https://crrev.com/d36df89d40bde3c62ee5cbff841933e50b3c007b > Cr-Commit-Position: refs/heads/master@{#12870} TBR=henrik.lundin@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:613482 Review-Url: https://codereview.webrtc.org/2006243002 Cr-Commit-Position: refs/heads/master@{#12874}
29 lines
1.1 KiB
C++
29 lines
1.1 KiB
C++
/*
|
|
* Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "testing/gtest/include/gtest/gtest.h"
|
|
#include "webrtc/common_audio/resampler/include/push_resampler.h"
|
|
|
|
// Quality testing of PushResampler is handled through output_mixer_unittest.cc.
|
|
|
|
namespace webrtc {
|
|
|
|
TEST(PushResamplerTest, VerifiesInputParameters) {
|
|
PushResampler<int16_t> resampler;
|
|
EXPECT_EQ(-1, resampler.InitializeIfNeeded(-1, 16000, 1));
|
|
EXPECT_EQ(-1, resampler.InitializeIfNeeded(16000, -1, 1));
|
|
EXPECT_EQ(-1, resampler.InitializeIfNeeded(16000, 16000, 0));
|
|
EXPECT_EQ(-1, resampler.InitializeIfNeeded(16000, 16000, 3));
|
|
EXPECT_EQ(0, resampler.InitializeIfNeeded(16000, 16000, 1));
|
|
EXPECT_EQ(0, resampler.InitializeIfNeeded(16000, 16000, 2));
|
|
}
|
|
|
|
} // namespace webrtc
|