Reason for revert: This breaks our Chromium WebRTC FYI bots: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/6173 /mnt/data/b/build/slave/Linux_Builder/build/src/buildtools/linux64/gn gen //out/Release --check -> returned 1 ERROR at //content/renderer/media/rtc_video_decoder.cc:24:11: Can't include this header from here. #include "third_party/webrtc/video_frame.h" ^------------------------------- The target: //content/renderer:renderer is including a file from the target: //third_party/webrtc:webrtc_common The //content/renderer:renderer target should probably be updated to depend on //third_party/webrtc:webrtc_common before relanding this. Original issue's description: > Add missing headers and fix some missing dependencies > > This is the first CL in a series of major cleanup and dependency > corrections needed in order to satisfy 'gn check'. > > BUG=webrtc:4243, webrtc:5589 > NOTRY=True > > Committed: https://crrev.com/7bb6e75723eb64af079446cc6e3ff08c74fe02e4 > Cr-Commit-Position: refs/heads/master@{#12790} TBR=pbos@webrtc.org,henrika@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4243, webrtc:5589 Review-Url: https://codereview.webrtc.org/1989823002 Cr-Commit-Position: refs/heads/master@{#12793}
26 lines
740 B
Python
26 lines
740 B
Python
# Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
|
|
#
|
|
# Use of this source code is governed by a BSD-style license
|
|
# that can be found in the LICENSE file in the root of the source
|
|
# tree. An additional intellectual property rights grant can be found
|
|
# in the file PATENTS. All contributing project authors may
|
|
# be found in the AUTHORS file in the root of the source tree.
|
|
{
|
|
'includes': ['build/common.gypi'],
|
|
'targets': [
|
|
{
|
|
'target_name': 'webrtc_common',
|
|
'type': 'static_library',
|
|
'sources': [
|
|
'audio_sink.h',
|
|
'common_types.cc',
|
|
'common_types.h',
|
|
'config.h',
|
|
'config.cc',
|
|
'engine_configurations.h',
|
|
'typedefs.h',
|
|
],
|
|
},
|
|
],
|
|
}
|