05497f294a
DataChannelTransportInterface takes the OpenChannel, SendData, CloseChannel, and SetDataSink methods. MediaTransportInterface inherits from DataChannelTransportInterface. DatagramTransportInterface, the newer alternative to MediaTransportInterface, also inherits from DataChannelTransportInterface. This will allow further refactors to enable the use of media-transport style data channels alongside the datagram transport. Bug: webrtc:9719 Change-Id: I2dd873785ea52d38055b62545c17e9e17c4e70c6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147840 Reviewed-by: Steve Anton <steveanton@webrtc.org> Commit-Queue: Bjorn Mellem <mellem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28846}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.