049b43bd02
Compiling webrtc with `-Werror=unused-parameters` is failling duo to those parameters. Also, it shouldn't harm us to put those in comment for code readability as well. NOTE: This time I made sure to iterate over the C files in the audio_processing folder and compile them using gcc. On the original CL that was reverted - that failed with the same error Danil mentioned. This time it seems fine. I'll make sure to run the same script on the rest of my CLs for sanity Bug: webrtc:370878648 Change-Id: I83cea3a08777e21d26a95bcad503a2d1b74566eb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/364537 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Dor Hen <dorhen@meta.com> Cr-Commit-Position: refs/heads/main@{#43249}
38 lines
1.2 KiB
C++
38 lines
1.2 KiB
C++
/*
|
|
* Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef API_VIDEO_VIDEO_SINK_INTERFACE_H_
|
|
#define API_VIDEO_VIDEO_SINK_INTERFACE_H_
|
|
|
|
#include "api/video_track_source_constraints.h"
|
|
|
|
namespace rtc {
|
|
|
|
template <typename VideoFrameT>
|
|
class VideoSinkInterface {
|
|
public:
|
|
virtual ~VideoSinkInterface() = default;
|
|
|
|
virtual void OnFrame(const VideoFrameT& frame) = 0;
|
|
|
|
// Should be called by the source when it discards the frame due to rate
|
|
// limiting.
|
|
virtual void OnDiscardedFrame() {}
|
|
|
|
// Called on the network thread when video constraints change.
|
|
// TODO(crbug/1255737): make pure virtual once downstream project adapts.
|
|
virtual void OnConstraintsChanged(
|
|
const webrtc::VideoTrackSourceConstraints& /* constraints */) {}
|
|
};
|
|
|
|
} // namespace rtc
|
|
|
|
#endif // API_VIDEO_VIDEO_SINK_INTERFACE_H_
|