kwiberg 3a2c803dc3 Multiply in 64 bits to avoid overflow ...

A fuzzer run caused the operands of this multiplication to be 512 and
5000000, resulting in a product about 20% too large for int32_t. So
change this from a 16x32->32 to a 16x32->64 multiplication. Since we
right shift by 2 at the end, the end result will still fit in int32_t.

I also had to fix a few follow-on add/sub overflows found by the same
fuzzer input once the multiplication was fixed. I chose to saturate
these, since it wasn't just an intermediate value that overflowed.

BUG=chromium:693868

Review-Url: https://codereview.webrtc.org/2729573002
Cr-Commit-Position: refs/heads/master@{#17003}

2017-03-03 13:44:49 +00:00

..

arith_routines_hist.c

Refactor audio_coding/codecs/isac/fix: Removed usage of trivial macro WEBRTC_SPL_LSHIFT_W32()

2015-04-02 04:59:44 +00:00

arith_routines_logist.c

Reland "Upconvert various types to int.", isac portion.

2015-06-12 01:19:37 +00:00

arith_routines.c

audio_coding/codecs/isac/fix: Replaced macro WEBRTC_SPL_RSHIFT_W32 with >>"

2014-10-28 13:05:43 +00:00

arith_routins.h

Reland "Upconvert various types to int.", isac portion.

2015-06-12 01:19:37 +00:00

audio_decoder_isacfix.cc

audio_coding: rename interface -> include

2015-10-29 10:31:11 +00:00

audio_encoder_isacfix.cc

audio_coding: rename interface -> include

2015-10-29 10:31:11 +00:00

bandwidth_estimator.c

Replace calls to assert() with RTC_DCHECK_*() in .c code

2016-08-26 11:33:41 +00:00

bandwidth_estimator.h

Update a ton of audio code to use size_t more correctly and in general reduce

2015-08-24 21:52:45 +00:00

codec.h

Remove runtime NEON detection

2016-05-17 17:56:48 +00:00

decode_bwe.c

Update a ton of audio code to use size_t more correctly and in general reduce

2015-08-24 21:52:45 +00:00

decode_plc.c

Update a ton of audio code to use size_t more correctly and in general reduce

2015-08-24 21:52:45 +00:00

decode.c

Fix UBSan errors (left shift of negative value)

2016-05-23 10:28:35 +00:00

encode.c

Replace calls to assert() with RTC_DCHECK_*() in .c code

2016-08-26 11:33:41 +00:00

entropy_coding_mips.c

Reland rev 7041 with BUILD.gn files.

2014-09-04 13:28:48 +00:00

entropy_coding_neon.c

Replace calls to assert() with RTC_DCHECK_*() in .c code

2016-08-26 11:33:41 +00:00

entropy_coding.c

Multiply in 64 bits to avoid overflow

2017-03-03 13:44:49 +00:00

entropy_coding.h

Remove runtime NEON detection

2016-05-17 17:56:48 +00:00

fft.c

iSAC: Untangle some cyclic dependencies

2017-01-30 13:28:54 +00:00

fft.h

WebRtc_Word32 => int32_t etc. in audio_coding/

2013-04-09 00:28:06 +00:00

filterbank_internal.h

Remove runtime NEON detection

2016-05-17 17:56:48 +00:00

filterbank_tables.c

Move src/ -> webrtc/

2012-10-22 18:19:23 +00:00

filterbank_tables.h

Reland rev 7041 with BUILD.gn files.

2014-09-04 13:28:48 +00:00

filterbanks_mips.c

MIPS optimizations for ISAC (patch #2)

2014-07-21 16:43:13 +00:00

filterbanks_neon.c

Replace calls to assert() with RTC_DCHECK_*() in .c code

2016-08-26 11:33:41 +00:00

filterbanks_unittest.cc

Sort #includes that got unsorted when gmock.h and gtest.h moved to webrtc/test/

2016-10-01 05:29:53 +00:00

filterbanks.c

Replace calls to assert() with RTC_DCHECK_*() in .c code

2016-08-26 11:33:41 +00:00

filters_mips.c

MIPS optimizations for ISAC (patch #1)

2014-06-10 18:13:15 +00:00

filters_neon.c

Replace calls to assert() with RTC_DCHECK_*() in .c code

2016-08-26 11:33:41 +00:00

filters_unittest.cc

Sort #includes that got unsorted when gmock.h and gtest.h moved to webrtc/test/

2016-10-01 05:29:53 +00:00

filters.c

Replace calls to assert() with RTC_DCHECK_*() in .c code

2016-08-26 11:33:41 +00:00

initialize.c

Refactor audio_coding/codecs/isac: Removed usage of macro WEBRTC_SPL_MUL_16_16

2015-03-13 12:59:36 +00:00

isac_fix_type.h

audio_coding: rename interface -> include

2015-10-29 10:31:11 +00:00

isacfix.c

Replace calls to assert() with RTC_DCHECK_*() in .c code

2016-08-26 11:33:41 +00:00

lattice_armv7.S

system_wrappers: rename interface -> include

2015-10-28 17:17:50 +00:00

lattice_c.c

Update a ton of audio code to use size_t more correctly and in general reduce

2015-08-24 21:52:45 +00:00

lattice_mips.c

Revert "Avoiding size_t in MIPS."

2015-08-31 18:44:05 +00:00

lattice_neon.c

Fix bug in WebRtcIsacfix_FilterMaLoopNeon.

2015-04-01 09:43:22 +00:00

lattice.c

iSAC fix: Ignore overflow in signed left shift

2016-09-09 12:51:38 +00:00

lpc_masking_model_mips.c

MIPS optimizations for ISAC (patch #2)

2014-07-21 16:43:13 +00:00

lpc_masking_model_unittest.cc

Sort #includes that got unsorted when gmock.h and gtest.h moved to webrtc/test/

2016-10-01 05:29:53 +00:00

lpc_masking_model.c

Refactor audio_coding/codecs/isac/fix: Removed usage of macro WEBRTC_SPL_MUL_16_16_RSFT

2015-04-10 06:06:46 +00:00

lpc_masking_model.h

Replace asm NEON function by intrinsics implementation on ARMv7

2015-05-06 08:39:37 +00:00

lpc_tables.c

WebRtc_Word32 => int32_t etc. in audio_coding/

2013-04-09 00:28:06 +00:00

lpc_tables.h

Reland rev 7041 with BUILD.gn files.

2014-09-04 13:28:48 +00:00

pitch_estimator_c.c

Remove runtime NEON detection

2016-05-17 17:56:48 +00:00

pitch_estimator_mips.c

system_wrappers: rename interface -> include

2015-10-28 17:17:50 +00:00

pitch_estimator.c

system_wrappers: rename interface -> include

2015-10-28 17:17:50 +00:00

pitch_estimator.h

Update a ton of audio code to use size_t more correctly and in general reduce

2015-08-24 21:52:45 +00:00

pitch_filter_armv6.S

system_wrappers: rename interface -> include

2015-10-28 17:17:50 +00:00

pitch_filter_c.c

Update a ton of audio code to use size_t more correctly and in general reduce

2015-08-24 21:52:45 +00:00

pitch_filter_mips.c

Update a ton of audio code to use size_t more correctly and in general reduce

2015-08-24 21:52:45 +00:00

pitch_filter.c

Check for out-of-bounds access on |kIntrpCoef|.

2016-06-03 17:06:05 +00:00

pitch_gain_tables.c

WebRtc_Word32 => int32_t etc. in audio_coding/

2013-04-09 00:28:06 +00:00

pitch_gain_tables.h

Reland rev 7041 with BUILD.gn files.

2014-09-04 13:28:48 +00:00

pitch_lag_tables.c

WebRtc_Word32 => int32_t etc. in audio_coding/

2013-04-09 00:28:06 +00:00

pitch_lag_tables.h

Reland rev 7041 with BUILD.gn files.

2014-09-04 13:28:48 +00:00

settings.h

Prevent reading outside iSAC bitstream, if the stream is corrupted.

2014-10-07 00:21:02 +00:00

spectrum_ar_model_tables.c

WebRtc_Word32 => int32_t etc. in audio_coding/

2013-04-09 00:28:06 +00:00

spectrum_ar_model_tables.h

Reland rev 7041 with BUILD.gn files.

2014-09-04 13:28:48 +00:00

structs.h

Update a ton of audio code to use size_t more correctly and in general reduce

2015-08-24 21:52:45 +00:00

transform_mips.c

Reduce the number of registers used in MIPS optimizations.

2015-04-21 23:52:26 +00:00

transform_neon.c

Fix bug in transform_neon.c in iSAC codec.

2015-05-06 02:25:20 +00:00

transform_tables.c

Replace asm NEON function by intrinsics implementation on ARMv7

2015-05-06 08:39:37 +00:00

transform_unittest.cc

Sort #includes that got unsorted when gmock.h and gtest.h moved to webrtc/test/

2016-10-01 05:29:53 +00:00

transform.c

Fix UBSan errors (left shift of negative value)

2016-05-23 10:28:35 +00:00