Erik Språng
8226875e6c
Avoids race during VideoStreamEncoder unittest teardown
...
The ScopedFakeClock contains a lock. Due to declaration order, this is
the first member of VideoStreamEncoderTest to be destroyed. However,
there are cyclic tasks that may still be running at that time, and they
may try to read the time, so if we're unlucky they may trigger a use
after free condition.
This only affects test and is simply solved by moving the declaration
to before the classes that uses it.
Bug: webrtc:10929
Change-Id: I998d5ced877f355e4a45ee5cf75b2eb75faa6113
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150795
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29008}
2019-08-29 14:10:53 +00:00
..
2019-08-23 08:38:59 +00:00
2019-06-28 15:57:22 +00:00
2019-08-28 08:07:32 +00:00
2019-04-09 20:08:56 +00:00
2019-04-09 20:08:56 +00:00
2019-08-29 09:04:32 +00:00
2019-08-06 08:46:48 +00:00
2019-08-09 11:43:16 +00:00
2019-01-11 17:11:39 +00:00
2019-01-11 17:11:39 +00:00
2019-04-09 08:18:20 +00:00
2019-04-17 15:37:48 +00:00
2019-04-15 15:11:39 +00:00
2019-04-15 15:11:39 +00:00
2019-07-08 13:45:15 +00:00
2019-04-01 13:10:49 +00:00
2019-04-01 13:10:49 +00:00
2019-04-09 17:18:20 +00:00
2019-04-10 15:31:53 +00:00
2019-04-10 15:31:53 +00:00
2019-08-21 09:49:02 +00:00
2019-08-21 09:49:02 +00:00
2019-06-20 10:24:29 +00:00
2019-06-20 10:24:29 +00:00
2019-06-20 10:24:29 +00:00
2018-07-23 15:28:48 +00:00
2019-07-19 06:54:04 +00:00
2019-08-16 16:13:46 +00:00
2019-04-25 09:26:04 +00:00
2019-04-25 09:26:04 +00:00
2018-09-11 12:39:39 +00:00
2019-08-28 13:23:13 +00:00
2019-08-08 08:51:18 +00:00
2019-05-28 16:23:55 +00:00
2019-05-28 16:23:55 +00:00
2019-05-28 16:23:55 +00:00
2019-03-11 13:37:38 +00:00
2018-11-28 18:25:07 +00:00
2018-08-29 11:57:00 +00:00
2019-08-27 07:43:01 +00:00
2019-08-28 06:56:12 +00:00
2019-08-27 07:43:01 +00:00
2019-08-02 08:58:36 +00:00
2019-08-01 14:09:23 +00:00
2019-08-01 14:09:23 +00:00
2019-04-08 16:58:07 +00:00
2019-01-11 17:11:39 +00:00
2019-08-08 08:19:43 +00:00
2019-08-28 06:56:12 +00:00
2019-08-05 12:30:22 +00:00
2019-07-19 06:54:04 +00:00
2018-11-28 18:25:07 +00:00
2017-11-09 11:56:32 +00:00
2019-07-08 13:45:15 +00:00
2019-05-28 16:23:55 +00:00
2019-08-06 08:29:57 +00:00
2019-08-06 08:29:57 +00:00
2018-06-19 14:00:39 +00:00
2018-09-24 09:39:19 +00:00
2019-01-11 17:11:39 +00:00
2019-07-08 13:45:15 +00:00
2019-07-08 13:45:15 +00:00
2018-11-28 18:25:07 +00:00
2019-07-19 06:54:04 +00:00
2018-08-29 11:57:00 +00:00
2019-07-08 13:45:15 +00:00
2019-08-07 13:36:05 +00:00
2019-08-01 16:50:31 +00:00
2019-03-06 14:37:33 +00:00
2019-03-06 14:37:33 +00:00
2019-07-19 06:54:04 +00:00
2019-03-06 14:37:33 +00:00
2019-08-26 12:57:59 +00:00
2019-08-02 12:38:34 +00:00
2019-08-21 09:49:02 +00:00
2019-07-08 13:45:15 +00:00
2019-08-28 12:41:56 +00:00
2019-08-28 12:41:56 +00:00
2019-08-02 12:38:34 +00:00
2019-08-07 10:58:17 +00:00
2019-08-22 15:25:15 +00:00
2019-07-17 10:20:45 +00:00
2019-08-07 10:58:17 +00:00
2019-08-27 10:05:07 +00:00
2019-03-14 08:51:49 +00:00
2019-03-29 18:53:27 +00:00
2019-07-08 13:45:15 +00:00
2019-06-05 11:58:57 +00:00
2019-08-27 07:43:01 +00:00
2019-08-27 07:43:01 +00:00
2019-08-29 14:10:53 +00:00
2019-08-27 11:05:10 +00:00
2019-08-16 16:13:46 +00:00