00a30873c4
This reverts commit 133bf2bd28596aab5c7684e0ea3da99b1fece77f. Reason for revert: Breaks Chromium import due to flaky test in Chromium. Original change's description: > Reland "Distinguish between send and receive codecs" > > This reverts commit e57b266a20334e47f105a0bd777190ec8c6562e8. > > Reason for revert: Fixed negotiation of send-only clients. > > Original change's description: > > Revert "Distinguish between send and receive codecs" > > > > This reverts commit c0f25cf762a6946666c812f7a3df3f0a7f98b38d. > > > > Reason for revert: breaks negotiation with send-only clients > > > > (webrtc_video_engine.cc:985): SetRecvParameters called with unsupported video codec: VideoCodec[96:H264] > > (peer_connection.cc:6043): Failed to set local video description recv parameters. (INVALID_PARAMETER) > > (peer_connection.cc:2591): Failed to set local offer sdp: Failed to set local video description recv parameters. > > > > Original change's description: > > > Distinguish between send and receive codecs > > > > > > Even though send and receive codecs may be the same, they might have > > > different support in HW. Distinguish between send and receive codecs > > > to be able to keep track of which codecs have HW support. > > > > > > Bug: chromium:1029737 > > > Change-Id: Id119560becadfe0aaf861c892a6485f1c2eb378d > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165763 > > > Commit-Queue: Johannes Kron <kron@webrtc.org> > > > Reviewed-by: Steve Anton <steveanton@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#30284} > > > > TBR=steveanton@webrtc.org,kron@webrtc.org > > > > Change-Id: Iacb7059436b2313b52577b65f164ee363c4816aa > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: chromium:1029737 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166420 > > Reviewed-by: Steve Anton <steveanton@webrtc.org> > > Commit-Queue: Steve Anton <steveanton@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#30292} > > TBR=steveanton@webrtc.org,kron@webrtc.org > > > Bug: chromium:1029737 > Change-Id: I287efcfdcd1c9a3f2c410aeec8fe26a84204d1fd > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166604 > Reviewed-by: Johannes Kron <kron@webrtc.org> > Reviewed-by: Steve Anton <steveanton@webrtc.org> > Commit-Queue: Johannes Kron <kron@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#30348} TBR=steveanton@webrtc.org,kron@webrtc.org Change-Id: I9f8731309749e07ce7e651e1550ecfabddb1735f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1029737 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167205 Reviewed-by: Johannes Kron <kron@webrtc.org> Commit-Queue: Johannes Kron <kron@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30360}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.