006815eed0
This fixes the WebRTC roll in Chrome, which was failing because the //third_party/nearby library was transively including Chromes //base/check via WebRTC overrides by including api/peer_connection_interface.h which included api/proxy.h which included rtc_base/event.h which was overrided in webrtc_overrides. This override contains an include to base/check.h. Adding a temporary dependency on event.h fixes this for now. This can be removed once https://crbug.com/1212611 is fixed. Bug: None Change-Id: Id372e0737664d4a94ade0f75ae5fcf21f3db929f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219630 Reviewed-by: Tommi <tommi@webrtc.org> Commit-Queue: Evan Shrubsole <eshr@google.com> Cr-Commit-Position: refs/heads/master@{#34098}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.