92fa17660f
The desktop_capture code logs failed HRESULTs in several places,
the problem is that it tries to use a wchar* (when a char*
is required) for the error message and doesn't display the HRESULT
in hex. This makes the error logging less useful than it could be.
Example failure: error 08406B28, with code -2005270488
In this CL, I add a simple utility function to convert a _com_error
object to a std::string whic can be logged. With this change the
output looks like this (linebreak added for CL description):
Failed to capture frame: HRESULT: 0x887A0026,
Message: 'The keyed mutex was abandoned.'
I also adjusted the formatting of a few logging statements to be
more consistent (adding '<<' operators mostly).
Bug: webrtc:12051
Change-Id: I3e88ff6f2ff079fbe210626e1e89b2b053a742a9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/188522
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Joe Downing <joedow@google.com>
Cr-Commit-Position: refs/heads/master@{#32417}
59 lines
1.7 KiB
C++
59 lines
1.7 KiB
C++
/*
|
|
* Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "modules/desktop_capture/win/dxgi_texture_mapping.h"
|
|
|
|
#include <comdef.h>
|
|
#include <dxgi.h>
|
|
#include <dxgi1_2.h>
|
|
|
|
#include "modules/desktop_capture/win/desktop_capture_utils.h"
|
|
#include "rtc_base/checks.h"
|
|
#include "rtc_base/logging.h"
|
|
|
|
namespace webrtc {
|
|
|
|
DxgiTextureMapping::DxgiTextureMapping(IDXGIOutputDuplication* duplication)
|
|
: duplication_(duplication) {
|
|
RTC_DCHECK(duplication_);
|
|
}
|
|
|
|
DxgiTextureMapping::~DxgiTextureMapping() = default;
|
|
|
|
bool DxgiTextureMapping::CopyFromTexture(
|
|
const DXGI_OUTDUPL_FRAME_INFO& frame_info,
|
|
ID3D11Texture2D* texture) {
|
|
RTC_DCHECK_GT(frame_info.AccumulatedFrames, 0);
|
|
RTC_DCHECK(texture);
|
|
*rect() = {0};
|
|
_com_error error = duplication_->MapDesktopSurface(rect());
|
|
if (error.Error() != S_OK) {
|
|
*rect() = {0};
|
|
RTC_LOG(LS_ERROR)
|
|
<< "Failed to map the IDXGIOutputDuplication to a bitmap: "
|
|
<< desktop_capture::utils::ComErrorToString(error);
|
|
return false;
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
bool DxgiTextureMapping::DoRelease() {
|
|
_com_error error = duplication_->UnMapDesktopSurface();
|
|
if (error.Error() != S_OK) {
|
|
RTC_LOG(LS_ERROR) << "Failed to unmap the IDXGIOutputDuplication: "
|
|
<< desktop_capture::utils::ComErrorToString(error);
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
} // namespace webrtc
|