82 Commits

Author SHA1 Message Date
Danil Chapovalov
760c4b4da9 Trigger rtt and stats update on report block rather than receiver report.
ReportBlock is the the real receiver report.
Triggering rtt update on ReportBlock support clients that send receiver
report blocks attached to SenderReport rather than ReceiverReport.

Bug: webrtc:7996
Change-Id: Ie826fa09fd1bf0e5256e995649f66811b5192761
Reviewed-on: https://webrtc-review.googlesource.com/4040
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20014}
2017-09-28 10:29:59 +00:00
Niels Möller
c9d5b05ef4 Add lock annotations and const declarations to RtpReceiverImpl.
Bug: None
Change-Id: I061954ba7acfafac1171805c1b1f2a9328d534fa
Reviewed-on: https://webrtc-review.googlesource.com/3962
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19998}
2017-09-27 12:01:46 +00:00
Niels Möller
bbf389c7af Delete redundant logic for setting is_first_packet_in_frame
A value for this flag was derived in RtpReceiverImpl::IncomingRtpPacket.
For audio, it was never used, and for video, it was overridden by
the result from RtpDepacketizer::ParsedPayload.

Bug: webrtc:7135
Change-Id: I597a57ca77d13b9a9145a9ee5e6624c1986777b9
Reviewed-on: https://webrtc-review.googlesource.com/3660
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19985}
2017-09-27 06:45:15 +00:00
Karl Wiberg
73b60b82ee Remove the redundant method GetPayloadSpecifics
It's in the way of a refactoring.

Also change PayloadTypeToPayload---the method all callers can use instead---to return Optional<Payload> instead of const Payload* (for thread safety reasons: an object that protects itself with a mutex shouldn't be handing out pointers to parts of itself). 

BUG=webrtc:8159

Change-Id: I7ef0d545077ffdea016b309f2165e3c4955a2928
Reviewed-on: https://webrtc-review.googlesource.com/2360
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19917}
2017-09-21 20:19:55 +00:00
Karl Wiberg
92d9dd069d rtp_rtcp_format: Separate public and private source files
There was one .h file that didn't have to be public. :-)

BUG=webrtc:8159, webrtc:8255

Change-Id: I0998f0340384c57f52affdde30f6b4eb2eaa712b
Reviewed-on: https://webrtc-review.googlesource.com/2400
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19915}
2017-09-21 17:45:25 +00:00
nisse
a5f043f9cd Change ForwardErrorCorrection class to accept one received packet at a time.
BUG=None

Review-Url: https://codereview.webrtc.org/3012243002
Cr-Commit-Position: refs/heads/master@{#19893}
2017-09-18 14:58:59 +00:00
Danil Chapovalov
c5267d251a Simplify ReceiveStatistics: merge GetActiveStatisticians into RtcpReportBlocks
BUG=webrtc:8016

Change-Id: Ie38a86b730298039915baaac12b7fd97a5440345
Reviewed-on: https://webrtc-review.googlesource.com/1842
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19891}
2017-09-18 13:19:36 +00:00
nisse
435472542a Delete deprecated metod RtpRtcp::SetMaxTransferUnit.
Deprecated since cl https://codereview.webrtc.org/2589743002

BUG=webrtc:6847

Review-Url: https://codereview.webrtc.org/3006413002
Cr-Commit-Position: refs/heads/master@{#19878}
2017-09-18 07:37:37 +00:00
Danil Chapovalov
6c170578e6 Move rtcp packet classes from rtp_rtcp to rtp_rtcp_format target
Bug: None
Change-Id: I353228fd5b75bd4fceeaee1bb6fd07b01dac56a1
Reviewed-on: https://webrtc-review.googlesource.com/1480
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Elad Alon <eladalon@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19867}
2017-09-15 17:36:30 +00:00
Mirko Bonadei
7120742701 Adding NOLINT for typedefs.h and common_types.h
Now that we have moved WebRTC from src/webrtc to src/, common_types.h
and typedefs.h are triggering a cpplint error.

The cpplint complaint is:
Include the directory when naming .h files  [build/include] [4]

This CL disables the error but we have to remove these two headers
from the root directory.

NOPRESUBMIT=true

Bug: webrtc:5876
Change-Id: I08e1b69aadcc4b28ab83bf25e3819d135d41d333
Reviewed-on: https://webrtc-review.googlesource.com/1577
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@google.com>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19859}
2017-09-15 13:03:51 +00:00
Mirko Bonadei
92ea95e34a Fixing WebRTC after moving from src/webrtc to src/
In https://webrtc-review.googlesource.com/c/src/+/1560 we moved WebRTC
from src/webrtc to src/ (in order to preserve an healthy git history).
This CL takes care of fixing header guards, #include paths, etc...

NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=tommi@webrtc.org


Bug: chromium:611808
Change-Id: Iea91618212bee0af16aa3f05071eab8f93706578
Reviewed-on: https://webrtc-review.googlesource.com/1561
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19846}
2017-09-15 05:02:56 +00:00
Mirko Bonadei
bb547203bf Moving src/webrtc into src/.
In order to eliminate the WebRTC Subtree mirror in Chromium, 
WebRTC is moving the content of the src/webrtc directory up
to the src/ directory.

NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=tommi@webrtc.org

Bug: chromium:611808
Change-Id: Iac59c5b51b950f174119565bac87955a7994bc38
Reviewed-on: https://webrtc-review.googlesource.com/1560
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19845}
2017-09-15 04:25:06 +00:00
niklase@google.com
5adc73aad3 git-svn-id: http://webrtc.googlecode.com/svn/trunk@166 4adac7df-926f-26a2-2b94-8c16560cd09d 2011-07-07 08:46:41 +00:00
hlundin@google.com
f0a476bf76 Add PictureID and NonReference to codec information
The PictureID and NonReference information is now routed from the
encoder to the RTP packetizer through CodecSpecificInfo and 
RTPVideoHeaderVP8.
Review URL: http://webrtc-codereview.appspot.com/51003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@155 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-07 08:04:23 +00:00
holmer@google.com
98b4ed1ff8 Disabling DEBUG_FILE in the overuse detector by default.
Review URL: http://webrtc-codereview.appspot.com/63001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@149 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-05 14:47:23 +00:00
hlundin@google.com
6b04739e04 Route CodecSpecificInfo from encoder to packetizer
Making a long chain of interface changes to route a CodecSpecificInfo
struct from the video encoder function to the RTPSenderVideo. This
will be used to convey information needed by the RTP packetizer when
building the RTP headers.
Review URL: http://webrtc-codereview.appspot.com/56001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@140 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-01 08:32:57 +00:00
marpan@google.com
67d7282900 Allow the FEC to protect up to maximum #packets (48) if the
media packet list is above this max.
Review URL: http://webrtc-codereview.appspot.com/45005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@138 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-30 20:14:15 +00:00
marpan@google.com
1eccf7dfb3 Some code cleanup for rtp_sender_video.cc.
Review URL: http://webrtc-codereview.appspot.com/44003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@130 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-28 23:10:33 +00:00
leozwang@google.com
6cc3f000fc Include forward_error_correction_internal.cc which was added in #93 to android build
Review URL: http://webrtc-codereview.appspot.com/53001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@127 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-27 16:27:18 +00:00
hellner@google.com
3c45dfd178 Fixes valgrind warnings in the rtp_rtcp module.
Review URL: http://webrtc-codereview.appspot.com/47005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@122 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-23 16:24:03 +00:00
holmer@google.com
2f2971c6f3 Fixed a bug in the BitRateStats class and at the same time
rewrote it a bit.
Review URL: http://webrtc-codereview.appspot.com/41001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@103 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-20 14:07:42 +00:00
marpan@google.com
023abafa4e Modified the FEC to allow for option of unequal protection (UEP) across packets.
Added two files under testFec, removed old testFec.cpp, and added two
new files for generating packet masks: _internal.cc/h.
Review URL: http://webrtc-codereview.appspot.com/26003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@94 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-16 23:00:40 +00:00
marpan@google.com
ae0ad911a1 Modified the FEC to allow for option of unequal protection (UEP) across packets.
Added two files under testFec, removed old testFec.cpp, and added two
new files for generating packet masks: _internal.cc/h.
Review URL: http://webrtc-codereview.appspot.com/26003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@93 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-16 21:44:38 +00:00
niklase@google.com
ff72b0d8f3 Review URL: http://webrtc-codereview.appspot.com/40002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@89 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-15 23:43:03 +00:00
niklase@google.com
89714f2880 Review URL: http://webrtc-codereview.appspot.com/33009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@88 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-15 23:07:17 +00:00
hlundin@google.com
b7686af27c Remove warnings on Windows
Make member variable payload_size_ int instead of unsigned
to avoid warnings when comparing (> and >=).
Review URL: http://webrtc-codereview.appspot.com/40001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@86 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-15 11:35:59 +00:00
hlundin@google.com
7c53a0c67e Make r80 build on Windows
Re-submitting revision r80, but with bugfix to make it
build on Windows.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@85 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-15 09:38:28 +00:00
henrika@google.com
f561f488fc Temporary rollback to be able to build on Windows. Will be fixed soon.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@82 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-15 08:37:18 +00:00
hlundin@google.com
0c32a8d65e VP8 RTP packetizer rewrite
Rewriting the RTP packetizer for VP8 to accommodate more functionality.
This CL does not change the formatting other than that the kStrict
mode now produces equal-sized fragments.
Review URL: http://webrtc-codereview.appspot.com/33006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@80 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-15 07:43:28 +00:00
leozwang@google.com
0b0c28c495 add android makefile, some modification in vpx makefile to build encoder from c source for now
Review URL: http://webrtc-codereview.appspot.com/29012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@50 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-07 17:24:39 +00:00
hlundin@google.com
d2c7bff3a1 Implement VP8 packetizer and unit tests
Implemented a new VP8 packetizer with three modes. The packetizer
class needs access to the fragmentation information, which is
now created in the codec wrapper and passed through the callback
chain to the RTPSenderVideo::SendVP8().

A unit test for the VP8 packetizer was also implemented. It tests the
three different modes. The tests could definitely be more elaborate.
Review URL: http://webrtc-codereview.appspot.com/34003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@48 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-06-07 12:23:14 +00:00
niklase@google.com
77ae29bc81 git-svn-id: http://webrtc.googlecode.com/svn/trunk@4 4adac7df-926f-26a2-2b94-8c16560cd09d 2011-05-30 11:22:19 +00:00