admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
12,860 Commits 1 Branch 0 Tags
Commit Graph

559 Commits

Author SHA1 Message Date
deadbeef
d356843706 Disable EndToEndTest.GetStats on Dr. Memory Full. 
BUG=webrtc:6146
TBR=kjellander@webrtc.org
NOTRY=True

Review-Url: https://codereview.webrtc.org/2182333004
Cr-Commit-Position: refs/heads/master@{#13545}
 2016-07-27 18:09:37 +00:00
mflodman
d4e6cbdbbe Remove suppression for non-existing test. 
R=pbos@webrtc.org

Review URL: https://codereview.webrtc.org/2177473002 .

Cr-Commit-Position: refs/heads/master@{#13509}
 2016-07-22 13:36:00 +00:00
Johan Ahlers
9ddac18d1c Add minimal LLVM sanity coverage (sancov) reporting for unittests. 
This CL enables generating *.sancov data. Blacklist for sancov tool is
provided, too. Sancov tool for report generation needs to be build from
llvm compiler-rt sources (llvm 3.9.0 or newer).

See http://clang.llvm.org/docs/SanitizerCoverage.html .

BUG=webrtc:6136
R=phoglund@webrtc.org
TBR=kjellander@webrtc.org

Review URL: https://codereview.webrtc.org/2144273002 .

Cr-Commit-Position: refs/heads/master@{#13506}
 2016-07-22 06:57:38 +00:00
stefan
a540ada1e1 Remove stefan@webrtc.org from libvpx roll notification. 
TBR=kjellander@webrtc.org
NOTRY=true

Review-Url: https://codereview.webrtc.org/2159873003
Cr-Commit-Position: refs/heads/master@{#13498}
 2016-07-18 18:15:59 +00:00
minyue
fd634c43e9 Reland of Re-enable UBsan on AGC. 
patchset #8 id:300001 of https://codereview.webrtc.org/2003623003/

This reverts commit 4867ca2689d6576a750180b8f8e6bd9a9e23056f.

BUG=webrtc:5530
TBR=peah@webrtc.org, kjellander@webrtc.org

Review-Url: https://codereview.webrtc.org/2072033004
Cr-Commit-Position: refs/heads/master@{#13188}
 2016-06-17 11:36:15 +00:00
pbos
4867ca2689 Revert of -enable UBsan on AGC. (patchset #1 id:1 of https://codereview.webrtc.org/2063643003/ ) 
Reason for revert:
Breaks downstream code import.

Original issue's description:
> Reland of Re-enable UBsan on AGC.
>
> patchset #8 id:300001 of https://codereview.webrtc.org/2003623003/
>
> This reverts commit 2b9423f7a18145255deb93f2505a4fd1c3fa9ad7.
>
> BUG=webrtc:5530
> TBR=peah@webrtc.org, kjellander@webrtc.org
>
> Committed: https://crrev.com/b1963b403f8e9258c35a02d2622da254cbb90c51
> Cr-Commit-Position: refs/heads/master@{#13132}

TBR=henrik.lundin@webrtc.org,minyue@webrtc.org
BUG=webrtc:5530
NOTRY=true

Review-Url: https://codereview.webrtc.org/2078433003
Cr-Commit-Position: refs/heads/master@{#13169}
 2016-06-16 14:59:13 +00:00
deadbeef
14461d42bc Fixing flaky test: WebRtcSessionTest.TestPacketOptionsAndOnPacketSent 
The test sent a media packet, then verified it was sent by checking the
"last packet sent"'s ID. But the last packet sent may have been
a STUN packet that came *after* the media packet.

BUG=webrtc:5978

Review-Url: https://codereview.webrtc.org/2071573002
Cr-Commit-Position: refs/heads/master@{#13156}
 2016-06-15 18:07:05 +00:00
minyue
b1963b403f Reland of Re-enable UBsan on AGC. 
patchset #8 id:300001 of https://codereview.webrtc.org/2003623003/

This reverts commit 2b9423f7a18145255deb93f2505a4fd1c3fa9ad7.

BUG=webrtc:5530
TBR=peah@webrtc.org, kjellander@webrtc.org

Review-Url: https://codereview.webrtc.org/2063643003
Cr-Commit-Position: refs/heads/master@{#13132}
 2016-06-14 14:18:17 +00:00
Åsa Persson
2b9423f7a1 Revert of Re-enable UBsan on AGC. (patchset #8 id:300001 of https://codereview.webrtc.org/2003623003/ ) 
Reason for revert:
Breaks bot.

Original issue's description:
> Re-enable UBsan on AGC.
>
> BUG=webrtc:5530
>
> Committed: https://crrev.com/293c86d67384c15f46b8296096a62a14b4a58d33
> Cr-Commit-Position: refs/heads/master@{#13034}

R=kjellander@webrtc.org, peah@webrtc.org
TBR=kjellander@webrtc.org, minyue@webrtc.org, peah@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:5530

Review URL: https://codereview.webrtc.org/2056683002 .

Cr-Commit-Position: refs/heads/master@{#13096}
 2016-06-10 07:12:43 +00:00
asapersson
2c1bec3fcc Add suppressions for memcheck errors. 
BUG=webrtc:5986,webrtc:5987,webrtc:5988, webrtc:5989
NOTRY=True

Review-Url: https://codereview.webrtc.org/2056713002
Cr-Commit-Position: refs/heads/master@{#13091}
 2016-06-09 15:08:15 +00:00
asapersson
da75f7cc2c Disable flaky test (WebRtcSessionTest.TestPacketOptionsAndOnPacketSent) on Dr Memory. 
BUG=webrtc:5978
NOTRY=True

Review-Url: https://codereview.webrtc.org/2051033002
Cr-Commit-Position: refs/heads/master@{#13086}
 2016-06-09 09:07:27 +00:00
asapersson
1503df6aef Add suppressions for memcheck errors. 
BUG=webrtc:5983,webrtc:5984
NOTRY=True

Review-Url: https://codereview.webrtc.org/2054683002
Cr-Commit-Position: refs/heads/master@{#13084}
 2016-06-09 07:46:38 +00:00
Åsa Persson
e1cac64842 Disable all BasicPortAllocatorTests on Dr Memory (flaky). 
BUG=webrtc:5929
NOTRY=True
R=kjellander@webrtc.org

Review URL: https://codereview.webrtc.org/2049523006 .

Cr-Commit-Position: refs/heads/master@{#13082}
 2016-06-09 07:15:23 +00:00
Åsa Persson
b6439396bf Disable flaky TurnPortTests on Memcheck. 
BUG=webrtc:5981
NOTRY=True
R=kjellander@webrtc.org

Review URL: https://codereview.webrtc.org/2045203003 .

Cr-Commit-Position: refs/heads/master@{#13071}
 2016-06-08 14:57:41 +00:00
minyue
293c86d673 Re-enable UBsan on AGC. 
BUG=webrtc:5530

Review-Url: https://codereview.webrtc.org/2003623003
Cr-Commit-Position: refs/heads/master@{#13034}
 2016-06-03 13:07:41 +00:00
kjellander@webrtc.org
2a3a93783e DrMemory: Exclude PingTaskTest tests. 
BUG=webrtc:5943
TBR=deadbeef@chromium.org

Review URL: https://codereview.webrtc.org/2024563002 .

Cr-Commit-Position: refs/heads/master@{#12955}
 2016-05-30 03:35:23 +00:00
deadbeef
2ce871548f Excluding some PhysicalSocketTest tests on memcheck. 
NOTRY=True

Review-Url: https://codereview.webrtc.org/2017453002
Cr-Commit-Position: refs/heads/master@{#12914}
 2016-05-26 11:03:50 +00:00
kjellander
2e15593803 Add memcheck suppression hitting only our linux_memcheck trybot. 
It seems the GCE VMs that are used for our trybots have slightly
different OS/libc versions than the Chrome infra Golo VMs, causing
it to fail with the current suppressions. This should make it go green.

See https://build.chromium.org/p/tryserver.webrtc/builders/linux_memcheck/builds/4374
for an example.

NOTRY=True
TBR=deadbeef@webrtc.org

Review-Url: https://codereview.webrtc.org/2016613003
Cr-Commit-Position: refs/heads/master@{#12912}
 2016-05-26 10:57:58 +00:00
philipel
be7a9e5f8a Revert "Revert of FrameBuffer for the new jitter buffer. (patchset #9 id:160001 of https://codereview.webrtc.org/1969403007/ )" 
Also disabled modules_unittest.TestFrameBuffer2.* in drmemory.

This reverts commit b711f10d9683b9de6ee78186f77b225fc7ebfb8f.

TBR=honghaiz@webrtc.org

BUG=

Review URL: https://codereview.webrtc.org/1991133003 .

Cr-Commit-Position: refs/heads/master@{#12806}
 2016-05-19 10:19:44 +00:00
Peter Boström
353ca7610b Disable SendsAndReceivesH264 on Memcheck. 
Test runs too slowly to complete.

BUG=webrtc:5893
R=tommi@webrtc.org

Review URL: https://codereview.webrtc.org/1977223002 .

Cr-Commit-Position: refs/heads/master@{#12748}
 2016-05-14 13:53:32 +00:00
Henrik Kjellander
27178676cf UBSan: Suppress openh264 and NetEq errors. 
As part of the work enabling OpenH264 in
WebRTC it was discovered that some of its code triggers
an UBSan errors:
third_party/openh264/src/codec/common/inc/golomb_common.h:103:3: runtime error: shift exponent 32 is too large for 32-bit type 'uint32_t' (aka 'unsigned int')
third_party/ffmpeg/libavcodec/h264_cavlc.c:585:54: runtime error: index -1 out of bounds for type 'VLC [15]'
Suppress such errors since this source code is out of our control.

This CL also includes a new NetEq suppression.

BUG=webrtc:5889
TBR=hbos@webrtc.org

Review URL: https://codereview.webrtc.org/1975863002 .

Cr-Commit-Position: refs/heads/master@{#12706}
 2016-05-12 16:24:40 +00:00
terelius
7b94c69213 Remove DropOldEvents from list of excluded tests. As of last week, the test no longer exists. (https://codereview.webrtc.org/1687703002/) 
BUG=webrtc:5312

Review-Url: https://codereview.webrtc.org/1917723003
Cr-Commit-Position: refs/heads/master@{#12584}
 2016-05-02 00:57:32 +00:00
Peter Boström
cd5c25cb80 Use vcm::VideoSender in ViEEncoder. 
ViEEncoder doesn't need a full VideoCodingModule since it only uses the
sender side either way.

BUG=webrtc:3608,webrtc:5687
R=perkj@webrtc.org

Review URL: https://codereview.webrtc.org/1904983002 .

Cr-Commit-Position: refs/heads/master@{#12456}
 2016-04-21 14:48:18 +00:00
kjellander
052af4cea2 autoroller: Use 10 characters for shortened Git hashes. 
Recently, the shortened hash
https://chromium.googlesource.com/chromium/src/+/355fabf
was not suffucient for the Chromium repo. Adding three more
should reduce the chance of this happening by 16^3.

NOTRY=True

Review URL: https://codereview.webrtc.org/1841563004

Cr-Commit-Position: refs/heads/master@{#12156}
 2016-03-30 09:30:59 +00:00
stefan
0e2e5d994f Revert of Revert opus memcheck suppression (patchset #1 id:1 of https://codereview.webrtc.org/1801233002/ ) 
Reason for revert:
Reverting since the memcheck bot still fails.

Original issue's description:
> Revert opus memcheck suppression
>
> BUG=https://bugs.chromium.org/p/webrtc/issues/detail?id=5651
>
> Committed: https://crrev.com/f62d107aa7ad6fcf2bacec3c6eb4a16469ed2287
> Cr-Commit-Position: refs/heads/master@{#12012}

TBR=flim@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=https://bugs.chromium.org/p/webrtc/issues/detail?id=5651

Review URL: https://codereview.webrtc.org/1807673004

Cr-Commit-Position: refs/heads/master@{#12017}
 2016-03-16 14:43:35 +00:00
flim
f62d107aa7 Revert opus memcheck suppression 
BUG=https://bugs.chromium.org/p/webrtc/issues/detail?id=5651

Review URL: https://codereview.webrtc.org/1801233002

Cr-Commit-Position: refs/heads/master@{#12012}
 2016-03-16 09:33:28 +00:00
Stefan Holmer
d67717f9ad Make opus memcheck suppression more generic 
TBR=kjellander@webrtc.org

BUG=webrtc:5651

Review URL: https://codereview.webrtc.org/1799093002 .

Cr-Commit-Position: refs/heads/master@{#11979}
 2016-03-14 15:00:12 +00:00
Stefan Holmer
479a04cbb7 Suppress invalid read in Opus. 
TBR=kjellander@webrtc.org
BUG=webrtc:5651

Review URL: https://codereview.webrtc.org/1803533002 .

Cr-Commit-Position: refs/heads/master@{#11975}
 2016-03-14 09:23:08 +00:00
kjellander@webrtc.org
2875077458 Roll chromium_revision db8316d..6a56b54 (380688:380836): MSVS 2015 switch 
This CL switches over to using Microsoft Visual Studio 2015 by default
on Windows. This large effort is described in more detail in
https://crbug.com/440500.

Change log: db8316d..6a56b54
Full diff: db8316d..6a56b54

No dependencies changed.
No update to Clang.

TBR=tommi@webrtc.org

Review URL: https://codereview.webrtc.org/1792633002 .

Cr-Commit-Position: refs/heads/master@{#11974}
 2016-03-14 05:49:17 +00:00
Henrik Kjellander
e496badf3c autoroller: Remove sending tryjobs (done via CQ). 
Skip running 'git cl try' since tryjobs are sent when
the CL is sent to the CQ anyway.

BUG=
R=pbos@webrtc.org

Review URL: https://codereview.webrtc.org/1746993003 .

Cr-Commit-Position: refs/heads/master@{#11827}
 2016-03-01 10:30:36 +00:00
kwiberg
806706875d iSAC entropy coder: Avoid signed integer overflow 
By doing an unsigned instead of a signed addition, we get the exact
same machine code (in non-UBSan builds), but no longer trigger
undefined behavior since unsigned overflow is defined behavior.

BUG=webrtc:5485

Review URL: https://codereview.webrtc.org/1734883003

Cr-Commit-Position: refs/heads/master@{#11776}
 2016-02-26 10:52:14 +00:00
peah
1cfe94096c Added the agc digital_agc.c file to the ubsan blacklist 
in order to suppress UBSan errors from the AGC.

BUG=webrtc:5124, webrtc:5487

Review URL: https://codereview.webrtc.org/1696153002

Cr-Commit-Position: refs/heads/master@{#11730}
 2016-02-24 07:06:56 +00:00
henrik.lundin
452df1cb44 Suppress UBSan errors in common_audio 
BUG=webrtc:5486,webrtc:5512
NOTRY=true

Review URL: https://codereview.webrtc.org/1714443002

Cr-Commit-Position: refs/heads/master@{#11671}
 2016-02-18 15:41:21 +00:00
kjellander@webrtc.org
8110482297 Rename gtest_exclude for rtc_pc_unittests 
This was forgotten in https://codereview.webrtc.org/1694813002/
Also clean up no-longer-used files for libjignle_unittest (renamed
to rtc_unittests a long time ago).

BUG=webrtc:5419
TBR=pbos@webrtc.org

Review URL: https://codereview.webrtc.org/1698123002 .

Cr-Commit-Position: refs/heads/master@{#11625}
 2016-02-15 12:00:58 +00:00
Peter Boström
56e6269e11 Rename gtest_exclude for rtc_media_unittests. 
Previous suppressions for libjingle_media_unittest stopped working when
the target was renamed rtc_media_unittests causing the bots to start
flaking.

BUG=
TBR=kjellander@webrtc.org

Review URL: https://codereview.webrtc.org/1698873002 .

Cr-Commit-Position: refs/heads/master@{#11624}
 2016-02-15 10:59:21 +00:00
Peter Boström
88c52a7e7b Disable VerifyHistogramStatsWithRed on DrMemory. 
Flaky due to using a real VP8 encoder.

BUG=webrtc:5264
TBR=deadbeef@webrtc.org, stefan@webrtc.org

Review URL: https://codereview.webrtc.org/1695103003 .

Cr-Commit-Position: refs/heads/master@{#11623}
 2016-02-15 10:31:48 +00:00
Peter Boström
395939781b Reland of Don't send FEC for H.264 with NACK enabled. (patchset #1 id:1 of https://codereview.webrtc.org/1692783005/ ) 
Reason for revert:
Disabling tests on memcheck that time out due to using real VP8 encoders.

Original issue's description:
> Revert of Don't send FEC for H.264 with NACK enabled. (patchset #5 id:80001 of https://codereview.webrtc.org/1687303002/ )
>
> Reason for revert:
> Broke the VerifyHistogramStatsWithRed test on the Windows DrMemory Full bot and Linux Memcheck bot. Please fix the test and reland.
>
> Original issue's description:
> > Don't send FEC for H.264 with NACK enabled.
> >
> > The H.264 does not contain picture IDs and are not sufficient to
> > determine that a packet may be skipped. This causes retransmission
> > requests for FEC that are currently dropped by the sender (since they
> > should be redundant).
> >
> > The receiver is then unable to continue without having the packet gap
> > filled (unlike VP8/VP9 which moves on since it has a consecutive stream
> > of picture IDs).
> >
> > Even if FEC retransmission did work it's a huge waste of bandwidth,
> > since it just adds additional overhead that has to be unconditionally
> > transmitted. This bandwidth is better used to send higher-quality
> > frames.
> >
> > BUG=webrtc:5264
> > R=stefan@webrtc.org
> >
> > Committed: https://crrev.com/25558ad819b4df41ba51537e26a77480ace1e525
> > Cr-Commit-Position: refs/heads/master@{#11601}
>
> TBR=stefan@webrtc.org,pbos@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:5264
>
> Committed: https://crrev.com/29ffdc1a15e31bd81e806ff135c2100d811714f0
> Cr-Commit-Position: refs/heads/master@{#11607}

TBR=stefan@webrtc.org,deadbeef@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:5264

Review URL: https://codereview.webrtc.org/1697093002 .

Cr-Commit-Position: refs/heads/master@{#11621}
 2016-02-15 10:27:22 +00:00
henrik.lundin
abedbbd09a Suppress UBSan errors from iSAC 
BUG=webrtc:5513
NOTRY=true

Review URL: https://codereview.webrtc.org/1690573002

Cr-Commit-Position: refs/heads/master@{#11549}
 2016-02-10 13:01:44 +00:00
danilchap
5c35cf9f8e Re-enable RestartingSendStreamPreservesRtpState. 
based on https://codereview.webrtc.org/1457283002/
Packets allowed now to come out of order.

BUG=webrtc:3552
R=pbos@webrtc.org

Review URL: https://codereview.webrtc.org/1661923002

Cr-Commit-Position: refs/heads/master@{#11477}
 2016-02-03 22:14:57 +00:00
tnakamura
cc71c4107f Revert "Disable P2PTransport...TestFailoverControlledSide on Memcheck" 
This reverts commit 1a8240c32a14a31b1417b6e06f511f2a16d81b19.

Per comments in bug 5136, the affected test should no longer be flaky.

BUG=webrtc:5136

Review URL: https://codereview.webrtc.org/1616273004

Cr-Commit-Position: refs/heads/master@{#11360}
 2016-01-22 20:45:07 +00:00
kjellander
becf9ee48c Roll chromium_revision 6a04368..1728ddf (370362:370595) 
Our valgrind script needed to be updated due to
6a04368..1728ddf/tools/valgrind/chrome_tests.py

Change log: 6a04368..1728ddf
Full diff: 6a04368..1728ddf

Changed dependencies:
* src/third_party/ffmpeg: 7deada1..2dc5618
* src/third_party/libsrtp: ebfcc9a..9cc4f2f
* src/third_party/libvpx_new/source/libvpx: b520882..c0307e6
* src/tools/gyp: 54b7dfc..aa0301b
DEPS diff: 6a04368..1728ddf/DEPS

No update to Clang.

TBR=marpan@webrtc.org, stefan@webrtc.org,
NOTRY=True

Review URL: https://codereview.webrtc.org/1610253003

Cr-Commit-Position: refs/heads/master@{#11330}
 2016-01-21 09:46:00 +00:00
kjellander
436ff3129e Update exclude files for renamed test 
The test binary libjingle_peerconnection_unittest was
renamed to peerconnection_unittests in
https://codereview.webrtc.org/1602443004/ but these
files were not renamed.

TBR=perkj@webrtc.org
NOTRY=True

Review URL: https://codereview.webrtc.org/1599413007

Cr-Commit-Position: refs/heads/master@{#11314}
 2016-01-20 08:19:23 +00:00
kjellander
3860c7f873 Fix parsing of CLANG_REVISON from tools/clang/scripts/update.py 
The regex didn't match the revision before after the switch
from tools/clang/scripts/update.sh to
tools/clang/scripts/update.py.
This should have been done in https://codereview.webrtc.org/1493683003
when the filename changed.

TESTED=Ran the script and verified parsing worked and showed
the currently pending Clang change in ongoing roll in
https://codereview.webrtc.org/1593713013/
NOTRY=True

Review URL: https://codereview.webrtc.org/1608813002

Cr-Commit-Position: refs/heads/master@{#11299}
 2016-01-19 10:04:49 +00:00
marpan
8432e1f4b8 Re-enable tests that failed under Linux_Msan. 
Fixed in latest libvpx roll.
Keep EndToEndTest.TransportSeqNumOnAudioAndVideo disabled on
Win_DrMemory for now as it seems to time-out/too slow.

TBR=stefan@webrtc.org, kjellander@webrtc.org
BUG=webrtc:5402
NOTRY=True

Review URL: https://codereview.webrtc.org/1577313003

Cr-Commit-Position: refs/heads/master@{#11240}
 2016-01-13 16:35:51 +00:00
Peter Boström
6183de6da0 Remove tools/refactoring. 
No longer used, references old GIPS types variable names and confuses
team members which think this code could be used/still useful.

BUG=
R=phoglund@webrtc.org

Review URL: https://codereview.webrtc.org/1581573003 .

Cr-Commit-Position: refs/heads/master@{#11219}
 2016-01-12 12:41:11 +00:00
kjellander
3c05e6c9c3 Disable EndToEndTest.TransportSeqNumOnAudioAndVideo for Dr Memory. 
It started failing at the roll in
https://codereview.webrtc.org/1556273002

BUG=webrtc:5402
TBR=marpan@webrtc.org
NOTRY=True

Review URL: https://codereview.webrtc.org/1574813002

Cr-Commit-Position: refs/heads/master@{#11198}
 2016-01-10 05:46:42 +00:00
Guo-wei Shieh
684e995464 Disable 2 video tests which fail on DrMemoryFull 
TBR=kjellander@webrtc.org
BUG=5417

Review URL: https://codereview.webrtc.org/1575433003 .

Cr-Commit-Position: refs/heads/master@{#11193}
 2016-01-09 03:03:50 +00:00
deadbeef
523702136f Disabling CritSectTest on Windows DrMemory bot. 
BUG=webrtc:5390

Review URL: https://codereview.webrtc.org/1554673002

Cr-Commit-Position: refs/heads/master@{#11148}
 2016-01-04 19:50:50 +00:00
Henrik Kjellander
4138e08eb6 Convert DOS->Unix line endings for Dr memory exclude file. 
NOTRY=True
NOPRESUBMIT=True
TBR=deadbeef@webrtc.org

Review URL: https://codereview.webrtc.org/1555043003 .

Cr-Commit-Position: refs/heads/master@{#11146}
 2016-01-04 12:02:05 +00:00
Stefan Holmer
498ae00f39 Disable ThreadTest.ThreeThreadsInvoke on DrMemory bots. 
BUG=webrtc:5199

TBR=pbos@webrtc.org

Review URL: https://codereview.webrtc.org/1524073002 .

Cr-Commit-Position: refs/heads/master@{#11020}
 2015-12-15 08:46:18 +00:00