andresp@webrtc.org
f6acf98a46
Fix the android clang bot for compiling with thread annotations.
...
TBR=niklas.enbom@webrtc.org
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6279005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5330 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-20 21:54:26 +00:00
andresp@webrtc.org
7fb75ecbd4
Add thread_annotations for clang targets.
...
TESTED: As expected clang bots catched a few issues which are fixed with this CL, other bots ignore the annotations and compile fine.
R=niklas.enbom@webrtc.org , phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6209004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5328 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-20 20:20:50 +00:00
sprang@webrtc.org
54ae4ffb9e
Add callbacks for receive channel RTCP statistics.
...
This allows a listener to receive new statistics as it is generated - avoiding the need to poll. This also makes handling stats from multiple RTP streams more tractable.
The change is primarily targeted at the new video engine API.
TEST=Unit test in ReceiveStatisticsTest. Integration tests to follow as call tests when fully wired up.
BUG=2235
R=henrika@webrtc.org , pbos@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5089004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5323 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-19 13:26:02 +00:00
andresp@webrtc.org
e682aa5077
Refactoring MediaOptimization so it can easily be turned into a thread-safe class.
...
BUG=2732
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6149004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5322 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-19 10:59:48 +00:00
sergeyu@chromium.org
8ae72560dd
Make MouseCursor mutable
...
MouseCursor objects were previous immutable which makes it harder to
implement deserializers when MouseCursor is sent over IPC in Chromium.
R=dcaiafa@chromium.org
Committed: https://code.google.com/p/webrtc/source/detail?r=5310
Review URL: https://webrtc-codereview.appspot.com/6059005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5314 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-18 02:18:01 +00:00
fischman@webrtc.org
f8be8df33a
audio_processing_unittest: unbreak clang compilation.
...
BUG=2735
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6069004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5313 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-17 23:46:39 +00:00
fischman@webrtc.org
179908c81c
JNI Audio: remove dead members.
...
BUG=2735
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6049004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5312 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-17 23:46:14 +00:00
sergeyu@chromium.org
e4c927208b
Revert "Make MouseCursor mutable"
...
This reverts commit a6db8ab8bc4b569a26633b0ca3665297f1a5349b.
TBR=dcaiafa@chromium.org
Review URL: https://webrtc-codereview.appspot.com/6079004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5311 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-17 22:48:50 +00:00
sergeyu@chromium.org
8fd1d26536
Make MouseCursor mutable
...
MouseCursor objects were previous immutable which makes it harder to
implement deserializers when MouseCursor is sent over IPC in Chromium.
R=dcaiafa@chromium.org
Review URL: https://webrtc-codereview.appspot.com/6059005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5310 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-17 22:19:12 +00:00
mflodman@webrtc.org
e6b871bb29
Added method for getting default module state and protect agains a
...
read/write race for child_modules_.
BUG=2731
TEST=tsan
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5919005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5306 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-17 08:30:40 +00:00
pbos@webrtc.org
eb7b7bce3d
Modify video_render/ to allow a single old frame.
...
This stabilizes tests as a single frame reaches end-to-end, as well as
allowing slow or heavily-loaded systems to see any video updates even if
the frame takes more than 500ms in the pipeline.
R=mflodman@webrtc.org , stefan@webrtc.org
BUG=2724
Review URL: https://webrtc-codereview.appspot.com/5949004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5303 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-16 18:24:37 +00:00
asapersson@webrtc.org
e7b1e11283
Revert 5285 "Revert 5228 "Use the RTT from RtcpRttStats class if..."
...
> Revert 5228 "Use the RTT from RtcpRttStats class if provided whe..."
>
> > Use the RTT from RtcpRttStats class if provided when sending/receiving NACK.
> >
> > R=holmer@google.com
> >
> > Review URL: https://webrtc-codereview.appspot.com/5049004
>
> TBR=asapersson@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/5799004
TBR=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5989004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5299 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-16 14:40:36 +00:00
bjornv@webrtc.org
1e7d61270c
Simplification of histogram normalization in delay estimator.
...
- Replaces a for loop with a single element update to save complexity. No regression in performance seen on set of recordings.
- Removes UpdatesMadeUponChange() and put code straight into ProcessBinarySpectrum().
BUG=None
TESTED=module_unittest, trybots, verified manually on set of recordings.
R=aluebs@webrtc.org , andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5929004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5298 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-16 13:37:28 +00:00
pbos@webrtc.org
5ab756703e
Revert r5294 to re-roll r5293.
...
To fix races in test each stream now owns its own encoder/decoder.
R=mflodman@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/5919004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5297 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-16 12:24:44 +00:00
bjornv@webrtc.org
5c64508b03
Adds robust validation functionality to the delay estimator
...
Evaluated over a 51 recordings:
False positives went from 4.4% to 0.7%
Missed detections unchanged at 0.8%
No increase in complexity, but need to re-evaluate that.
TESTED=trybots, unittests, verified against Matlab implementation
BUG=None
R=aluebs@webrtc.org , andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5419004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5296 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-16 10:57:53 +00:00
sprang@webrtc.org
87ad57bc75
Incorrect iterator++ in ModuleRtpRtcpImpl::RegisterVideoBitrateObserver
...
The iterator is incremented both in loop header and loop body. Should
only be incremented in header.
BUG=2727
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5899004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5295 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-16 07:43:51 +00:00
turaj@webrtc.org
41e2615e02
Revert 5293 "Auto instantiate RBE depending on whether AST or TO..."
...
> Auto instantiate RBE depending on whether AST or TOF is available in incoming packet stream.
>
> BUG=
> R=mflodman@webrtc.org , stefan@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/5409004
TBR=solenberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5889004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5294 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-15 18:42:32 +00:00
solenberg@webrtc.org
341e91441a
Auto instantiate RBE depending on whether AST or TOF is available in incoming packet stream.
...
BUG=
R=mflodman@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5409004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5293 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-13 23:57:54 +00:00
stefan@webrtc.org
dd393e7b9d
Measure pacer queue size based on when packets are inserted rather than captured.
...
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5659004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5291 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-13 22:03:27 +00:00
wu@webrtc.org
24301a67c6
Update talk to 58174641 together with http://review.webrtc.org/4319005/ .
...
R=turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5809004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5287 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-13 19:17:43 +00:00
asapersson@webrtc.org
86bb56a7f5
Revert 5228 "Use the RTT from RtcpRttStats class if provided whe..."
...
> Use the RTT from RtcpRttStats class if provided when sending/receiving NACK.
>
> R=holmer@google.com
>
> Review URL: https://webrtc-codereview.appspot.com/5049004
TBR=asapersson@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5799004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5285 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-13 16:16:45 +00:00
sprang@webrtc.org
6811b6e308
Callback for send bitrate estimates - new roll
...
Issue https://webrtc-codereview.appspot.com/4459004/ was commited as
r5259, after which flakiness was detected and a rollback was performed
at r5261.
Patch Set 1 of this issue is the code submitted in r5259. Subsequent
patch sets fixes a race condition which caused the seen problems.
The root cause was a dead lock between a thread sending rtp packets and
and a timed module processing thread:
webrtc::RTPSender::BitrateUpdated() // Get RTPSender stats lock
webrtc::Bitrate::Process() // Get Bitrate lock
webrtc::RTPSender::ProcessBitrate()
webrtc::ModuleRtpRtcpImpl::Process()
...
webrtc::Bitrate::Update() // Get Bitrate lock
webrtc::RTPSender::UpdateRtpStats() // Get RTPSender stats lock
webrtc::RTPSender::SendToNetwork()
...
This is fixed in Bitrate::Process() by releasing the lock before
calling the callback.
BUG=2235
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5619004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5281 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-13 09:46:59 +00:00
henrik.lundin@webrtc.org
e9abd591d7
Making RemoteRateControl::min_configured_bit_rate_ configurable
...
The minimum bitrate can now be configured from WrappingBitrateEstimator.
BUG=2698
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5699004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5279 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-13 08:42:42 +00:00
turaj@webrtc.org
a92baead39
ACM 2 compatibility with ACM 1.
...
Removing an unregisterd codec from ACM 1 does not result in an error, so should be for ACM 2. Also ACM 1 has post-decode VAD on and AMC 2 needs to have it on by default.
BUG=
Test=trybits
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5549005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5276 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-13 00:10:44 +00:00
henrike@webrtc.org
9ee75e9c77
Enables mixing and matching Java and native audio. It is used for getting best of both worlds capabilities (AEC and low latency).
...
BUG=N/A
R=fischman@webrtc.org , niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4189004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5270 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-11 21:42:44 +00:00
pbos@webrtc.org
724947b8ef
Add SwapFrame() to VideoSendStreamInput.
...
Optionally prevents doing a frame copy when putting frames into a
VideoSendStream. PutFrame() is still there, which copies the frame.
Also removes time_since_capture_ms as a parameter, since
I420VideoFrame::render_time_ms() denotes when the frame was captured.
BUG=2657
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5119004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5265 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-11 16:26:16 +00:00
sprang@webrtc.org
096e8d9f94
Revert 5259 "Callback for send bitrate estimates"
...
CL is causing flakiness in RampUpTest.WithoutPacing.
> Callback for send bitrate estimates
>
> BUG=2235
> R=mflodman@webrtc.org , pbos@webrtc.org , stefan@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/4459004
R=mflodman@webrtc.org , pbos@webrtc.org
TBR=mflodman
Review URL: https://webrtc-codereview.appspot.com/5579005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5261 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-11 14:07:33 +00:00
kjellander@webrtc.org
f9bdbe3619
Roll chromium_revision 232627:238260
...
This brings us the updated swarming_client
that has moved out from Chromium into a standalone
project.
Because of this, all .isolate files needed to be
updated as well, similar to the changes in
https://codereview.chromium.org/29993003
TEST=trybots passing
BUG=none
R=andrew@webrtc.org , perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4859004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5260 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-11 13:37:12 +00:00
sprang@webrtc.org
2656cf9f4c
Callback for send bitrate estimates
...
BUG=2235
R=mflodman@webrtc.org , pbos@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4459004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5259 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-11 12:53:03 +00:00
fischman@webrtc.org
7ae8495779
Removed unnecessary Pulse init from VoE startup.
...
Saves 10% (~260ms) of the total PeerConnectionTest wallclock time.
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5479004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5254 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-10 21:01:34 +00:00
kjellander@webrtc.org
917306d3fd
Change uses of the obsolete armv7 setting to arm_version==7.
...
BUG=http://crbug.com/234135
R=andrew@webrtc.org , fischman@webrtc.org , kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5369004
Patch from Mostyn Bramley-Moore <mostynb@opera.com>.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5250 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-10 09:26:07 +00:00
fischman@webrtc.org
eb7def234e
Fix compilation errors on Fedora 20.
...
peerconnection_jni.cc: syscall() comes from <unistd.h>
RTPtimeshift.cc: char* being compared to 0 instead of the atoi() of it
rtp_payload_registry_unittest.cc: avoid narrowing int to uint32.
BUG=2700
R=andrew@webrtc.org , fischman@webrtc.org , henrik.lundin@webrtc.org , henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5019004
Patch from Victor Costan <costan@gmail.com>.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5248 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-09 21:34:30 +00:00
andrew@webrtc.org
de7c9e8884
Ensure WEBRTC_MODULE_UTILITY_VIDEO is undefined for enable_video==0.
...
Move the logic to common.gypi to reduce the chance of the define being
unprotected in the future.
BUG=b/12018143
TESTED=git try, and local Linux build with -Denable_video=0
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5309004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5244 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-09 16:23:00 +00:00
sergeyu@chromium.org
5e13ac967b
Add shape in DesktopFrame.
...
The shape will be used for Me2App mode in chromoting.
R=wez@chromium.org
Review URL: https://webrtc-codereview.appspot.com/4369005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5243 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-07 01:03:28 +00:00
andrew@webrtc.org
8d0ca7f5d2
Add new method to MockAudioProcessing.
...
TBR=henrikg
Review URL: https://webrtc-codereview.appspot.com/5279004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5241 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-06 17:52:27 +00:00
henrikg@webrtc.org
863b536100
Allow opening an AEC dump from an existing file handle.
...
This is necessary for Chromium to be able enable the dump with the sanbox enabled. It will open the file in the browser process and pass the handle to the render process.
This changes FileWrapper to deal with the case were the file handle is not managed by the wrapper.
BUG=2567
R=andrew@webrtc.org , henrika@webrtc.org , perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4649004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5239 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-06 16:05:17 +00:00
sprang@webrtc.org
88615f0659
Fix use of uninitialized memory in RtpSenderTest::StreamDataCountersCallbacks
...
BUG=
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5229004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5236 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-06 13:16:44 +00:00
asapersson@webrtc.org
96a9b2dcdc
Use the RTT from RtcpRttStats class if provided when sending/receiving NACK.
...
R=holmer@google.com
Review URL: https://webrtc-codereview.appspot.com/5049004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5228 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-05 15:06:56 +00:00
sprang@webrtc.org
ebad765ee0
Add callbacks for send channel rtp statistics
...
BUG=2235
R=mflodman@webrtc.org , pbos@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4449004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5227 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-05 14:29:02 +00:00
stefan@webrtc.org
0a3c1471b8
Add API to query video engine for the send-side delay.
...
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4559005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5225 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-05 14:05:07 +00:00
sprang@webrtc.org
a6ad6e5b58
Add callbacks for send channel rtcp statistics
...
BUG=2235
R=mflodman@webrtc.org , pbos@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4429004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5220 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-05 09:48:44 +00:00
stefan@webrtc.org
c4726d06fa
Make RTPSender::SendPadData public.
...
R=andresp@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5029004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5219 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-05 09:16:33 +00:00
andrew@webrtc.org
3d9981d58a
Remove unused ThreadData struct.
...
TBR=bjornv
Review URL: https://webrtc-codereview.appspot.com/4949004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5216 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-04 17:13:47 +00:00
sprang@webrtc.org
71f055fb41
Add send frame rate statistics callback
...
BUG=2235
R=mflodman@webrtc.org , pbos@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4479005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5213 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-04 15:09:27 +00:00
stefan@webrtc.org
79b63206b9
Fixes a crash in fullstack tests introduced with r5209.
...
TBR=mflodman@webrtc.org
BUG=1812
Review URL: https://webrtc-codereview.appspot.com/4689005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5211 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-04 13:34:28 +00:00
henrik.lundin@webrtc.org
b477fa6d21
Small fixes to plot_neteq_delay.m
...
Fixing problems with wrap-arounds and other small things. Adding an
extra output value.
Review URL: https://webrtc-codereview.appspot.com/4929004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5210 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-04 12:28:47 +00:00
stefan@webrtc.org
7e9315b42e
Adds support for sending redundant payloads over RTX.
...
TEST=trybots
BUG=1812
R=mflodman@webrtc.org , pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4169004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5209 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-04 10:24:26 +00:00
henrik.lundin@webrtc.org
9523b55826
Fix a typo in neteq.gypi
...
This CL is for NetEq3. The #define for iSAC-fb was wrong on one
line. It did not affect the defualt use case, but resulted in
errors if 48 kHz mode was enabled.
TBR=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4909004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5208 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-04 08:24:49 +00:00
andrew@webrtc.org
d7696c4ed1
Compile-out functions only used by the bit-exact test.
...
Causes errors on platforms where the test is unused.
TBR=bjornv
Review URL: https://webrtc-codereview.appspot.com/4869004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5207 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-03 23:39:16 +00:00
fischman@webrtc.org
d3865e9124
Don't HANDLE_EINTR(close). Use IGNORE_EINTR(close).
...
It is incorrect to wrap close in HANDLE_EINTR on Linux.
BUG=chromium:269623
R=fischman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4759004
Patch from Mark Mentovai <mark@chromium.org>.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5206 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-03 19:10:20 +00:00