admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
7,499 Commits 1 Branch 0 Tags
Commit Graph

106 Commits

Author SHA1 Message Date
tommi@webrtc.org
875c97ed9d Remove SetNotAlive method from the thread class. 
Also cleaning up methods with the same name in other classes that are derived from the above method.

R=perkj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/41759004

Cr-Commit-Position: refs/heads/master@{#8242}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8242 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-04 11:12:39 +00:00
tommi@webrtc.org
aef0779dab Rewrite ThreadWindows. 
* Remove "dead" and "alive" variables.
* Remove critical section
* Skip synchronizing with the worker thread to verify startup (no need).
* Remove implementation of SetNotAlive()
* Always set thread name
* Add thread checks for correct usage.

Also added some TODOs for myself for the ThreadWrapper interface.

I'm removing the HasNoMonitorThread test since it is no longer relevant and ends up checking the wrong thing (ProcessThread - a generic thread type) in the wrong way (parsing a debug log) :)  I think it served a purpose some years ago, but things have changed since.

BUG=2902
R=henrika@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/37069004

Cr-Commit-Position: refs/heads/master@{#8220}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8220 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-01-30 15:06:44 +00:00
tommi@webrtc.org
2bbc35d896 Remove unused method, SetAffinity, from the ThreadWrapper class. 
The method was also not consistently implemented across all platforms.

R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/33169004

Cr-Commit-Position: refs/heads/master@{#8212}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8212 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-01-30 09:43:20 +00:00
kwiberg@webrtc.org
2ebfac5649 Remove COMPILE_ASSERT and use static_assert everywhere 
COMPILE_ASSERT is no longer needed now that we have C++11's
static_assert.

R=aluebs@webrtc.org, andrew@webrtc.org, hellner@chromium.org, henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/39469004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@8058 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-01-14 10:51:54 +00:00
andresp@webrtc.org
86e1e487e7 Move system_wrappers.gyp files to the proper directory. 
Build targets should not refer to non-subpaths as was happening before when
 source/system_wrappers.gyp refers to ../interface/ files.

R=kjellander@webrtc.org, tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/37609004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@8057 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-01-14 09:30:52 +00:00
kwiberg@webrtc.org
af9d56f38c Unify the two copies of template_util.h 
This patch basically deletes webrtc/base/template_util.h (which is the
more outdated copy, although there are only cosmetical differences)
and moves webrtc/system_wrappers/source/template_util.h to take its
place.

The reunified header uses the rtc namespace like the old
webrtc/base/template_util.h, rather than the webrtc namespace like
webrtc/system_wrappers/source/template_util.h.

R=aluebs@webrtc.org, andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/38579004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@8050 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-01-13 20:32:04 +00:00
kwiberg@webrtc.org
3df38b442f Unify the two copies of compile_assert.h 
This patch basically deletes webrtc/base/compile_assert.h (which is
the more outdated copy) and moves
webrtc/system_wrappers/source/compile_assert.h to take its place.

R=aluebs@webrtc.org, andrew@webrtc.org, tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/36719004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@8048 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-01-13 11:37:48 +00:00
kwiberg@webrtc.org
aa21f2765b Unify the two copies of move.h 
This patch basically deletes webrtc/base/move.h (which is the more
outdated copy) and moves webrtc/system_wrappers/source/move.h to take
its place.

R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/35549004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7963 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-12-19 14:35:57 +00:00
asapersson@webrtc.org
97d0489058 Add video send bitrates to histogram stats: 
- total bitrate ("WebRTC.Video.BitrateSentInKbps")
- media bitrate ("WebRTC.Video.MediaBitrateSentInKbps")
- rtx bitrate ("WebRTC.Video.RtxBitrateSentInKbps")
- padding bitrate ("WebRTC.Video.PaddingBitrateSentInKbps")
- retransmitted bitrate ("WebRTC.Video.RetransmittedBitrateInKbps")

Add retransmitted bytes to StreamDataCounters.

Change in UpdateRtpStats to also update counters for retransmitted packet.

BUG=crbug/419657
R=mflodman@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/30199004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7838 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-12-09 09:47:53 +00:00
asapersson@webrtc.org
83b5200f95 Add framerate for complete received frames to histogram stats: 
"WebRTC.Video.CompleteFramesReceivedPerSecond".

BUG=crbug/419657
R=mflodman@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/32089004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7762 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-11-28 10:17:13 +00:00
pkasting@chromium.org
4591fbd09f Use size_t more consistently for packet/payload lengths. 
See design doc at https://docs.google.com/a/chromium.org/document/d/1I6nmE9D_BmCY-IoV6MDPY2V6WYpEI-dg2apWXTfZyUI/edit?usp=sharing for more information.

This CL was reviewed and approved in pieces in the following CLs:
https://webrtc-codereview.appspot.com/24209004/
https://webrtc-codereview.appspot.com/24229004/
https://webrtc-codereview.appspot.com/24259004/
https://webrtc-codereview.appspot.com/25109004/
https://webrtc-codereview.appspot.com/26099004/
https://webrtc-codereview.appspot.com/27069004/
https://webrtc-codereview.appspot.com/27969004/
https://webrtc-codereview.appspot.com/27989004/
https://webrtc-codereview.appspot.com/29009004/
https://webrtc-codereview.appspot.com/30929004/
https://webrtc-codereview.appspot.com/30939004/
https://webrtc-codereview.appspot.com/31999004/
Committing as TBR to the original reviewers.

BUG=chromium:81439
TEST=none
TBR=pthatcher,henrik.lundin,tina.legrand,stefan,tkchin,glaznev,kjellander,perkj,mflodman,henrika,asapersson,niklas.enbom

Review URL: https://webrtc-codereview.appspot.com/23129004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7726 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-11-20 22:28:14 +00:00
asapersson@webrtc.org
96dc685143 Add stats for video: 
- number of sent/received RTCP NACK/FIR/PLI per minute
- percentage of unique sent/received NACK requests
- percentage of discarded/duplicated packets by the jitter buffer
- permille of sent/received key frames

BUG=crbug/419657
R=mflodman@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/24959004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7592 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-11-03 14:40:38 +00:00
andrew@webrtc.org
cc476aa038 Fix a name collision with Android libc++ 
The Android libc++ has a symbol called '_P'
This CL renames a property called _P in webrtc.

BUG=chromium:427718
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/30009004

Patch from Fabrice de Gans-Riberi <fdegans@chromium.org>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7579 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-10-31 16:01:25 +00:00
henrike@webrtc.org
bd6bdca57f scoped_ptr.h: Renames function and change namespace scope to fix conflicts with Chromium not detected by the FYI bots. 
BUG=N/A
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/23259004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7546 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-10-28 18:06:42 +00:00
andrew@webrtc.org
b787f4c593 Move scoped_ptr "free" functions into the webrtc namespace. 
Resolves a conflict with Chromium's scoped_ptr on the recently added
make_scoped_ptr().

TEST=local Chromium Linux build passes.
R=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/26969004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7535 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-10-27 17:42:22 +00:00
andrew@webrtc.org
df429882af Upgrade our scoped_ptr copy to match Chromium's latest. 
In particular add the move constructor and assignment operator.

Diff between our version and Chromium's:
https://paste.googleplex.com/4887047529562112

R=henrike@webrtc.org, kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/31789004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7531 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-10-27 16:12:38 +00:00
asapersson@webrtc.org
580d367b14 Add macros and APIs for webrtc histograms. 
BUG=crbug/419657

Code that links system_wrappers.gyp:system_wrappers should either:
- provide implementations for the APIs, or
- link with default implementations in system_wrappers.gyp:system_wrappers_default.

R=andresp@webrtc.org, kjellander@webrtc.org, mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/22809004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7508 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-10-23 12:57:56 +00:00
andrew@webrtc.org
325cff01b4 Import LappedTransform and friends. 
Add code for doing block-based frequency domain processing. Developed
and reviewed in isolation. Corresponding export CL:
https://chromereviews.googleplex.com/95187013/

R=bercic@google.com, kjellander@webrtc.org, turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/31539004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7359 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-10-01 17:42:18 +00:00
pbos@webrtc.org
38344ed280 Move thread_annotations.h to webrtc/base/. 
R=andresp@webrtc.org, mflodman@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/27579004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7283 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-09-24 06:05:00 +00:00
henrike@webrtc.org
7ea71de396 clock.h: Removed GUARDED_BY annotation as it breaks som builds. 
BUG=N/A
TBR=henrik.lundin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14769004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6547 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-06-26 16:13:58 +00:00
henrik.lundin@webrtc.org
19db3e3164 Don't forward declare RWLockWrapper in clock.h 
Include rw_lock_wrapper.h instead of forward declaring. This is to
come around problems with thread annotations in some build systems.

BUG=3516
R=mflodman@webrtc.org, pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/17809004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6545 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-06-26 14:01:18 +00:00
henrik.lundin@webrtc.org
190a32fd55 Make some methods in Clock class const declared 
R=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/20579004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6375 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-06-09 17:40:49 +00:00
henrik.lundin@webrtc.org
59336e85fb Adding R/W lock to SimulatedClock 
This change makes the SimulatedClock class thread safe.

R=mflodman@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15569004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6251 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-27 09:34:58 +00:00
henrike@webrtc.org
88fbb2d86b Switch to using base/constructormagic.h and remove system_wrappers/interface/constructor_magic.h. 
Same as https://webrtc-codereview.appspot.com/19519004. The issue in
http://chromegw.corp.google.com/i/internal.chromium.webrtc.fyi/builders/Linux...
is solved by this change
http://src.chromium.org/viewvc/chrome/trunk/src/third_party/libjingle/libjing...
(tested locally).

BUG=3380
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/17619005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6218 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-21 21:18:46 +00:00
mcasas@webrtc.org
2fa7f79094 Revert 6202 "Switch to using base/constructormagic.h and remove ..." 
> Switch to using base/constructormagic.h and remove system_wrappers/interface/constructor_magic.h.
> 
> BUG=N/A
> R=andrew@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/19519004

TBR=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14579007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6210 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-21 11:07:29 +00:00
henrike@webrtc.org
125ffd709d Switch to using base/constructormagic.h and remove system_wrappers/interface/constructor_magic.h. 
BUG=N/A
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19519004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6202 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-20 15:20:44 +00:00
andresp@webrtc.org
60015d27ae Wire up --force_fieldtrials for vie_auto_test and for test targets linking with test/test.gyp:{test_main|test_support_main} 
This allows use of webrtc field trials  and opens up the possibility to try the different code paths when running the unit tests by wiring them up to a --force_fieldtrials.

Tested: running a test target that links with the above with a flag --force_fieldtrials=invalid leads the test to crash.

BUG=crbug/367114
R=mflodman@webrtc.org, phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19439004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6181 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-16 09:39:51 +00:00
andresp@webrtc.org
a36ad6929d Add webrtc field trials API. 
From now on it is expected that code linking system_wrappers.gyp:system_wrappers
provides an implementation for field_trial API or links with the default one in
system_wrappers.gyp:field_trial_default.

Note: Since there is no use of webrtc::field_trial API inside webrtc this CL on
itself does not forces the clients to actually define it. It however lays the
API and updates the gyp rules to link with so that it is ready to use.

Tested: Introduced a use of field trial in system wrappers and make sure all
bots were building successfully.

BUG=crbug/367114
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14489004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6147 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-14 12:24:04 +00:00
andresp@webrtc.org
93ec9c557b Revert "FieldTrial implementation for webrtc." (rev 6089) 
New wiring plans require it to be landed first in chrome for a cleaner roll of webrtc.

BUG=crbug/367114
R=tommi@webrtc.org
TBR=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/17479004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6122 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-13 14:09:40 +00:00
andresp@webrtc.org
6a8a6723d3 FieldTrial implementation for webrtc. 
BUG=crbug/367114
R=asvitkine@chromium.org, mflodman@webrtc.org, tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14399004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6089 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-09 07:14:34 +00:00
wu@webrtc.org
66773a032a Move timestamp_extrapolator and rtp_to_ntp to system wrapper so that it can be shared by both audio and video engine. 
BUG=3111
TEST=try bots
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/13459004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6074 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-07 17:09:44 +00:00
andrew@webrtc.org
a0edf4cb04 Remove ALLOW_UNUSED. 
Turns out Chromium won't be applying this to COMPILE_ASSERT. We don't
need it at all then.

R=thakis@chromium.org
TBR=thakis@chromium.org

Review URL: https://webrtc-codereview.appspot.com/13469005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6055 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-05 18:18:02 +00:00
andrew@webrtc.org
9f453b1a1b Add ALLOW_UNUSED and update COMPILE_ASSERT to Chromium's latest. 
Fixes building with gcc 4.8.

TBR=fdegans@google.com
BUG=chromium:321833

Review URL: https://webrtc-codereview.appspot.com/12439004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6050 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-05-04 03:04:26 +00:00
andrew@webrtc.org
8f69330310 Replace scoped_array<T> with scoped_ptr<T[]>. 
scoped_array is deprecated. This was done using a Chromium clang tool:
http://src.chromium.org/viewvc/chrome/trunk/src/tools/clang/rewrite_scoped_ar...

except for the few not-built-on-Linux files which were updated manually.

TESTED=trybots
BUG=2515
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12429004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5985 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-04-25 23:10:28 +00:00
andrew@webrtc.org
0daa8be9d6 Add Chromium's ScopedVector. 
Trivial changes from the original excepting scoped_vector_unittest.cc,
diff here: https://paste.googleplex.com/6664017300946944

This is a prerequisite for:
http://review.webrtc.org/9919004/

TBR=henrike@webrtc.org
BUG=2894

Review URL: https://webrtc-codereview.appspot.com/12179004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5938 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-04-18 21:20:54 +00:00
kjellander@webrtc.org
7de47bce12 Remove use of tmpnam. 
This solves compilation with the Mac SDK 10.9.

BUG=3120, 3151
TEST=git try -t modules_tests:VideoProcessorIntegrationTest*
R=fischman@webrtc.org, henrike@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/10739005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5917 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-04-16 08:04:26 +00:00
pbos@webrtc.org
3ecc162d01 Remove std:: prefixes from C functions in webrtc/. 
std::memcpy -> memcpy for instance. This change was motivated by a
compile report complaining that std::rand() was used instead of rand(),
probably with a stdlib.h include instead of cstdlib. Use of C functions
without the std:: prefix is a lot more common, so removing std:: to
address this.

BUG=
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/9549004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5658 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-03-07 15:23:34 +00:00
andrew@webrtc.org
d617a44a4f Add an AlignedFreeDeleter and remove scoped_ptr_malloc. 
- Transition scoped_ptr_mallocs to scoped_ptr.
- AlignedFreeDeleter matches Chromium's version.

TESTED=try bots
R=turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8969005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5587 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-20 21:08:36 +00:00
jiayl@webrtc.org
cf1b51b6fb Moves the display reconfiguration callback into a separate class, 
so that it can be shared with the cursor monitor when single monitor capturing
is added (https://webrtc-codereview.appspot.com/4679005/).
This Cl should have no functionality change.

BUG=2253
R=henrike@webrtc.org, sergeyu@chromium.org

Review URL: https://webrtc-codereview.appspot.com/7599004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5461 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-29 21:59:12 +00:00
henrike@webrtc.org
3907c2e7e5 Removes the remaining uses of the list wrapper class and the list wrapper class. 
BUG=2164
R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7019007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5378 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-01-13 22:41:34 +00:00
andresp@webrtc.org
7fb75ecbd4 Add thread_annotations for clang targets. 
TESTED: As expected clang bots catched a few issues which are fixed with this CL, other bots ignore the annotations and compile fine.

R=niklas.enbom@webrtc.org, phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/6209004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5328 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-12-20 20:20:50 +00:00
henrikg@webrtc.org
863b536100 Allow opening an AEC dump from an existing file handle. 
This is necessary for Chromium to be able enable the dump with the sanbox enabled. It will open the file in the browser process and pass the handle to the render process.

This changes FileWrapper to deal with the case were the file handle is not managed by the wrapper.

BUG=2567
R=andrew@webrtc.org, henrika@webrtc.org, perkj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/4649004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5239 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-12-06 16:05:17 +00:00
pbos@webrtc.org
57eb858698 Remove ".." from include_dirs in build/common. 
BUG=1662
TEST=compile on trybots
R=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2332004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5107 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-11-11 10:20:27 +00:00
henrikg@webrtc.org
bff9620116 Fix log build error for Chromium builds. 
This only happens when building in Chromium. Can't roll due to this.

../../third_party/webrtc/modules/desktop_capture/mouse_cursor_monitor_x11.cc: In function 'Window {anonymous}::GetTopLevelWindow(Display*, Window)':
../../third_party/webrtc/modules/desktop_capture/mouse_cursor_monitor_x11.cc:39:7: error: 'LS_INFO' was not declared in this scope
../../third_party/webrtc/modules/desktop_capture/mouse_cursor_monitor_x11.cc:39:7: note: suggested alternative:
../../third_party/webrtc/system_wrappers/interface/logging.h:71:29: note:   'webrtc::LS_INFO'

See for example http://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20%5Blatest%20WebRTC%2Blibjingle%5D/builds/3039/steps/compile/logs/stdio

R=henrika@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/3619004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5100 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-11-08 10:37:27 +00:00
andrew@webrtc.org
f1a48174d4 Replace disabled logging with a restricted logging mode. 
This will enable some low-level webrtc logging in a Chromium build,
while limiting the binary size impact.

For a Mac Release build, it results in an increase to Chrome.app of 37k
and libpeerconnection.so of 25k. For comparison, enabling full logs
costs 230k and 218k respectively.

BUG=b/11470432
TESTED=voe_cmd_test produces logs of the appropriate severity.
R=fischman@webrtc.org, henrikg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/3479004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5097 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-11-07 23:47:26 +00:00
wu@webrtc.org
de748c806c Remove unused make_scoped_ptr which causes an "ambiguous" error with chromium build. 
TEST=build
R=andrew@webrtc.org, fischman@webrtc.org
TBR=andrew

Review URL: https://webrtc-codereview.appspot.com/3149004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5059 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-30 20:43:27 +00:00
andrew@webrtc.org
b3731da68f Prefix MOVE_ONLY_TYPE_FOR_CPP_03 with WEBRTC_. 
Will fix a redefinition error in Chromium against webrtc head.

TESTED=trybots
R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2869004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5029 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-24 15:16:53 +00:00
andrew@webrtc.org
d1bcf1180a Check if WARN_UNUSED_RESULT and COMPILE_ASSERT are defined. 
Works around a multiple definition error from webrtc and libjingle.

Corresponds to the libjingle change here:
https://critique.corp.google.com/#review/55489575-p10

TESTED=trybots
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2809004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5025 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-23 19:11:32 +00:00
andrew@webrtc.org
31628aae7e Upgrade scoped_ptr to Chromium's latest version. 
Analogous to the recent libjingle change: http://cl/54929753-p10.
This supports scoped_ptr<T[]> and scoped_ptr<C, FreeDeleter> rather
than scoped_array and scoped_ptr_malloc respectively.

- Add Chromium's template-based COMPILE_ASSERT. We didn't have this
previously in order to support the macro in C. Instead, move the
existing macro to compile_assert_c.h.
- Additionally copy the move.h and template_util.h depedencies and add
the WARN_UNUSED_RESULT macro.
- Leave scoped_array and scoped_ptr_malloc for now, but mark as
deprecated.
- Remove scoped_ptr foo(NULL) use. The default constructor handles it.
- Remove the now redundant COMPILE_ASSERT from peerconnection_jni.cc.
- Add a CHECK_ARRAY_SIZE macro to rtp_format_vp8_unittest.cc to remove
some repeated code.

TESTED=trybots
R=pbos@webrtc.org, tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2449005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5015 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-22 12:50:00 +00:00
fischman@webrtc.org
7e4d0df8ee PeerConnection(Android): enable tracing to logcat. 
BUG=1295
R=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2258007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4888 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-10-01 02:40:43 +00:00