Tommi
2067826a5e
Remove dependency on ConditionVariableWrapper and CriticalSectionWrapper in UdpSocketPosix.
...
This is a part of cleaning up 'friend' parts of ConditionVariableWrapper's implementation where it accesses private variables of CriticalSectionWrapper, which is not good since it makes assumptions about the implementation on all posix platforms.
Instead I'm using rtc::Event, another condition variable based implementation we have, and fits the requirements of UdpSocketPosix.
BUG=
R=pbos@webrtc.org
Review URL: https://codereview.webrtc.org/1591333002 .
Cr-Commit-Position: refs/heads/master@{#11295}
2016-01-18 19:35:49 +00:00
Henrik Kjellander
98f53510b2
system_wrappers: rename interface -> include
...
BUG=webrtc:5095
R=tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1413333002 .
Cr-Commit-Position: refs/heads/master@{#10438}
2015-10-28 17:17:50 +00:00
tommi@webrtc.org
4161715e3f
Remove ChangeUniqueID.
...
This fixes a two year old TODO of deleting dead code :)
In cases where the _id or id_ member variable is being used for tracing,
I changed the member to at least be const.
It doesn't look like id's are that useful anymore so maybe the next step is to get rid of them.
BUG=
R=henrika@webrtc.org , perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37849004
Cr-Commit-Position: refs/heads/master@{#8201}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8201 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-29 12:14:13 +00:00
pkasting@chromium.org
4591fbd09f
Use size_t more consistently for packet/payload lengths.
...
See design doc at https://docs.google.com/a/chromium.org/document/d/1I6nmE9D_BmCY-IoV6MDPY2V6WYpEI-dg2apWXTfZyUI/edit?usp=sharing for more information.
This CL was reviewed and approved in pieces in the following CLs:
https://webrtc-codereview.appspot.com/24209004/
https://webrtc-codereview.appspot.com/24229004/
https://webrtc-codereview.appspot.com/24259004/
https://webrtc-codereview.appspot.com/25109004/
https://webrtc-codereview.appspot.com/26099004/
https://webrtc-codereview.appspot.com/27069004/
https://webrtc-codereview.appspot.com/27969004/
https://webrtc-codereview.appspot.com/27989004/
https://webrtc-codereview.appspot.com/29009004/
https://webrtc-codereview.appspot.com/30929004/
https://webrtc-codereview.appspot.com/30939004/
https://webrtc-codereview.appspot.com/31999004/
Committing as TBR to the original reviewers.
BUG=chromium:81439
TEST=none
TBR=pthatcher,henrik.lundin,tina.legrand,stefan,tkchin,glaznev,kjellander,perkj,mflodman,henrika,asapersson,niklas.enbom
Review URL: https://webrtc-codereview.appspot.com/23129004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7726 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-20 22:28:14 +00:00
henrikg@webrtc.org
dae612ebf8
Mark all virtual overrides in the hierarchies of UdpTransportData and
...
UdpSocketWrapper as such.
This will make further changes to these classes safer by ensuring that the
compile breaks if the base class changes and not all overrides are fixed.
This also removes an unused function.
BUG=none
TEST=none
R=henrik.lundin@webrtc.org , henrikg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/23579004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7195 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-16 15:29:02 +00:00
pbos@webrtc.org
e6c3966530
Fix some chromium-style warnings in webrtc/test/
...
BUG=163
R=phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1907004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4428 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-30 13:08:38 +00:00
pbos@webrtc.org
1e50231ff8
Include files from webrtc/.. paths in test/channel_transport/
...
BUG=1662
R=henrikg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1548004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4110 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-27 15:02:23 +00:00
pbos@webrtc.org
a5f1787f63
WebRtc_Word32 -> int32_t in test/
...
BUG=314
Review URL: https://webrtc-codereview.appspot.com/1302004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3794 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-09 11:10:21 +00:00
pwestin@webrtc.org
999e900fb6
Creating a copy of Udp transport under webrtc/test
...
Adding a test namespace, updating the include paths and renamed folder name.
Review URL: https://webrtc-codereview.appspot.com/1203004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3701 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-21 16:38:05 +00:00
