160 Commits

Author SHA1 Message Date
mflodman@webrtc.org
e5297d2aaa Big parameter passed as argument.
BUG=C-10503, C-10504, C-10505

Review URL: https://webrtc-codereview.appspot.com/343011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1441 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-17 12:44:41 +00:00
mflodman@webrtc.org
2877bdc590 Cleaned up resource leaks.
BUG=C-10059, C-10228, C-10229.

Review URL: https://webrtc-codereview.appspot.com/345013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1439 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-17 12:18:16 +00:00
mflodman@webrtc.org
7b3f3b1e42 CalcBufferSize can return -1, which wasn't handled by ViERenderer.
BUG=C-10532

Review URL: https://webrtc-codereview.appspot.com/345010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1438 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-17 12:12:42 +00:00
perkj@webrtc.org
5735a63e5a Add video capture module to the list of dependent projects in video engine.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/348007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1409 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-12 14:22:58 +00:00
kjellander@webrtc.org
7f3c724e12 Renaming 47 files from .cpp to .cc
In addition to our naming guidelines, this will cause these files to get parsed by Sonar, and to make searching/grepping the source using file extensions easier in the future.

BUG=
TEST=Compiling on Linux.

Review URL: http://webrtc-codereview.appspot.com/348005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1405 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-12 10:23:41 +00:00
punyabrata@webrtc.org
9a85b500c5 Minor tracing fix in ::IncomfingFrame and ::IncomfingFrameI420
Review URL: http://webrtc-codereview.appspot.com/352001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1401 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-12 00:37:07 +00:00
mflodman@webrtc.org
684c7b71c3 Fixed vie_defines.h typo.
BUG=220
TEST=Mac debug build

Review URL: http://webrtc-codereview.appspot.com/347006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1389 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-11 13:52:06 +00:00
mflodman@webrtc.org
5007056767 Added REMB option to custom call.
Review URL: http://webrtc-codereview.appspot.com/347003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1388 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-11 13:46:10 +00:00
perkj@webrtc.org
ce5990cb0b Fix defect http://code.google.com/p/webrtc/issues/detail?id=222
"ViE GetSentRTCPStatistics fails on a sending channel if it don't receive rtp video packets.

BUG=222
TEST= tested in loopback. No new test added yet.

Review URL: http://webrtc-codereview.appspot.com/343003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1387 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-11 13:00:08 +00:00
pwestin@webrtc.org
8281e7dd4a Added RTX to ViE.
Review URL: http://webrtc-codereview.appspot.com/336001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1373 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-10 14:09:18 +00:00
phoglund@webrtc.org
caf39f335f Re-enabled RTP-RTCP test since it's not flaky anymore.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/345003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1369 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-10 13:43:33 +00:00
mflodman@webrtc.org
0ab8ba313b We now require a manually set sender to send REMB packets.
BUG=
TEST=video_engine_unittests

Review URL: http://webrtc-codereview.appspot.com/348003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1358 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-09 16:16:49 +00:00
phoglund@webrtc.org
d8d85711c7 Temporarily disabled the standard rtp-rtcp test because of flakiness.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/349001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1356 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-09 12:06:42 +00:00
phoglund@webrtc.org
dc9536dd0e Made vie_auto_test more robust in Linux when the X environment is broken.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/329025

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1354 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-09 10:49:23 +00:00
punyabrata@webrtc.org
a0211c38ca Updating video revision
Review URL: http://webrtc-codereview.appspot.com/335016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1339 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 20:02:00 +00:00
mikhal@webrtc.org
d61e1cab08 Updating video engine following latest libyuv api changes
Review URL: http://webrtc-codereview.appspot.com/330026

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1336 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 18:57:52 +00:00
pwestin@webrtc.org
c450a19669 Removed Version function from all modules.
TBR=henrik_a
Review URL: http://webrtc-codereview.appspot.com/329023

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1330 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 15:00:12 +00:00
kjellander@webrtc.org
cc33737a80 Changing all PSNR/SSIM calculations to use libyuv.
Removed old PSNR/SSIM implementations in:
* test/testsupport/metrics/video_metrics.cc
* src/modules/video_coding/codecs/test_framework/test.cc
The functions in video_metrics.cc is now using code in libyuv instead. Old code in test.cc is using the same functions.
The code for video_metrics.h had to be moved into a separate GYP file to avoid circular dependency error on Mac (see issue 160 for more details). The reason for this is that libyuv's unittest target depends on test_support_main.

BUG=
TEST=metrics_unittests in Debug+Release on Linux, Mac and Windows.

Review URL: http://webrtc-codereview.appspot.com/333025

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1325 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 08:09:32 +00:00
mflodman@webrtc.org
adec9271b0 Correcting VieChannelManager bug.
Review URL: http://webrtc-codereview.appspot.com/337010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1320 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-03 21:43:15 +00:00
amyfong@webrtc.org
de5a10a044 Added in setting the minimum bit rate of a codec to ViE Custom Call
Review URL: http://webrtc-codereview.appspot.com/333019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1319 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-03 21:06:26 +00:00
andrew@webrtc.org
877c54e230 Fix unused-variable warning in Release.
TBR=mflodman@webrtc.org
TEST=Build Debug/Release on Linux

Review URL: http://webrtc-codereview.appspot.com/338003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1316 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-03 18:32:01 +00:00
mflodman@webrtc.org
9c0aedc28b Removed constraint for changing resolution when using default encoder and added VP8 log.
Review URL: http://webrtc-codereview.appspot.com/330029

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1314 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-03 13:46:49 +00:00
perkj@webrtc.org
60c9bbd976 Fix GetReceivedRTCPStatistics and GetSendRTCPStatistics.
Comments where wrong and removed error message when trying to get RTT time from GetReceivedRTCPStatistics.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/335013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1312 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-03 09:54:29 +00:00
mflodman@webrtc.org
d5a4d9bce6 First refactoring of ViE interface.
Review URL: http://webrtc-codereview.appspot.com/337003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1311 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-02 13:04:05 +00:00
amyfong@webrtc.org
ee2924cc56 Added vp8 codec temporal layer changing option to ViE AutoTest custom call.
Review URL: http://webrtc-codereview.appspot.com/330018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1292 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-22 18:24:28 +00:00
mflodman@webrtc.org
d32c44738a Changed constructor used for CriticalSectionScoped in ViE.
Only changed:
- Name of some of the critsects.
- All critsects (but one) are now scoped_ptr.
- Use of ptr constructor of CriticalSectionScoped instead of reference version.

BUG=184
TEST=vie_auto_test

Review URL: http://webrtc-codereview.appspot.com/330015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1291 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-22 14:17:53 +00:00
mflodman@webrtc.org
51faeed6be Fixed REMB unit test on Windows.
TBR=pwestin

Review URL: http://webrtc-codereview.appspot.com/330022

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1289 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-22 12:35:23 +00:00
stefan@webrtc.org
2ae4c8cf44 Disable temporal toggling by default.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/329012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1285 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-22 10:30:42 +00:00
mflodman@webrtc.org
84dc3d134d Add REMB functionality to ViE.
This CL only adds support for encoding one stream, but receiving multiple streams.

BUG=
TEST=video_engine_core_unittest + auto_test/loopback

Review URL: http://webrtc-codereview.appspot.com/333011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1284 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-22 10:26:13 +00:00
mflodman@webrtc.org
a4863dbdf0 Moved video_engine/main/interface to video_engine/include.
Only changed include paths in files, gyp-files and Android.mk.

TEST=vie_auto_test and peerconnection_client builds.

Review URL: http://webrtc-codereview.appspot.com/330017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1281 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-22 08:51:52 +00:00
kjellander@webrtc.org
173b7bbc16 Integration test that tracks dropped frames and compares video output.
The recorded frame timestamps are used to modify the output video on a frame-per-frame so it can be compared with the reference video using PSNR. This code will make it possible to use vie_auto_test for full stack comparisons with network interference and similar interesting simulations.

There's some refactoring done in vie_comparison_test.cc to make it fit to the new test.

Compiled and executed in Debug+Release on Linux, Mac and Windows.

BUG=
TEST=vie_auto_test --automated --gtest_filter=ViEVideoVerificationTest.*

Review URL: http://webrtc-codereview.appspot.com/320002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1269 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-21 16:11:25 +00:00
mflodman@webrtc.org
1fe2ada38d Fixed Win bug introduced when refactoring ViECodecImpl.
TBR=perkj

Review URL: http://webrtc-codereview.appspot.com/328013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1264 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-21 12:23:15 +00:00
mflodman@webrtc.org
c12686c2d0 Refactored ViEEncryptionImpl, ViECodecImpl and removed unused SRTP hooks/APIs in ViEEncrption.
Review URL: http://webrtc-codereview.appspot.com/331004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1262 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-21 09:29:28 +00:00
mflodman@webrtc.org
42d07f0c58 Render impl fix from refactoring.
Review URL: http://webrtc-codereview.appspot.com/329009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1248 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-20 13:20:36 +00:00
mflodman@webrtc.org
1bdf1dffb4 Refactored ViEImageProcess, ViEImpl and ViENetworkImpl.
Review URL: http://webrtc-codereview.appspot.com/331005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1247 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-20 11:57:47 +00:00
mflodman@webrtc.org
813b4ef2ea Refactored ViEFileImpl and ViEExternalCodec.
Review URL: http://webrtc-codereview.appspot.com/330007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1246 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-20 10:39:30 +00:00
mflodman@webrtc.org
8da2417c9d Refactored ViERenderImpl and ViERTP_RTCPImpl.
Review URL: http://webrtc-codereview.appspot.com/329005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1232 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-19 14:18:41 +00:00
mflodman@webrtc.org
7752d11056 Fix test for external codec.
Review URL: http://webrtc-codereview.appspot.com/328007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1231 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-19 12:29:56 +00:00
mflodman@webrtc.org
605972edfd Refactored ViECaptureImpl.
Review URL: http://webrtc-codereview.appspot.com/332004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1215 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-16 08:59:24 +00:00
mflodman@webrtc.org
352dcd8b2d Refactored vie_file_image.
Review URL: http://webrtc-codereview.appspot.com/332002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1214 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-16 08:52:41 +00:00
mflodman@webrtc.org
091029ba26 Refactored ViEFileRecorder.
Types and arguments will be done in a  later CL.

Review URL: http://webrtc-codereview.appspot.com/317008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1206 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-15 15:31:47 +00:00
mflodman@webrtc.org
03c06505fb Refactored ViEChannel.
Pointers/references and types will be in a future CL.

Review URL: http://webrtc-codereview.appspot.com/322016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1205 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-15 15:23:08 +00:00
mflodman@webrtc.org
e8be22c192 Refactored ViEChannelManager ViEInputManager.
Pointers/references and types will come in a future CL.

Review URL: http://webrtc-codereview.appspot.com/317012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1202 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-15 10:19:29 +00:00
mflodman@webrtc.org
02afbeaca5 Refactored ViERenderManager.
Will follow up with a new CL for pointer/references and functino arguments.

Review URL: http://webrtc-codereview.appspot.com/323013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1191 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 18:50:47 +00:00
mflodman@webrtc.org
7991c0501f Refactor ViEFilePlayer.
Types and arguments will be done in a  later CL.

Review URL: http://webrtc-codereview.appspot.com/324002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1180 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 08:38:37 +00:00
mflodman@webrtc.org
e6f64835a0 Refactored ViECapturer.
Types and function arguments will come in a later CL.

Review URL: http://webrtc-codereview.appspot.com/322011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1179 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 08:36:01 +00:00
mflodman@webrtc.org
9a8fa4e65d Refactored vie_manager_base.*.
The other files are only due to inheritance and will be refactored later. Same goes for pointer, references and function arguments.

Review URL: http://webrtc-codereview.appspot.com/318003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1178 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 08:18:42 +00:00
stefan@webrtc.org
f4c8286222 Pass NACK and FEC overhead rates through the ProtectionCallback to VCM.
These overhead rates are used by the VCM to compensate the source
coding rate for NACK and FEC.

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/323003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1171 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-13 15:38:14 +00:00
mflodman@webrtc.org
d5651b98c5 Refactored ViEFrameProviderBase.
Only style changes, ointers/references and functions will come in a later CL.

vie_capturer.cc and vie_file_player.cc are only changed du to inheriting protected members from ViEFrameProviderBase.

Review URL: http://webrtc-codereview.appspot.com/324001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1148 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 15:20:58 +00:00
mflodman@webrtc.org
5cc4dc9e0c Remove warnings in VideoEngine, capture module and render module.
BUG=164, 176, 180

Review URL: http://webrtc-codereview.appspot.com/303004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1145 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 10:12:57 +00:00