admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
8,233 Commits 1 Branch 0 Tags
Commit Graph

32 Commits

Author SHA1 Message Date
kjellander@webrtc.org
14665ff7d4 Roll chromium_revision e144d30..6fdb142 (318658:318841) + remove OVERRIDE macro 
Clang version changed 223108:230914
Details: e144d30..6fdb142/tools/clang/scripts/update.sh

Removes the OVERRIDE macro defined in:
* webrtc/base/common.h
* webrtc/typedefs.h

The majority of the source changes were done by running this in src/:
perl -0pi -e "s/virtual\s([^({;]*(\([^({;]*\)[^({;]*))(OVERRIDE|override)/\1override/sg" `find {talk,webrtc} -name "*.h"  -o -name "*.cc*" -o -name "*.mm*"`

which converted all:
virtual Foo() OVERRIDE
functions to:
Foo() override

Then I manually edited:
* talk/media/webrtc/fakewebrtccommon.h
* webrtc/test/fake_common.h

Remaining uses of OVERRIDE was fixed by search+replace.

Manual edits were done to fix virtual destructors that were
overriding inherited ones.

Finally a build error related to the pure virtual definitions of
Read, Write and Rewind in common_types.h required a bit of
refactoring in:
* webrtc/common_types.cc
* webrtc/common_types.h
* webrtc/system_wrappers/interface/file_wrapper.h
* webrtc/system_wrappers/source/file_impl.cc

This roll should make it possible for us to finally re-enable deadlock
detection for TSan on the buildbots.

BUG=4106
R=pbos@webrtc.org, tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/41069004

Cr-Commit-Position: refs/heads/master@{#8596}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8596 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-04 13:04:54 +00:00
tommi@webrtc.org
fbef5c6293 Remove lock in ViEFrameProviderBase::IsFrameCallbackRegistered. 
After looking at how this class is used I discovered that the threading model isn't completely crazy and that we can remove a lock from a method that's causing the most contention in getStats right now (and probably many other places).  IsFrameCallbackRegistered() looks innocent enough, but it contented with the frame encoder, which can make it wait for tens of milliseconds, unnecessarily.

In addition to removing the lock, I:

* Documented the threading model
* Added checks to guard against regressions
* Reduced lock scope in the Deregister function (not calling out to the notification while holding the lock).
*  made virtual functions non-virtual (since they're not really being overriden) and removed unnecessary method that, if called by other threads than the ctor thread, returned a value that wasn't necessarily correct.

BUG=2822
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/40859004

Cr-Commit-Position: refs/heads/master@{#8531}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8531 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-27 15:43:23 +00:00
pbos@webrtc.org
f4c10d24dc Always use DeliverI420Frame in WebRtcVideoEngine. 
Moves native_handle() path to DeliverI420Frame and CHECKs that
DeliverFrame is not being used anymore.

R=magjed@webrtc.org, mflodman@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/38019004

Cr-Commit-Position: refs/heads/master@{#8312}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8312 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-10 10:20:38 +00:00
magjed@webrtc.org
a26f511dd2 Remove frame copy in ViEExternalRendererImpl::RenderFrame 
Add new interface for delivering frames to ExternalRenderer. The purpose is to avoid having to extract a packed buffer from I420VideoFrame, which will cause a deep frame copy.

BUG=1128,4227
R=mflodman@webrtc.org

Committed: https://code.google.com/p/webrtc/source/detail?r=8136

Review URL: https://webrtc-codereview.appspot.com/36489004

Cr-Commit-Position: refs/heads/master@{#8199}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8199 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-01-29 11:45:43 +00:00
pkasting@chromium.org
4591fbd09f Use size_t more consistently for packet/payload lengths. 
See design doc at https://docs.google.com/a/chromium.org/document/d/1I6nmE9D_BmCY-IoV6MDPY2V6WYpEI-dg2apWXTfZyUI/edit?usp=sharing for more information.

This CL was reviewed and approved in pieces in the following CLs:
https://webrtc-codereview.appspot.com/24209004/
https://webrtc-codereview.appspot.com/24229004/
https://webrtc-codereview.appspot.com/24259004/
https://webrtc-codereview.appspot.com/25109004/
https://webrtc-codereview.appspot.com/26099004/
https://webrtc-codereview.appspot.com/27069004/
https://webrtc-codereview.appspot.com/27969004/
https://webrtc-codereview.appspot.com/27989004/
https://webrtc-codereview.appspot.com/29009004/
https://webrtc-codereview.appspot.com/30929004/
https://webrtc-codereview.appspot.com/30939004/
https://webrtc-codereview.appspot.com/31999004/
Committing as TBR to the original reviewers.

BUG=chromium:81439
TEST=none
TBR=pthatcher,henrik.lundin,tina.legrand,stefan,tkchin,glaznev,kjellander,perkj,mflodman,henrika,asapersson,niklas.enbom

Review URL: https://webrtc-codereview.appspot.com/23129004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7726 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-11-20 22:28:14 +00:00
stefan@webrtc.org
cb254aac3b Enable pacing by default and remove the option to disable it from the new API. 
BUG=1672
R=mflodman@webrtc.org, pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/17659004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6416 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-06-12 15:12:25 +00:00
wu@webrtc.org
6c75c98964 Propagate capture ntp timestamp from rtp to renderer. 
Mostly the interface changes, the real implementation of ntp timestamp will come in a follow up cl.

TEST=new tests and try bots
BUG=3111
R=niklas.enbom@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/11469004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5911 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-04-15 17:46:33 +00:00
asapersson@webrtc.org
54a05518e2 Increase run-time for full stack test for the rtt to be added reliably to the delay measurement. 
BUG=2592
R=holmer@google.com, phoglund@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/3719004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5146 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-11-21 07:45:08 +00:00
wu@webrtc.org
9dba525627 * Update libjingle to 50389769. 
* Together with "Add texture support for i420 video frame." from
wuchengli@chromium.org.
https://webrtc-codereview.appspot.com/1413004

RISK=P1
TESTED=try bots
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1967004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4489 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-05 20:36:57 +00:00
pbos@webrtc.org
12dc1a38ca Switch C++-style C headers with their C equivalents. 
The C++ headers define the C functions within the std:: namespace, but
we mainly don't use the std:: namespace for C functions. Therefore we
should include the C headers.

BUG=1833
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1917004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4486 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-05 16:22:53 +00:00
pbos@webrtc.org
4079c31c0a Include gflags with "gflags/gflags.h" instead of <> 
BUG=
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1551004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4120 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-05-28 10:38:11 +00:00
stefan@webrtc.org
c74c3c2447 Adds integration test for RTX and fixes bugs found. 
BUG=1811
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1529004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4096 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-05-23 13:48:22 +00:00
pbos@webrtc.org
21632124dd Include gflags properly and X11 include order in VideoEngine. 
BUG=

TBR=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1500004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4057 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-05-17 14:25:02 +00:00
pbos@webrtc.org
f5d4cb1958 Include files from webrtc/.. paths in video_engine/ 
BUG=1662
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1492004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4056 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-05-17 13:44:48 +00:00
pbos@webrtc.org
b238d1210b WebRtc_Word32 -> int32_t in video_engine/ 
BUG=314

Review URL: https://webrtc-codereview.appspot.com/1302005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3801 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-04-09 13:41:51 +00:00
phoglund@webrtc.org
df3a15f63b Removed spaces from full stack test labels, consolidated graphs 
NOTE TO SELF: save history on master when deploying!

BUG=
TEST=Ran locally

Review URL: https://webrtc-codereview.appspot.com/1021007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3337 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-01-07 10:06:52 +00:00
stefan@webrtc.org
1960219530 Make protection method, filename and resolution configurable for FullStackTest. 
Review URL: https://webrtc-codereview.appspot.com/991007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3315 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-12-19 12:45:16 +00:00
stefan@webrtc.org
32519398b6 Remove latency excl network and add render time diff stats. 
Review URL: https://webrtc-codereview.appspot.com/996004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3290 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-12-14 09:03:27 +00:00
elham@webrtc.org
ddebc17bee Fix for buffer overflow, WebRTC issue 1196 
Review URL: https://webrtc-codereview.appspot.com/998004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3286 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-12-13 21:55:47 +00:00
stefan@webrtc.org
91c91df35a Track the actual render time rather than the decode time. 
Review URL: https://webrtc-codereview.appspot.com/993004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3282 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-12-13 15:26:01 +00:00
stefan@webrtc.org
71258c594b Add a third full stack test and support for random jitter in ext transport. 
BUG=

Review URL: https://webrtc-codereview.appspot.com/975005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3260 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-12-11 15:14:56 +00:00
stefan@webrtc.org
e861359925 Adds two full stack performance metrics for end-to-end delay. 
Review URL: https://webrtc-codereview.appspot.com/937034

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3235 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-12-04 09:40:46 +00:00
phoglund@webrtc.org
273ccad59d Fixed standard PSNR/SSIM test. 
BUG=1103

Review URL: https://webrtc-codereview.appspot.com/971005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3197 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-11-29 10:08:16 +00:00
stefan@webrtc.org
ad7f1fefad Fixes (or at least reduces) the flakiness in the full stack test by making sure the different frame monitors are registered and deregistered in the right order. Also makes sure only local preview frames which are actually transmitted are rendered by moving the local preview rendering to an effect filter. 
BUG=

Review URL: https://webrtc-codereview.appspot.com/969005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3157 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-11-23 11:19:29 +00:00
phoglund@webrtc.org
849fb8ebd2 Removed codec comparison test: it didn't work and probably never will. 
The central problem is that we cannot sync the frames in the input video with the output video, which makes PSNR/SSIM go crazy. The test only appeared to succeed earlier due to a bug in the test. We can consider this a failed experiment, but we did learn a lot from it :)

BUG=550

Review URL: https://webrtc-codereview.appspot.com/969006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3155 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-11-23 09:21:44 +00:00
tommi@webrtc.org
21b426d2da Revert 3111 (revert of a revert). 
The trybots are succeeding and the modified code shouldn't
affect the test that failed so I suspect it was a fluke.
If this fails, I'll revert my revert so that we can
revert while we revert.
---
Revert 3105 - Don't crash the unit test host when tests fail.
Instead, just report the error, fail, and move on.

TEST=Run vie_auto_test, option=1.
    On my machine most of the tests fail for some reason
    that I'm still investigating, but the tests shouldn't
    be crashing the process which is what I'm fixing here.
Review URL: https://webrtc-codereview.appspot.com/929019

TBR=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/936026

TBR=mikhal@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/966021

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3115 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-11-16 09:37:08 +00:00
mikhal@webrtc.org
01c4b98f90 Revert 3105 - Don't crash the unit test host when tests fail. 
Instead, just report the error, fail, and move on.

TEST=Run vie_auto_test, option=1.
    On my machine most of the tests fail for some reason
    that I'm still investigating, but the tests shouldn't
    be crashing the process which is what I'm fixing here.
Review URL: https://webrtc-codereview.appspot.com/929019

TBR=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/936026

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3111 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-11-15 23:38:27 +00:00
tommi@webrtc.org
5ea70e619e Don't crash the unit test host when tests fail. 
Instead, just report the error, fail, and move on.

TEST=Run vie_auto_test, option=1.
    On my machine most of the tests fail for some reason
    that I'm still investigating, but the tests shouldn't
    be crashing the process which is what I'm fixing here.
Review URL: https://webrtc-codereview.appspot.com/929019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3105 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-11-15 14:38:10 +00:00
phoglund@webrtc.org
1401285fe7 Can now fully control custom calls from the command line. 
Example:
out/Debug/vie_auto_test --auto_custom_call --override "Enter destination IP.=127.0.10.55,Enter video send port.=12345"

The above will launch a call directly and choose all default values except for the overridden ones specified above.

BUG=

Review URL: https://webrtc-codereview.appspot.com/920008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3064 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-11-08 12:18:19 +00:00
vikasmarwaha@webrtc.org
6dddfe9c35 Fix for webrtc issue 1052 on windows with vie_auto_test. 
Review URL: https://webrtc-codereview.appspot.com/929014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3049 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-11-06 21:19:52 +00:00
andrew@webrtc.org
94caca7105 Reorganize modules/video_capture. 
- The usual elimination of main/source etc.
- Fully qualify "public" includes.
- Use lowercase for all directory names.

Review URL: https://webrtc-codereview.appspot.com/933010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3025 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-10-30 21:58:00 +00:00
andrew@webrtc.org
14b43beb7c Move src/ -> webrtc/ 
TBR=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/915006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2963 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-10-22 18:19:23 +00:00