21 Commits

Author SHA1 Message Date
henrik.lundin@webrtc.org
dbba1f969f Packet waiting-time statistics
Adding new statistics API to NetEQ, reporting the waiting time
for each frame. The output is raw waiting time for the frames
that have been decoded since the last statistics report (or
maximum 100 frames). The statistics are reset on each query.

Implemented functionality in ACM to query NetEQ for the raw
waiting times, and process it to produce max, average and
median.

Updating common_types.h and VoiceEngine tests to include the
new metrics.

Unit tests are also added for NetEQ and AcmNetEq.

Review URL: http://webrtc-codereview.appspot.com/328011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1251 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-20 15:45:05 +00:00
henrik.lundin@webrtc.org
6198624815 Remove warnings on Mac (Issue 178)
Remove an if-else that can never execute the else statement.
Remove double parenthesis.

BUG=http://code.google.com/p/webrtc/issues/detail?id=178
TEST=

Review URL: http://webrtc-codereview.appspot.com/318004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1146 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 13:58:17 +00:00
henrik.lundin@webrtc.org
d03718d1e4 Use ResourcePath in NetEQ unittest
Review URL: http://webrtc-codereview.appspot.com/320001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1130 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 11:42:43 +00:00
henrik.lundin@webrtc.org
598ad06432 Fixing compiler warning in NetEQ
With some compiler settings, a warning was issued for NetEQ,
saying that pw16_randVec was accessed out of bounds.
This did never happen in practice, but this change makes the
compiler understand this.

Review URL: http://webrtc-codereview.appspot.com/309001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1121 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-07 11:52:09 +00:00
henrik.lundin@webrtc.org
44ef3774ce Fixing a compiler error in NetEQ
This error would only arise when compiling without support for
DTMF (which is not the default config).

Review URL: http://webrtc-codereview.appspot.com/310001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1118 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-07 10:43:25 +00:00
perkj@webrtc.org
6b1bfd6c5e Changed webrtc::ACMCodecDB::neteq_decoders_ to a const array.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/304003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1092 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-02 12:48:19 +00:00
henrik.lundin@webrtc.org
e26aad4a9e Disable NetEQ unittest for Windows
Disable NetEqDecodingTest::TestNetworkStatistics for Windows.
It was never tested for Windows. Something is causing it to
fail, probably need different set of test vectors.

Review URL: http://webrtc-codereview.appspot.com/302003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1089 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-02 10:27:14 +00:00
henrik.lundin@webrtc.org
524eb48081 Removing deprecated NetEQ APIs
Removing WebRtcNetEQ_GetPreferredBufferSize and
WebRtcNetEQ_GetCurrentDelay and all dependent APIs.

Review URL: http://webrtc-codereview.appspot.com/289006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1063 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-30 16:21:22 +00:00
henrik.lundin@webrtc.org
fc9b903fbe Enable NetEQ statistics unit testing
Adding test target NetEqDecodingTest::TestNetworkStatistics.
Update neteq_unittest to get files from resources folder.
Update DEPS file to get resources revision 2.

Review URL: http://webrtc-codereview.appspot.com/291013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1050 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-29 15:38:27 +00:00
henrik.lundin@webrtc.org
2d8125dd1a Testing NetEQ network statistics
Implementing helper function for new unit test
NetEqDecodingTest::TestNetworkStatistics. The test itself
remains to be defined. (Will be added in a coming CL.)
This change required some refactoring of the test code
to avoid excessive code duplication.

Review URL: http://webrtc-codereview.appspot.com/295009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1049 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-29 14:30:28 +00:00
henrik.lundin@webrtc.org
0fcc2eb368 Cleaning up neteq_unittest
- Conforming to testing standards.
- Fixing a way of generating new reference output files.
- ifdef the test to run only on linux 64-bit
- Renaming unittest source file.
- Renaming test vectors

Review URL: http://webrtc-codereview.appspot.com/296007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1028 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-25 13:43:42 +00:00
henrik.lundin@webrtc.org
789da89d37 Fix a valgrind warning in NetEQ
The special cases for packet sizes <= 10 ms (one case for each
sample rate) resulted in reading outside of the pw16_decoded
vector. This is now fixed by making sure that WebRtcSpl_DownsampleFast
gets correct input and output vector lengths.

Review URL: http://webrtc-codereview.appspot.com/295008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1027 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-25 12:35:31 +00:00
kjellander@webrtc.org
543c3eaa46 Fixing Release compilation errors
Review URL: http://webrtc-codereview.appspot.com/267026

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1000 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-23 12:20:35 +00:00
henrik.lundin@webrtc.org
89ab652250 Cleaning up NetEQ statistics
Removed struct MCUStats_t and all references to it.
Removed totalDiscardedPackets and totalFlushedPackets
from the PacketBuf_t struct.

Review URL: http://webrtc-codereview.appspot.com/293001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@999 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-23 11:06:05 +00:00
henrik.lundin@webrtc.org
df10de4b27 Removing statistics API from NetEQ
Removing WebRtcNetEQ_GetJitterStatistics(),
WebRtcNetEQ_ResetJitterStatistics(), and the associated
struct WebRtcNetEQ_JitterStatistics. The change ripples
through all the way to the VoiceEngine API.

Review URL: http://webrtc-codereview.appspot.com/285002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@998 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-23 09:36:23 +00:00
henrik.lundin@webrtc.org
ba74924043 Remove use of exceptions in NetEQ test code
Replaced the exceptions thrown when codec instance creation failed
with simple exit(EXIT_FAILURE). There is no point in continuing
if creating the codec fails.

Review URL: http://webrtc-codereview.appspot.com/282002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@974 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-18 09:55:01 +00:00
kjellander@webrtc.org
64a897a772 Restructuring and adding dummy unit test target.
Empty test added to get code coverage recorded.

Review URL: http://webrtc-codereview.appspot.com/282001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@964 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-17 13:33:11 +00:00
kjellander@webrtc.org
0403ef419f Restructuring and adding unit test targets on project level instead of in common_audio.
Review URL: http://webrtc-codereview.appspot.com/280001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@959 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-17 08:35:47 +00:00
phoglund@webrtc.org
337dc68992 Included modules in webrtc.gyp and fixed build errors.
Removed TODO from webrtc.gyp since it is done.

Tabs -> spaces.

Tabs -> spaces.

Tabs -> spaces.

Fixed compilation on Windows.

Added missing file.

Merge branch 'master' into fix_mac_modules

Fixed compilation errors for the modules.gyp on Mac. This included some pretty large refactorings.

 Please enter the commit message for your changes. Lines starting

BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/269005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@957 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-16 15:36:44 +00:00
henrik.lundin@webrtc.org
bc91d5af86 NetEQ tests
Adding capability to parse RED payloads to the RTPanalyze tool.
Also adding a method to scramble an RTP payload (currently not
used).

Review URL: http://webrtc-codereview.appspot.com/276006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@945 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-15 10:16:01 +00:00
kjellander@webrtc.org
bf483844af Restructuring and removing neteq_tests.gypi according to project structure discussed with Andrew. We want to flatten out the hierarchy and minimize the number of GYP files.
I also fixed compilation on Mac (by enabling exceptions for the NetEqTestTools target). Executing the test fails on Mac, but I assume this is because it checks bit exactness, similar to the issue we had with audio_coding_module (see issue 114)

Review URL: http://webrtc-codereview.appspot.com/255004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@895 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-07 16:05:19 +00:00