pbos@webrtc.org
d5ce2e63df
Remove EventWrapper::Reset().
...
This simplifies the event wrapper which we've recently found issues in.
Also refactoring EndToEndTest.RespectsNetworkState to not depend on it.
BUG=
R=stefan@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/41939004
Cr-Commit-Position: refs/heads/master@{#8366}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8366 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-13 14:58:38 +00:00
sprang@webrtc.org
a6e8cebbd5
Fix false positive DHECK in event_posix.cc
...
It's OK that state is kDown when a thread is woken after being
signalled; another tread might also have woken and already set the state
to kDown.
Even if this waking and aquiring lock has been delayed until other
threads have set state to kDown and then subsequently to kUp again with
a new Set() call, it's OK to just set kDown and return since this thread
is returning kEventSignaled after the (new) Set() has ben called.
R=pbos@webrtc.org
TBR=tommi@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/36109004
Cr-Commit-Position: refs/heads/master@{#8334}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8334 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-11 15:19:22 +00:00
tommi@webrtc.org
30015e3180
Fix bug in EventPosix where we'd miss a set event.
...
In cases of timeout or error, we could change the state of the event to 'down' (unset) and subsequently never satisfy a Wait() for a given Set().
BUG=4284
R=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/38049004
Cr-Commit-Position: refs/heads/master@{#8310}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8310 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-10 09:34:02 +00:00
tommi@webrtc.org
f7e6cfd3a0
Add CHECK to EventWrapper to see if there's a subtle bug there or not.
...
R=pbos@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/38039005
Cr-Commit-Position: refs/heads/master@{#8302}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8302 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-09 18:25:56 +00:00
tommi@webrtc.org
875c97ed9d
Remove SetNotAlive method from the thread class.
...
Also cleaning up methods with the same name in other classes that are derived from the above method.
R=perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/41759004
Cr-Commit-Position: refs/heads/master@{#8242}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8242 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-04 11:12:39 +00:00
pbos@webrtc.org
e6dc38ea9b
Lock resources in event_posix.cc.
...
Fixes errors reported by Helgrind from event_posix.cc when running video_engine_tests.
BUG=
TEST=helgrind,trybots
R=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2060004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4572 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-20 09:49:19 +00:00
pbos@webrtc.org
d900e8bea8
Proper spacing for end-of-namespace comments.
...
BUG=
R=mflodman@webrtc.org , tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1760006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4293 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-03 15:12:26 +00:00
phoglund@webrtc.org
5bbe069f28
Reformatted event* classes.
...
TEST=Ran trybots.
Review URL: https://webrtc-codereview.appspot.com/972012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3253 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-10 10:44:37 +00:00
andrew@webrtc.org
14b43beb7c
Move src/ -> webrtc/
...
TBR=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/915006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2963 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-22 18:19:23 +00:00
