Boris Tsirkin
2becf23acc
Format /examples folder
...
Formatting done via:
git ls-files | grep -E '^examples\/.*\.(h|cc|mm)' | xargs clang-format -i
No-Iwyu: Includes didn't change and it isn't related to formatting
Bug: webrtc:42225392
Change-Id: I761ed6e6401af9fa68b435c5edbc58d285c3a5cc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/373583
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43676}
2025-01-08 03:40:08 -08:00
Jeremy Leconte
04d97b6c52
Fix "arithmetic on a pointer to void" warning.
...
Error appears when rolling Chromium in WebRTC:
https://ci.chromium.org/ui/p/webrtc/builders/try/mac_rel/76983/overview
Change-Id: Ibe9b15680efb00cac2333639a12c71cb76f6e71b
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/367781
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Auto-Submit: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43370}
2024-11-07 14:59:53 +00:00
Dor Hen
297fe1a2d9
[reland] Comment unused variables in implemented functions 10\n
...
Bug: webrtc:370878648
Change-Id: Icbfacf8113942f60ba168e4aa884f0172eaa0fca
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/367080
Commit-Queue: Dor Hen <dorhen@meta.com>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43336}
2024-10-31 07:08:00 +00:00
Harald Alvestrand
461e828d57
Revert "Comment unused variables in implemented functions 10\n"
...
This reverts commit f5e0f038440ae1cf46f84c3d740a75e420d808ca.
Reason for revert: Use of [[maybe_unused]] in .h files compiled in objC
Original change's description:
> Comment unused variables in implemented functions 10\n
>
> Bug: webrtc:370878648
> Change-Id: Ic2dda55058ed4474d898fa938c2a66dab2f6f20e
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/366204
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
> Commit-Queue: Dor Hen <dorhen@meta.com>
> Cr-Commit-Position: refs/heads/main@{#43327}
Bug: webrtc:370878648, b/376178831
Change-Id: Ibeaecd6ae21b6fc478ce153ad72f8941d7af4a46
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/367060
Reviewed-by: Christoffer Dewerin <jansson@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#43331}
2024-10-30 08:22:53 +00:00
Dor Hen
f5e0f03844
Comment unused variables in implemented functions 10\n
...
Bug: webrtc:370878648
Change-Id: Ic2dda55058ed4474d898fa938c2a66dab2f6f20e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/366204
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Dor Hen <dorhen@meta.com>
Cr-Commit-Position: refs/heads/main@{#43327}
2024-10-29 17:24:33 +00:00
Mirko Bonadei
a33881a638
Fix Wgnu-folding-constant.
...
This CL fixes "variable length array folded to constant array as an
extension" by switching the constant variable declaration to an enum,
which is compile-time constant.
Bug: None
Change-Id: Iff8cd22e6320a19439fc3f1ae2fb7126210e080b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227642
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Commit-Queue: Kári Helgason <kthelgason@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#34651}
2021-08-05 07:39:25 +00:00
Artem Titov
67b80ac5b2
Fix iOS chromium roll issue
...
Fix:
FAILED: obj/examples/socketrocket/SRWebSocket.o
../../examples/objc/AppRTCMobile/third_party/SocketRocket/SRWebSocket.m:1490:42:
error: block implicitly retains 'self'; explicitly mention 'self' to indicate
this is intended behavior [-Werror,-Wimplicit-retain-self]
[self _failWithError:_inputStream.streamError];
^
self->
Bug: None
Change-Id: Ieef356cd74749dbc4aaa5918da7c5b92fa5f4915
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215784
Commit-Queue: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33797}
2021-04-21 08:06:11 +00:00
Artem Titov
e313c07020
Fix iOS compilation for chromium roll
...
Fix:
FAILED: obj/examples/socketrocket/SRWebSocket.o
error: block implicitly retains 'self'; explicitly mention 'self' to
indicate this is intended behavior [-Werror,-Wimplicit-retain-self]
Bug: None
Change-Id: I55e6c8ebf81d80669308d9249d42dd158b9a09dd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215682
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33792}
2021-04-20 14:59:26 +00:00
Jonas Olsson
a4d873786f
Format almost everything.
...
This CL was generated by running
git ls-files | grep -P "(\.h|\.cc)$" | grep -v 'sdk/' | grep -v 'rtc_base/ssl_' | \
grep -v 'fake_rtc_certificate_generator.h' | grep -v 'modules/audio_device/win/' | \
grep -v 'system_wrappers/source/clock.cc' | grep -v 'rtc_base/trace_event.h' | \
grep -v 'modules/audio_coding/codecs/ilbc/' | grep -v 'screen_capturer_mac.h' | \
grep -v 'spl_inl_mips.h' | grep -v 'data_size_unittest.cc' | grep -v 'timestamp_unittest.cc' \
| xargs clang-format -i ; git cl format
Most of these changes are clang-format grouping and reordering includes
differently.
Bug: webrtc:9340
Change-Id: Ic83ddbc169bfacd21883e381b5181c3dd4fe8a63
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144051
Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28505}
2019-07-08 13:45:15 +00:00
Mirko Bonadei
bb547203bf
Moving src/webrtc into src/.
...
In order to eliminate the WebRTC Subtree mirror in Chromium,
WebRTC is moving the content of the src/webrtc directory up
to the src/ directory.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=tommi@webrtc.org
Bug: chromium:611808
Change-Id: Iac59c5b51b950f174119565bac87955a7994bc38
Reviewed-on: https://webrtc-review.googlesource.com/1560
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19845}
2017-09-15 04:25:06 +00:00