Florent Castelli
8037fc6ffa
Migrate absl::optional to std::optional
...
Bug: webrtc:342905193
No-Try: True
Change-Id: Icc968be43b8830038ea9a1f5f604307220457807
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361021
Auto-Submit: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42911}
2024-09-02 12:16:47 +00:00
Dor Hen
73195da677
Apply include-cleaner to api/test/metrics
...
Bug: webrtc:42226242
Change-Id: I3134d7a3885a86f0bd02ee5e12bb85b2e2d6ee8c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359180
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42760}
2024-08-12 12:11:35 +00:00
Florent Castelli
99c519b3fd
Mass removal of absl_deps in all BUILD.gn files
...
Bug: webrtc:341803749
Change-Id: Id73844ba8d63b9f2f2c9391d8d8116ad0864c36d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/351540
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42372}
2024-05-23 15:09:46 +00:00
Björn Terelius
c0eac979ca
Revert "Add the java proto options in metrics set proto."
...
This reverts commit f665f7faf4804cb1ce3c17ce67bfe8122b30d327.
Reason for revert: Speculative revert due to downstream breakages
Original change's description:
> Add the java proto options in metrics set proto.
>
> Bug: b/279024829
> Change-Id: Ib1604465dad1cd8b2b1198d53aa5d75191e56e2d
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329220
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Manashi Sarkar <manashi@google.com>
> Cr-Commit-Position: refs/heads/main@{#41288}
Bug: b/279024829
Change-Id: I3329081de58f6e42c4bf1cb03c7d706cb3f12e64
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329400
Auto-Submit: Björn Terelius <terelius@webrtc.org>
Owners-Override: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#41292}
2023-11-30 19:57:51 +00:00
Manashi Sarkar
f665f7faf4
Add the java proto options in metrics set proto.
...
Bug: b/279024829
Change-Id: Ib1604465dad1cd8b2b1198d53aa5d75191e56e2d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329220
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Manashi Sarkar <manashi@google.com>
Cr-Commit-Position: refs/heads/main@{#41288}
2023-11-30 14:15:41 +00:00
Mirko Bonadei
0b7184ce06
Add possibility to set MetricsSet metadata.
...
Bug: b/266997275
Change-Id: I2c4fadcff7044a8c72ef7e46caf4eff398e29f91
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291700
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39237}
2023-01-31 12:41:47 +00:00
Mirko Bonadei
e5922834f8
Add 'metadata' field to MetricsSet proto.
...
Bug: b/266997275
Change-Id: Iece033b0bd3b6e2946a57ae19dd4ff0a0417694f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291535
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39232}
2023-01-31 09:45:26 +00:00
Artem Titov
19813a4222
Remove unused MetricsLoggerAndExporter
...
Bug: None
Change-Id: I9e05e5c29cd80bf991bd50c3bd4ee4f09ddf8134
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/281420
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38531}
2022-11-02 07:35:47 +00:00
Björn Terelius
dd4b8d4853
Improve backwards compatibility of metrics exporter
...
Bug: b/248979985
Change-Id: I7c472bfa9cde2f0dc7fc61599b836dd74cad70d0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/278240
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38317}
2022-10-07 12:42:20 +00:00
Artem Titov
183e9968ce
Increase backward compatibility for PrintResultProxyMetricsExporter
...
Bug: b/246095034
Change-Id: Ie6f3dd86a402c2d5cec4dce90b5aa08c2a96ac27
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276741
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38206}
2022-09-26 14:16:10 +00:00
Artem Titov
f01ceb6f93
Introduce MetricsAccumulator
...
Bug: b/246095034
Change-Id: Ic267254245399238d3eece421e4e4e72134dd0e9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276740
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38203}
2022-09-26 13:12:40 +00:00
Artem Titov
d7dbe7fda8
Remove global MetricsLoggerAndExporter instance in favor of MetricsLogger
...
Bug: b/246095034
Change-Id: Ie3dd5947f0f593bd17cfecfa333d5254fa40769d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276628
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38190}
2022-09-25 09:33:10 +00:00
Artem Titov
5baa5b6278
Add global MetricsLogger and export APIs
...
Bug: b/246095034
Change-Id: Id4cab9352b2155d967d0604b830fd87511675789
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276603
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38183}
2022-09-23 15:22:23 +00:00
Artem Titov
7b0f4a211a
Introduce MetricsLogger to separate logging and export logic
...
Bug: b/246095034
Change-Id: If870016b87126feefb9c63b1544091f0855e169f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276600
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38180}
2022-09-23 14:00:07 +00:00
Artem Titov
3680605caa
[PCLF] Enable exporting of perf metric via new API
...
Bug: b/246095034
Change-Id: I05f28e5dfc6df793c035110f89d9ac40783687f8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276267
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38161}
2022-09-21 15:55:09 +00:00
Artem Titov
45c6f5e2e1
Change StdoutMetricsExporter format to improve readability
...
Change from
<test case>/<metric name>
to
<test case> / <metric name>
to increase readability when <test case> itself contains "/" or
<metric name> contains "/"
Bug: b/246095034
Change-Id: If870fdcac37275aecf87e7d57e8aada05a5ef454
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276263
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38155}
2022-09-21 13:30:11 +00:00
Artem Titov
e11d5e378c
[DVQA] Add ability to export metrics with MetricsLoggerAndExporter
...
Bug: b/246095034
Change-Id: Ibbadd11ff27f65cc128efd891eace89df3c59316
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276101
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38145}
2022-09-21 08:15:30 +00:00
Artem Titov
164bb2fcca
[PCLF] Add possibility to use new perf metrics api in VideoQualityMetricsReporter
...
Bug: b/246095034
Change-Id: Ia7a50404750538a65042562bd80f0cb88f78ab90
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276102
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38142}
2022-09-21 07:25:10 +00:00
Artem Titov
a5d2c7ecd6
Introduce PrintResultProxyMetricsExporter for migration from old to new API
...
Bug: b/246095034
Change-Id: I7597ddad84c4b2af1d59e38c558b1f0f56bd3f4e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276047
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38141}
2022-09-21 06:52:30 +00:00
Artem Titov
539c1da98d
Rename Metric Units: kTimeMs->kMilliseconds and kSizeInBytes->kBytes
...
Rename C++ API units to match new proto format units in metric.proto
Bug: b/246095034
Change-Id: Ice5d388a080c474f275ef597f98fac1bcb98cf49
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276100
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38137}
2022-09-20 21:54:21 +00:00
Artem Titov
01f3841e38
Fix: convert mean and stddev values when exporting to CPD
...
Also simplify exporter implementation
Bug: b/246095034
Change-Id: I656f17f7ee63d26445f3e420f3d22c52f336fa21
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276049
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38135}
2022-09-20 18:40:30 +00:00
Artem Titov
a3253e35b1
Fix test name in StdoutMetricsExporterTest
...
Bug: b/246095034
Change-Id: I645cc8de065ce34af49bb1c4cd633e3d7ef64bda
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276048
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38134}
2022-09-20 17:51:40 +00:00
Artem Titov
034f17aa4e
Introduce MetricsExporter for Chrome Perf Dashboard
...
Bug: b/246095034
Change-Id: I12ac5898909fcdcefc8238464bc74c5166c0177e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/274900
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38127}
2022-09-20 12:25:09 +00:00
Artem Titov
275d63a13e
Add MetricsSetProtoFileExporter
...
Bug: b/246095034
Change-Id: I002d0d5b132e61887b4bc87542fbf70dd81e488b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/275881
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38125}
2022-09-20 09:44:20 +00:00
Artem Titov
44161f542b
Introduce MetricsLoggerAndExporter
...
Introduce main API for new test performance metrics logging system.
Bug: b/246095034
Change-Id: I9b33740bfe69158c2d7f3f73e18442d1683aa8d4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/274901
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38116}
2022-09-19 11:19:38 +00:00
Artem Titov
27f91afa38
Introduce MetricsExporter API with stdout implementation
...
Bug: b/246095034
Change-Id: I9979fb03b9a02e76808145f43910420524fe633a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/274880
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38107}
2022-09-17 00:56:29 +00:00
Artem Titov
c898c82884
Introduce Metric object for new perf metrics logging system
...
Bug: b/246095034
Change-Id: I854ee8e5ea93e4046837ae9f54a652a8c92dd1bc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/274861
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38078}
2022-09-14 12:32:16 +00:00