2 Commits

Author	SHA1	Message	Date
Mirko Bonadei	317a1f09ed	Use std::make_unique instead of absl::make_unique. ... WebRTC is now using C++14 so there is no need to use the Abseil version of std::make_unique. This CL has been created with the following steps: git grep -l absl::make_unique | sort | uniq > /tmp/make_unique.txt git grep -l absl::WrapUnique | sort | uniq > /tmp/wrap_unique.txt git grep -l "#include <memory>" | sort | uniq > /tmp/memory.txt diff --new-line-format="" --unchanged-line-format="" \ /tmp/make_unique.txt /tmp/wrap_unique.txt | sort | \ uniq > /tmp/only_make_unique.txt diff --new-line-format="" --unchanged-line-format="" \ /tmp/only_make_unique.txt /tmp/memory.txt | \ xargs grep -l "absl/memory" > /tmp/add-memory.txt git grep -l "\babsl::make_unique\b" | \ xargs sed -i "s/\babsl::make_unique\b/std::make_unique/g" git checkout PRESUBMIT.py abseil-in-webrtc.md cat /tmp/add-memory.txt | \ xargs sed -i \ 's/#include "absl\/memory\/memory.h"/#include <memory>/g' git cl format # Manual fix order of the new inserted #include <memory> cat /tmp/only_make_unique | xargs grep -l "#include <memory>" | \ xargs sed -i '/#include "absl\/memory\/memory.h"/d' git ls-files | grep BUILD.gn | \ xargs sed -i '/\/\/third_party\/abseil-cpp\/absl\/memory/d' python tools_webrtc/gn_check_autofix.py \ -m tryserver.webrtc -b linux_rel # Repead the gn_check_autofix step for other platforms git ls-files | grep BUILD.gn | \ xargs sed -i 's/absl\/memory:memory/absl\/memory/g' git cl format Bug: webrtc:10945 Change-Id: I3fe28ea80f4dd3ba3cf28effd151d5e1f19aff89 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153221 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29209}	2019-09-17 15:47:29 +00:00
Bryan Ferguson	e8ef87bdad	Include menus & dialogs in frames captured by WindowCapturerWin ... This change adds logic to WindowCapturerWin to capture overlapping owned/pop-up windows (e.g. menus, dialogs, tooltips). This makes window capture behavior more consistent regardless of whether CroppingWindowCapturerWin is used & its conditions for using crop-from- screen capture are met (in ShouldUseScreenCapturer). (I.e. regardless of OS version, window shape / translucency, occlusion by another potentially top-most window, or whether the capturing app has opted in to using the cropping capturer). Owned/pop-up windows associated with the selected window are enumerated then captured individually, with their contents composited into the final frame. This change also: - Crops out the top window border (which exposed a bit of the background when using the cropping capturer, and resulted in an inconsistent appearance compared to the side & bottom borders being cropped out). Bug: chromium:980864 Change-Id: I81c504848a0c0e6bf122aeff437b400e44944718 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148302 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#28922}	2019-08-21 07:55:07 +00:00