40 Commits

Author SHA1 Message Date
pbos@webrtc.org
9401524211 Run FullStack tests without render windows.
Also disables test on valgrind platforms, it has no chance to keep up.

BUG=2278
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2159008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4972 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-16 11:05:37 +00:00
pbos@webrtc.org
266c7b330a Move ChromaGenerator to common_video/.
BUG=
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2394004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4964 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-15 09:15:47 +00:00
pbos@webrtc.org
6917e19ad4 Rename EngineTest to CallTest.
There's no real notion of VideoEngine left in these classes. They're
end-to-end tests built on Call, so CallTest makes more sense.

This also contains a modification to RtpRtcpObserver moving the
responsibility of creating the event that signals when the observation
is complete to RtpRtcpObserver. New tests are about to be introduced and
this will reduce code duplication.

BUG=
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2258005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4793 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-19 14:22:12 +00:00
andresp@webrtc.org
ab6549562b Refactor frame generation code so it can be used by multiple modules.
R=pbos@webrtc.org, stefan@webrtc.org, pbos, stefan
BUG=

Review URL: https://webrtc-codereview.appspot.com/2240004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4791 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-19 12:14:03 +00:00
pbos@webrtc.org
841c8a44bb Rename VideoCall to Call.
Call should encompass more than video, there's no point in calling it
VideoCall.

BUG=
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2191005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4704 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-09 15:04:25 +00:00
pbos@webrtc.org
0181b5f8dd ExternalVideoDecoder for new VideoEngine API.
Implements the ExternalVideoDecoder interface for VideoReceiveStream.
Also adds a FakeDecoder used in tests, removing the overhead of running
the EngineTest tests with VP8 under Memcheck/TSan, allowing us to enable
them under Memcheck/TSan as well.

BUG=2346,2312
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2172004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4702 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-09 08:26:30 +00:00
pbos@webrtc.org
7e1bf318bf Allow unknown flags in test_main.cc.
Adds AllowCommandLineParsing to allow us to ignore "--no-sandbox" given
by new TSanV2 bots. Not ignoring this flag prevents the test from
running on this machine. Also removing unnecessary asserts that clutter
code.

BUG=
TEST=Locally running video_engine_tests with --no-sandbox.
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2178004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4679 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-05 10:27:46 +00:00
pbos@webrtc.org
cb5118c14c Add FakeEncoder to VideoSendStream tests.
Breaks out config part of FakeEncoder from VideoSendStream tests to
FakeEncoder. Also sets FakeEncoder as encoder for VideoSendStream tests.
Anticipated speedup didn't happen as VP8 is still initialized by default
when creating channels in the old API. This will be sped up when moving
off the old API as VP8 won't be enabled by default.

BUG=2312
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2155004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4659 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-03 09:10:37 +00:00
pbos@webrtc.org
74fa4893f9 Remove newapi:: namespace for typenames without overlap.
Typing newapi:: everywhere is very verbose, and doesn't add any real
value. The new API is still separated from other code by being in
separate directories, such as internal/ or new_include.

BUG=
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2075004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4601 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-23 09:19:30 +00:00
pbos@webrtc.org
c095f510b6 Remove template usage of typeless enum in fake_encoder.
Removes clang warning preventing compile.

BUG=
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2087005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4593 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-22 12:34:58 +00:00
stefan@webrtc.org
360e376872 Adds two tests for verifying padding and ramp-up behavior.
BUG=1837
R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2073004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4591 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-22 09:29:56 +00:00
pbos@webrtc.org
4c96601aed Make FrameGeneratorCapturer own frame_generator.
Fixes memleaks where test::FrameGenerator::Create() was used to create
frame_generator, but it was never freed. Since the frame generator
shouldn't be used concurrently it's easiest if FrameGeneratorCapturer
take ownership of the instance.

BUG=
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2047005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4580 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-21 12:07:37 +00:00
phoglund@webrtc.org
abc1ed37c6 Merging video_full_stack_tests and video_engine_tests.
The reason is that we want to have as few test targets as possible to simplify bot configuration. It's also more convenient for developers since it will be trivial to introduce more perfing tests.

R=mflodman@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/2068004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4579 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-21 12:06:03 +00:00
pbos@webrtc.org
119a1ccdca VideoSendStream SSRC test.
Verifies that the VideoSendStream starts sending the set SSRC over RTP.

BUG=2227
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2074004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4573 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-20 13:14:07 +00:00
pbos@webrtc.org
d5f4c15e8f Added missing static_cast conversion.
BUG=
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2061004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4568 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-19 16:35:36 +00:00
pbos@webrtc.org
e7f056ec45 Implementation and testing of PLI in new API.
BUG=2174
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2011004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4567 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-19 16:09:34 +00:00
pbos@webrtc.org
fd39e13c80 Remove VideoEngine class from new VideoEngine API.
The VideoEngine class had minimal use, so it makes more sense to bake
its functionality and config into VideoCall for a simpler API. The only
thing the VideoEngine class could do was to create VideoCalls.

BUG=2224
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2020004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4543 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-14 13:52:52 +00:00
pbos@webrtc.org
468e19aa93 Signal when shutting down DirectTransport.
Avoids starting the network thread when there are no packets to be read.
This allows the transport to shut down directly, which makes tests using
it able to quit faster, and not have to wait up to 10ms.

BUG=
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2010004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4524 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-12 14:28:00 +00:00
pbos@webrtc.org
9668467d87 Run loopback tests with network thread.
Running with a network thread provides a more realistic simulation. Like
a real network, packets are handed off to a socket, or buffer, and then
the call returns. This prevents weird scenarios when both the sending
side and receiving side are on the call stack simultaneously, which can
cause deadlocks as locks could otherwise be taken simultaneously in both
the sender and receiver order by the same thread.

BUG=
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2000005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4522 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-12 12:59:04 +00:00
pbos@webrtc.org
12dc1a38ca Switch C++-style C headers with their C equivalents.
The C++ headers define the C functions within the std:: namespace, but
we mainly don't use the std:: namespace for C functions. Therefore we
should include the C headers.

BUG=1833
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1917004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4486 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-05 16:22:53 +00:00
pbos@webrtc.org
bbb07e69e5 Glue code and tests for NACK in new VideoEngine API.
The test works by randomly dropping small bursts of packets until enough
NACKs have been sent back by the receiver. Retransmitted packets are
never dropped in order to assure that all packets are eventually
delivered. When enough NACK packets have been received and all dropped
packets retransmitted, the test waits for the receiving side to send a
number of RTCP packets without NACK lists to assure that the receiving
side stops sending NACKs once packets have been retransmitted.

BUG=2043
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1934004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4482 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-05 12:01:36 +00:00
pbos@webrtc.org
69215d8432 Include files from webrtc/.. paths in video_engine/.
BUG=1662
R=holmer@google.com, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1759005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4324 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-10 15:02:02 +00:00
pbos@webrtc.org
adf23a55f8 Direct3D renderer for new VideoEngine API tests.
TEST=Rendered video in video_loopback test.
BUG=
R=stefan@webrtc.org, tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1573004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4323 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-10 14:07:56 +00:00
pbos@webrtc.org
f3f1358360 Fixed implicit-int-conversion bugs.
BUG=
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1776004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4313 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-09 14:04:46 +00:00
pbos@webrtc.org
af8d5afec9 Initial port of FullStackTest to new VideoEngine API.
Deferring network loss, delay and such to a later CL.

BUG=1872
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1756004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4310 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-09 08:02:33 +00:00
mflodman@webrtc.org
3ba883f0fc Removing functionality for inserting pre-encoded frames instead of raw
video frames. The functionality hasn't been used for a long time and
should be done properly if used in the future.

This is a pre-step for implementing CPU overload control.

R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1630004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4194 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-06-07 13:57:57 +00:00
pbos@webrtc.org
025f4f152b Stats+Config moved into VideoSend/ReceiveStreams.
BUG=
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1561006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4182 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-06-05 11:33:21 +00:00
pbos@webrtc.org
6998c8ef7a Remove XvRenderer.
One test renderer per platform is sufficient, multiple code paths are
bad.

BUG=
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1612004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4170 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-06-04 11:56:06 +00:00
pbos@webrtc.org
4213633a4d Use int for FPS instead of size_t.
BUG=
TBR=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1578005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4136 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-29 15:13:12 +00:00
pbos@webrtc.org
7bdfff3503 Remove assert for aborting FrameGeneratorCapturer.
BUG=
TBR=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1586004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4133 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-29 13:58:11 +00:00
pbos@webrtc.org
26d12105a4 Fake VideoCapturer based on FrameGenerator
BUG=1793
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1539004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4132 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-29 13:41:03 +00:00
pbos@webrtc.org
1ecee9a15a Break video_engine/new_include/common.h into smaller parts.
BUG=
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1571005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4128 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-29 11:34:32 +00:00
mflodman@webrtc.org
7f944f3027 Adding Mac test renderer, some test refactoring and made cpplint pass.
BUG=1667
TEST=Rendered video in Mac loopback test.
R=pbos@webrtc.org, xians@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1554004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4112 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-27 15:52:38 +00:00
pbos@webrtc.org
28556f5658 Make sure GlxRenderer frees its resources.
BUG=
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1544004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4098 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-24 10:54:56 +00:00
pbos@webrtc.org
d445d2229e CreateEmptyFrame casts from size_t to int.
BUG=
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1540004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4094 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-23 12:59:51 +00:00
pbos@webrtc.org
9b30348cfc FrameGenerator class for future fake capture device.
BUG=
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1511004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4093 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-23 12:37:11 +00:00
pbos@webrtc.org
771cdcbb09 Control new VideoEngine tests with gflags.
BUG=1703
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1497005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4092 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-23 12:20:16 +00:00
pbos@webrtc.org
375deb4e19 Suffix VcmCapturer's privates with underscore_
BUG=
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1506005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4076 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-21 09:32:22 +00:00
pbos@webrtc.org
f5d4cb1958 Include files from webrtc/.. paths in video_engine/
BUG=1662
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1492004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4056 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-17 13:44:48 +00:00
pbos@webrtc.org
29d5839233 New VideoEngine API implementation on top of old one, first steps.
BUG=1668
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1360004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4044 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-16 12:08:03 +00:00