admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
38,157 Commits 1 Branch 0 Tags
Commit Graph

278 Commits

Author SHA1 Message Date
Jeremy Leconte
2bd52fab82 Add Fuchsia on CQ and enable LKGR 
Change-Id: Ib4685630132ee25d702a6e325023e657a9fe4ed6
Bug: webrtc:14788,b/232740856
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/288381
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Andrey Logvin <landrey@google.com>
Cr-Commit-Position: refs/heads/main@{#38916}
 2022-12-19 10:00:14 +00:00
Björn Terelius
f00483206d Revert "Remove old Nexus perf bots" 
This reverts commit ec609b1cdd3ffd15c45445275899cf4010285399.

Reason for revert: Investigate whether the correct builder is used for Pixel devices

Original change's description:
> Remove old Nexus perf bots
>
> Bug: b/236797526
> Change-Id: I3a3b88fb29ef8a8df074ead975c785a0bfbc84a7
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/287700
> Reviewed-by: Jeremy Leconte <jleconte@google.com>
> Commit-Queue: Björn Terelius <terelius@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#38895}

Bug: b/236797526
Change-Id: I3ca98ddc9a336fb91eec48d54a94ddff19038366
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/288240
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Auto-Submit: Björn Terelius <terelius@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#38898}
 2022-12-15 12:44:07 +00:00
Björn Terelius
ec609b1cdd Remove old Nexus perf bots 
Bug: b/236797526
Change-Id: I3a3b88fb29ef8a8df074ead975c785a0bfbc84a7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/287700
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38895}
 2022-12-15 09:14:21 +00:00
Byoungchan Lee
26c2dee621 Let iOS bots run unittests with XCTest. 
When running Gtest-based tests, we use the WebRtcUnitTestDelegate
to call Gtest from the iOS application.
However, if tests take too long, iOS terminates that application.
The test execution code (ios/build/bots/scripts) retries up to three times,
but that functionality doesn't seem to work lately.
Because of this, module_unittests are failing at a fairly high rate.

Instead, use GoogleTestRunner to let XCTest run Gtest-based tests.
This is enabled with the --enable-run-ios-unittests-with-xctest flag,
which is passed when using the --xctest flag in ios/build/bots/scripts/run.py.
Existing XCTest-based tests (eg. sdk_unittest) are not affected
as the --xcode-parallelization flag takes precedence over --xctest.

Bug: None
Change-Id: Ib7f8a6d24f6b25444a47e3a83c0edbe96318be46
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/287180
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com>
Cr-Commit-Position: refs/heads/main@{#38859}
 2022-12-09 10:44:23 +00:00
Jeremy Leconte
6419537b3b [iOS sim] Run modules_unittests on 12 cores. 
Change-Id: If85ff709a55920cc914213edad5ed63826f6c5f3
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/287121
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38849}
 2022-12-08 13:43:23 +00:00
Junji Watanabe
53f3049588 [infra] Add Reclient shadow builders as experimental 
The reclient CQ builders work as expected.

https://ci.chromium.org/ui/p/webrtc/builders/try/android_arm_rel_reclient/14/overview
https://ci.chromium.org/ui/p/webrtc/builders/try/ios_compile_arm64_rel_reclient/11/overview
https://ci.chromium.org/ui/p/webrtc/builders/try/linux_rel_reclient/15/overview
https://ci.chromium.org/ui/p/webrtc/builders/try/mac_rel_reclient/12/overview
https://ci.chromium.org/ui/p/webrtc/builders/try/win_compile_x64_clang_rel_reclient/11/overview

This CL allows those builders run as part of CQ, but as experimental.

Setting `experiment_percentage` make the builders non-blocking.
See also https://chromium.googlesource.com/infra/luci/luci-go/+/HEAD/lucicfg/doc/README.md#luci.cq-tryjob-verifier-args

Considering the volume of WebRTC CQ, it's probably fine to shadow all builds to collect data quickly.
If it causes bot shortage, please decrease the percentage so that they don't always run.

Bug: b/243594984
Change-Id: Id9ab422c0d3e37c11e0d787f2fe6145c80c2f384
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/286760
Auto-Submit: Junji Watanabe <jwata@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38833}
 2022-12-07 08:35:37 +00:00
Byoungchan Lee
7970f87a37 Fix infra/specs/PRESUBMIT.py to not concatenate list to str 
Fixing errors like this:

Evaluation of CheckChangeOnCommit failed: can only concatenate str (not "list") to str, Traceback (most recent call last):
...
  File "/path/to/webrtc/src/infra/specs/PRESUBMIT.py", line 31, in CheckPatchFormatted
    results.append(output_api.PresubmitError('Error calling "' + cmd + '"'))
TypeError: can only concatenate str (not "list") to str

Bug: None
Change-Id: Ia0b1c7a80a2752934c02d932a9206114769bcaa1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/286547
Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com>
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38831}
 2022-12-06 21:29:47 +00:00
Byoungchan Lee
e4caacbfc3 Add default target to gn_isolate_map.pyl 
This is required to compile the default target in Android bots.

Bug: webrtc:14743
Change-Id: Ib8248e3d874b45eb59283f9503e07eadcd53bad7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/286545
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38830}
 2022-12-06 20:27:44 +00:00
Junji Watanabe
898403b0c9 Reland "Add reclient CQ shadow builders as experimental" 
This reverts commit 583fd2ba9961137d9b7df5e9fc917f6cc7c82e80.

Reason for revert: In the previous attempt, the shadow builders were blocking CQ.
In this reland, it sets cq=None instead of experimental=True so that they are not triggered automatically(?)
After confirming all builders work, I want to set cq to these builders, again. (ideally non-blocking builders.)

Original change's description:
> Revert "Add reclient CQ shadow builders as experimental"
>
> This reverts commit e149d4d1000424d897e72ea4ef7aa2b777842e8d.
>
> Reason for revert: Reason for revert: These builders seems blocking CQ.
> http://screen/44GuRKkhNHdwj8j
>
> Original change's description:
> > Add reclient CQ shadow builders as experimental
> >
> > FWIU, setting exprimental=True makes CQ builders non-blocking.
> > If not, please revert this CL.
> >
> > Bug: b/243594984
> > Change-Id: Ia20e37f4fe9ce629d6fddc9ab8b652b5b8a00572
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/286522
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > Auto-Submit: Junji Watanabe <jwata@google.com>
> > Commit-Queue: Junji Watanabe <jwata@google.com>
> > Cr-Commit-Position: refs/heads/main@{#38817}
>
> Bug: b/243594984
> Change-Id: Ie3dd7707a920c68c53cb80bf5f86737c7f559393
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/286543
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
> Auto-Submit: Junji Watanabe <jwata@google.com>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#38818}

Bug: b/243594984
Change-Id: I573124da0c63a56d9cdd81f637bc984487c98208
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/286544
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Junji Watanabe <jwata@google.com>
Cr-Commit-Position: refs/heads/main@{#38820}
 2022-12-06 09:00:58 +00:00
Junji Watanabe
583fd2ba99 Revert "Add reclient CQ shadow builders as experimental" 
This reverts commit e149d4d1000424d897e72ea4ef7aa2b777842e8d.

Reason for revert: Reason for revert: These builders seems blocking CQ.
http://screen/44GuRKkhNHdwj8j

Original change's description:
> Add reclient CQ shadow builders as experimental
>
> FWIU, setting exprimental=True makes CQ builders non-blocking.
> If not, please revert this CL.
>
> Bug: b/243594984
> Change-Id: Ia20e37f4fe9ce629d6fddc9ab8b652b5b8a00572
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/286522
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Auto-Submit: Junji Watanabe <jwata@google.com>
> Commit-Queue: Junji Watanabe <jwata@google.com>
> Cr-Commit-Position: refs/heads/main@{#38817}

Bug: b/243594984
Change-Id: Ie3dd7707a920c68c53cb80bf5f86737c7f559393
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/286543
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Junji Watanabe <jwata@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38818}
 2022-12-06 08:23:19 +00:00
Junji Watanabe
e149d4d100 Add reclient CQ shadow builders as experimental 
FWIU, setting exprimental=True makes CQ builders non-blocking.
If not, please revert this CL.

Bug: b/243594984
Change-Id: Ia20e37f4fe9ce629d6fddc9ab8b652b5b8a00572
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/286522
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Junji Watanabe <jwata@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
Cr-Commit-Position: refs/heads/main@{#38817}
 2022-12-06 07:49:54 +00:00
Christoffer Jansson
cf78b19a6f remove perf-output from Fuchsia perf 
Bug: b/232740856
Change-Id: I892911af7222e85c46089ba53b8b2c3328cc1872
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/286360
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Auto-Submit: Christoffer Jansson <jansson@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38812}
 2022-12-05 14:50:56 +00:00
Björn Terelius
737dc4455c Add new linux code coverage bot 
Bug: b/236797073
Change-Id: I7acd8cbe12c1fe7455db337515178e28dffda523
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285940
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38804}
 2022-12-04 14:13:50 +00:00
Jeremy Leconte
d0eaa54104 Reland "Add working Perf tests for Fuchsia" 
This is a reland of commit d8d86bd3329d05fdcc5402140917eb70b340c9c6

Original change's description:
> Add working Perf tests for Fuchsia
>
> Utilize VM in perf pool for Fuchsia (separate CL)
>
> Bug: b/232740856
> Change-Id: Ia69f72bbf2046db3bc9b1e5edabda6cc4a339fe6
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285721
> Reviewed-by: Jeremy Leconte <jleconte@google.com>
> Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#38787}

Bug: b/232740856
Change-Id: I3ae8b17990157bde4a08fd8a98379cffd2c38148
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285881
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38802}
 2022-12-02 20:35:28 +00:00
Jeremy Leconte
c8157c33b4 Add a column_limit=80 to yapf setup.cfg 
Also apply the formatting to the .pyl files.

Change-Id: I5dc668b53570d042862d2de5948b72d1cf6d31b3
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285941
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38797}
 2022-12-02 13:36:15 +00:00
Jeremy Leconte
cb885923d8 Revert "Add working Perf tests for Fuchsia" 
This reverts commit d8d86bd3329d05fdcc5402140917eb70b340c9c6.

Reason for revert: Seems this causes an issue with the dimensions ?
  File "/b/s/w/ir/kitchen-checkout/recipe_engine/recipe_modules/swarming/api.py", line 463, in with_dimensions
    assert isinstance(k, basestring) and (isinstance(v, basestring)

Original change's description:
> Add working Perf tests for Fuchsia
>
> Utilize VM in perf pool for Fuchsia (separate CL)
>
> Bug: b/232740856
> Change-Id: Ia69f72bbf2046db3bc9b1e5edabda6cc4a339fe6
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285721
> Reviewed-by: Jeremy Leconte <jleconte@google.com>
> Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#38787}

Bug: b/232740856
Change-Id: Ibedff26cfe38fae0eb36158d5cd9f2bdfded319f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285800
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Auto-Submit: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Jeremy Leconte <jleconte@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38790}
 2022-12-01 17:06:20 +00:00
Christoffer Jansson
d8d86bd332 Add working Perf tests for Fuchsia 
Utilize VM in perf pool for Fuchsia (separate CL)

Bug: b/232740856
Change-Id: Ia69f72bbf2046db3bc9b1e5edabda6cc4a339fe6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285721
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38787}
 2022-12-01 14:02:47 +00:00
Jeremy Leconte
21a9bbcf39 Disable Fuchsia perf tests. 
Change-Id: Iad6db19fa0ae3bd912ce072b161378e3e5db649a
Bug: b/232740856
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285662
Owners-Override: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38781}
 2022-11-30 18:23:29 +00:00
Jeremy Leconte
77bb688982 Disable tests again on 'Win32 Debug (Clang)'. 
module_unittests are failing with SEH exceptions.

Change-Id: Ic29def1d0f0c5976c1452e198cec2ee67dcaad9a
Bug: webrtc:14723
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285472
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38778}
 2022-11-30 16:39:33 +00:00
Jeremy Leconte
256d3ee2bf Specify the Windows version to run the CI tests. 
Change-Id: I2a9f1d266ef5fe4d1e43431964f44a1f995c7490
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285468
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38775}
 2022-11-30 14:21:57 +00:00
Jeremy Leconte
9665d01e69 Run tests on Windows CI for Release and Debug configuration. 
Currently the tests are running only on Windows x86 Release.
* Windows capture_tests are moved to run on x64.
* win_x64_clang_dbg_win10 is removed because it's a duplicate of * win_x64_clang_dbg.

Change-Id: Ibf4db1d1749aa31d665ad30825e9dcfef6910be4
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285540
Reviewed-by: Christoffer Jansson <jansson@google.com>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38772}
 2022-11-30 08:31:48 +00:00
Christoffer Jansson
a5e7941a57 Rename Win 7 to Win 10 to reflect whats being benchmarked 
Bug: None
Change-Id: If41eb2d47ee381afba66a9a62e1b7d9481df4efb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285465
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38763}
 2022-11-29 15:59:18 +00:00
Jeremy Leconte
693306cf7a Prevent 8 cores bots to be used by desktop perf tests. 
Change-Id: I2e2bc16ebc65f8207105d1dbd1a84788def5b63b
Bug: b/260684409
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285461
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38761}
 2022-11-29 14:21:30 +00:00
Jeremy Leconte
b4753d038e Clean up perf milo layout 
Change-Id: I1d14e0f57f176f787456c30ad2097be61db11d92
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285466
Auto-Submit: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38760}
 2022-11-29 14:12:11 +00:00
Christoffer Jansson
c06dc4df80 Add Fuchsia Perf bot 
Bug: b/232740856
Change-Id: I901c283262cc444f835a099a99ee9a6e09d6b759
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285442
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38758}
 2022-11-29 13:27:52 +00:00
Jeremy Leconte
ef7618a8f9 Run Android perf testers on more performant bots. 
Change-Id: I412d83beed78d887a974bf1d52c98814456b749f
Bug: b/260684409
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285441
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38754}
 2022-11-29 12:02:17 +00:00
Jeremy Leconte
370ca9c52c Enable sharding for fuchsia bots. 
* Add '--quick' argument to 'low_bandwidth_audio_test' even though it doesn't look like it makes much timing difference.
* Add sharding for 'svc_tests' and 'video_engine_tests'.

Change-Id: I6e3357954d18ad03ea9f62912dd77e0e1a74b97d
Bug: webrtc:14713
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285100
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38748}
 2022-11-28 19:39:08 +00:00
Christoffer Jansson
569af3e80f [Fuchsia] - Add more tests that pass locally 
Create bugs and add comments for failures.

Bug: b/232740856
Change-Id: Ic81477de73c3e848569dbd0c63c1a44542b90821
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285081
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#38744}
 2022-11-28 09:16:51 +00:00
Jeremy Leconte
c6ae33fb07 Replace dash by underscore in the command line argument before absl flag parsing. 
The expected behavior is to have something similar than python:
https://docs.python.org/dev/library/argparse.html#dest:
"Any internal - characters will be converted to _ characters to make sure the string is a valid attribute name".

This allows to catch chromium arguments like 'isolated-script-test-output' that previously needed some preprocessing done for example in flags_compatibility.py.

This CL also fixes a fuchsia specific issue where the test runner needs a 'isolated-script-test-output' argument but then pass the argument to WebRTC that expects a 'isolated_script_test_output' argument. Thus calling flags_compatibility before the test_runner fails and there is not much room to change the argument in between the test runner and the test.

Change-Id: I48a591743fa50484a0ec584a3f9e97d9e0fd25ef
Bug: webrtc:14694
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284541
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38707}
 2022-11-22 11:03:33 +00:00
Mirko Bonadei
41a0702886 Add new FYI bots to LKGR. 
Bug: b/259076774
Change-Id: I85fef09668f0f6323b9fa17c9527154804192658
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283980
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38671}
 2022-11-18 08:15:57 +00:00
Jeremy Leconte
cb2b133bf0 Ignore write-compiled-tests-json-to-writable-path flag. 
Change-Id: Ic084a9a1eb77bde1eda6439d7aafe1c208f0595d
Bug: webrtc:14677
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283761
Owners-Override: Jeremy Leconte <jleconte@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38654}
 2022-11-16 19:28:53 +00:00
Mirko Bonadei
b301b58b3f Rename CI Android testers. 
This makes it easier to update devices in th e future (avoiding multiple
CLs to change names, etc..).

Bug: b/259076774
Change-Id: I20ae940823978fbae84495d266345e4990184130
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283720
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38650}
 2022-11-16 15:38:21 +00:00
Jeremy Leconte
91e6987f66 Add a service account for the Android Perf bots. 
Change-Id: I02446fbca310a70172160d4bf345428413094bda
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283662
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38647}
 2022-11-16 13:20:14 +00:00
Jeremy Leconte
e085366aca Fix some minor issues with the android bots. 
* Use the same logdog_butler as Chromium instead of redefining one.
* Use luci-auth to prevent "local auth - HTTP 400" errors.

Change-Id: I2a0d1393f9f0e1e41b2bcc9a9fec2c50c19675f3
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283520
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38637}
 2022-11-16 09:09:25 +00:00
Mirko Bonadei
954cf1f853 Update mixins (copying ones removed by Chromium). 
Bug: None
Change-Id: I7fe81736c27d0d3091d24553cb8a17286bdb9c27
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283540
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38629}
 2022-11-15 16:47:30 +00:00
Mirko Bonadei
76bd5a80ea Migrate WebRTC postsubmit to Walleye (from Bullhead). 
Bug: b/259076774
Change-Id: I9237a454bf88427bc03f8e4d801c126b259a2231
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283460
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38628}
 2022-11-15 16:10:55 +00:00
Mirko Bonadei
31364615d7 Migrate WebRTC presubmit to Walleye (from Bullhead). 
No-Try: True
Bug: b/259076774
Change-Id: I87fdd2ca27f1f3774c0aee68680ae68afd8e59c6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283440
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38618}
 2022-11-14 16:37:40 +00:00
Christoffer Jansson
f1fa7058b6 Add Fuchsia mixin, disable unsupported absl calls for fuchsia 
Add a few tests to get started on debugging.

The goal of this CL is to get the Fuchsia bots running the tests without infra specific issues. After landing this, failures will be in test framework files (e.g. test/testsupport folder) and WebRTC code.

Bug: b/232740856
Change-Id: I332607fe875334769e7dadf6696d878a23a7e69f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/280440
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Reviewed-by: Andrey Logvin <landrey@google.com>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38596}
 2022-11-09 16:36:05 +00:00
Jeremy Leconte
d957836794 Use gtest_parallel for PipeWire tests. 
This CL will also make PipeWire tests retried 3 times in case of failures.

Change-Id: I9c66351f7ee171e29266fe4b8dcd52ca282c8f6d
Bug: webrtc:14644
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282820
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38595}
 2022-11-09 15:37:58 +00:00
Christoffer Jansson
119fb1910a Add Pixel2 and Pixel5 arm32 perf tester 
Bug: b/257916734
Change-Id: I733e3d451daa47fa25d370f5d2fff7c9b1f5b8db
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282560
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38584}
 2022-11-08 12:44:18 +00:00
landrey
822794d491 Ignore write-compiled-tests-json-to-writable-path flag 
This flag is passed by default in chromium after https://crrev.com/c/3953676

Bug: b/257915522
Change-Id: If3518fa86f3e05ad02bfad8f200b17958f78602d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282225
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Commit-Queue: Andrey Logvin <landrey@google.com>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Auto-Submit: Andrey Logvin <landrey@google.com>
Cr-Commit-Position: refs/heads/main@{#38581}
 2022-11-08 11:31:12 +00:00
Jeremy Leconte
6a1320c2c0 Disable pipewire tests on sanitizer bots. 
Change-Id: Ib3f06c3c4c64b918b59a02ac67fcea2e2b45112b
Bug: webrtc:14644
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282600
Reviewed-by: Andrey Logvin <landrey@google.com>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38580}
 2022-11-08 11:22:41 +00:00
Christoffer Jansson
5600fe5bed Python3 for infra/config presubmit 
Bug: webrtc:13607
Change-Id: I6a949fceb87309f0496e62fbe661b740f0b40aae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282422
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38578}
 2022-11-08 10:14:54 +00:00
Andrey Logvin
b456788d44 Revert "Temporarily remove android bots from CQ" 
This reverts commit c560d560a2e5e38b929537f04be9ce13e601c891.

Reason for revert: To see if the slowness is gone

Original change's description:
> Temporarily remove android bots from CQ
>
> They are consistently timing out and harming productivity.
>
> No-Try: True
> Bug: b/257964487
> Change-Id: I66e38aac60ffcb0547f371cd323276c81e7c86af
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282321
> Commit-Queue: Andrey Logvin <landrey@google.com>
> Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
> Auto-Submit: Andrey Logvin <landrey@google.com>
> Cr-Commit-Position: refs/heads/main@{#38567}

Bug: b/257964487
Change-Id: I33218a88ca404fc4f4d96249b81772405b58456e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282540
Auto-Submit: Andrey Logvin <landrey@google.com>
Owners-Override: Andrey Logvin <landrey@google.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Andrey Logvin <landrey@google.com>
Cr-Commit-Position: refs/heads/main@{#38575}
 2022-11-08 08:18:46 +00:00
landrey
c560d560a2 Temporarily remove android bots from CQ 
They are consistently timing out and harming productivity.

No-Try: True
Bug: b/257964487
Change-Id: I66e38aac60ffcb0547f371cd323276c81e7c86af
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282321
Commit-Queue: Andrey Logvin <landrey@google.com>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Auto-Submit: Andrey Logvin <landrey@google.com>
Cr-Commit-Position: refs/heads/main@{#38567}
 2022-11-07 16:02:48 +00:00
Christoffer Jansson
ddae5e6fae Add Pixel5 perf config 
Bug: b/257916734
Change-Id: I7a9fc7db85cf7742b7de0ce4c2dc4d25548050f2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282220
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38566}
 2022-11-07 15:50:51 +00:00
landrey
adc5dfe515 Remove Nexus5X builder from LKGR 
The builder is blocking Webrtc to Chromium roll. Nexus5X phones are going to be replaced with Pixels soon anyway. So there is no reason in trying to fix the bot now. Especially since it fails with infrastructure issus: `Failure [INSTALL_FAILED_OLDER_SDK]`

Bug: b/257742011
Change-Id: Id346663f35bcc5089c314d42c2724952dab658e5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282224
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Auto-Submit: Andrey Logvin <landrey@google.com>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Andrey Logvin <landrey@google.com>
Cr-Commit-Position: refs/heads/main@{#38562}
 2022-11-07 12:49:20 +00:00
Björn Terelius
67416b51e4 Reenable mac_rel on CQ 
Bug: webrtc:13275
Change-Id: I0dd7beddf31a61d80b3e6e7868692baffc29fbb4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/281361
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38537}
 2022-11-02 15:00:39 +00:00
Björn Terelius
8da318589b Temporarily remove mac_rel from CQ 
Bug: webrtc:13275
Change-Id: Id3a61106e154d9b55680199bcbd450ba2f2fba7d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/281180
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38508}
 2022-10-31 14:51:25 +00:00
Jeremy Leconte
bbd5fbf4f5 [iOS] Run SVC tests on 12 cores machines 
Change-Id: I8e8bda835504ac1440c7d65bfc62ecbb619fce54
Bug: None
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/281161
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Auto-Submit: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38504}
 2022-10-31 11:12:21 +00:00