Mirko Bonadei
5f4d47b0c0
Revert "Reland "Enable any address ports by default.""
...
This reverts commit b89ac622f3f5a7bb065a08cb1efba10a0e8cae23.
Reason for revert: Speculative revert.
Original change's description:
> Reland "Enable any address ports by default."
>
> This reverts commit 1165949341b6f61c5d728999bfbdaf68fd5c15aa.
>
> Reason for revert: Speculative reland (the revert breaks a downstream project).
>
> Original change's description:
> > Revert "Reland "Enable any address ports by default.""
> >
> > This reverts commit ac5bbd940ed31f8a58095952f4dcdcbb1b58203c.
> >
> > Reason for revert: Speculative revert, possibly breaking downstream projects
> >
> > Original change's description:
> > > Reland "Enable any address ports by default."
> > >
> > > This reverts commit 056a68da896d9a578b9ea83e56d261648ea0adc6.
> > >
> > > Reason for revert: Trying to reland.
> > >
> > > Original change's description:
> > > > Revert "Enable any address ports by default."
> > > >
> > > > This reverts commit f04148c810aad2a0809dc8978650c55308381c47.
> > > >
> > > > Reason for revert: Speculative revert. I suspect this is breaking a
> > > > downstream test (I'll reland if it is not the culprit).
> > > >
> > > > Original change's description:
> > > > > Enable any address ports by default.
> > > > >
> > > > > Ports not bound to any specific network interface are allocated by
> > > > > default. These any address ports are pruned after allocation,
> > > > > conditional on the allocation results of normal ports that are bound to
> > > > > the enumerated interfaces.
> > > > >
> > > > > Bug: webrtc:9313
> > > > > Change-Id: I3ce12eeab0cf3547224e5f8c188d061fc530e145
> > > > > Reviewed-on: https://webrtc-review.googlesource.com/78383
> > > > > Commit-Queue: Qingsi Wang <qingsi@google.com>
> > > > > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
> > > > > Cr-Commit-Position: refs/heads/master@{#23673}
> > > >
> > > > TBR=deadbeef@webrtc.org ,pthatcher@webrtc.org,qingsi@google.com
> > > >
> > > > Change-Id: I3b3dc42c7de46d198d4b9c270020dcf1100dd907
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Bug: webrtc:9313
> > > > Reviewed-on: https://webrtc-review.googlesource.com/84300
> > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> > > > Cr-Commit-Position: refs/heads/master@{#23678}
> > >
> > > TBR=deadbeef@webrtc.org ,mbonadei@webrtc.org,pthatcher@webrtc.org,qingsi@google.com
> > >
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > >
> > > Bug: webrtc:9313
> > > Change-Id: I98442346babb5d8953d37dc5825efaf79804ed7f
> > > Reviewed-on: https://webrtc-review.googlesource.com/85000
> > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > > Commit-Queue: Qingsi Wang <qingsi@webrtc.org>
> > > Cr-Commit-Position: refs/heads/master@{#23720}
> >
> > TBR=deadbeef@webrtc.org ,mbonadei@webrtc.org,pthatcher@webrtc.org,qingsi@google.com,qingsi@webrtc.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: webrtc:9313
> > Change-Id: Ie5da4133a371532f717af144f183e299e759f152
> > Reviewed-on: https://webrtc-review.googlesource.com/95340
> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > Reviewed-by: Qingsi Wang <qingsi@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#24374}
>
> TBR=deadbeef@webrtc.org ,mbonadei@webrtc.org,pthatcher@webrtc.org,qingsi@google.com,qingsi@webrtc.org
>
> Change-Id: I52bf487d441ce8ccedee7e348b9ed9ade0fd9d1c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:9313
> Reviewed-on: https://webrtc-review.googlesource.com/95440
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#24379}
TBR=deadbeef@webrtc.org ,mbonadei@webrtc.org,pthatcher@webrtc.org,qingsi@google.com,qingsi@webrtc.org
Change-Id: I6db41f092c55be74f6594eb729ad5f15c718fe34
Bug: webrtc:9313
Reviewed-on: https://webrtc-review.googlesource.com/95520
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24412}
2018-08-23 18:52:49 +00:00
Mirko Bonadei
b89ac622f3
Reland "Enable any address ports by default."
...
This reverts commit 1165949341b6f61c5d728999bfbdaf68fd5c15aa.
Reason for revert: Speculative reland (the revert breaks a downstream project).
Original change's description:
> Revert "Reland "Enable any address ports by default.""
>
> This reverts commit ac5bbd940ed31f8a58095952f4dcdcbb1b58203c.
>
> Reason for revert: Speculative revert, possibly breaking downstream projects
>
> Original change's description:
> > Reland "Enable any address ports by default."
> >
> > This reverts commit 056a68da896d9a578b9ea83e56d261648ea0adc6.
> >
> > Reason for revert: Trying to reland.
> >
> > Original change's description:
> > > Revert "Enable any address ports by default."
> > >
> > > This reverts commit f04148c810aad2a0809dc8978650c55308381c47.
> > >
> > > Reason for revert: Speculative revert. I suspect this is breaking a
> > > downstream test (I'll reland if it is not the culprit).
> > >
> > > Original change's description:
> > > > Enable any address ports by default.
> > > >
> > > > Ports not bound to any specific network interface are allocated by
> > > > default. These any address ports are pruned after allocation,
> > > > conditional on the allocation results of normal ports that are bound to
> > > > the enumerated interfaces.
> > > >
> > > > Bug: webrtc:9313
> > > > Change-Id: I3ce12eeab0cf3547224e5f8c188d061fc530e145
> > > > Reviewed-on: https://webrtc-review.googlesource.com/78383
> > > > Commit-Queue: Qingsi Wang <qingsi@google.com>
> > > > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
> > > > Cr-Commit-Position: refs/heads/master@{#23673}
> > >
> > > TBR=deadbeef@webrtc.org ,pthatcher@webrtc.org,qingsi@google.com
> > >
> > > Change-Id: I3b3dc42c7de46d198d4b9c270020dcf1100dd907
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: webrtc:9313
> > > Reviewed-on: https://webrtc-review.googlesource.com/84300
> > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> > > Cr-Commit-Position: refs/heads/master@{#23678}
> >
> > TBR=deadbeef@webrtc.org ,mbonadei@webrtc.org,pthatcher@webrtc.org,qingsi@google.com
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: webrtc:9313
> > Change-Id: I98442346babb5d8953d37dc5825efaf79804ed7f
> > Reviewed-on: https://webrtc-review.googlesource.com/85000
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > Commit-Queue: Qingsi Wang <qingsi@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#23720}
>
> TBR=deadbeef@webrtc.org ,mbonadei@webrtc.org,pthatcher@webrtc.org,qingsi@google.com,qingsi@webrtc.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: webrtc:9313
> Change-Id: Ie5da4133a371532f717af144f183e299e759f152
> Reviewed-on: https://webrtc-review.googlesource.com/95340
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Qingsi Wang <qingsi@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#24374}
TBR=deadbeef@webrtc.org ,mbonadei@webrtc.org,pthatcher@webrtc.org,qingsi@google.com,qingsi@webrtc.org
Change-Id: I52bf487d441ce8ccedee7e348b9ed9ade0fd9d1c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9313
Reviewed-on: https://webrtc-review.googlesource.com/95440
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24379}
2018-08-22 08:26:31 +00:00
Qingsi Wang
1165949341
Revert "Reland "Enable any address ports by default.""
...
This reverts commit ac5bbd940ed31f8a58095952f4dcdcbb1b58203c.
Reason for revert: Speculative revert, possibly breaking downstream projects
Original change's description:
> Reland "Enable any address ports by default."
>
> This reverts commit 056a68da896d9a578b9ea83e56d261648ea0adc6.
>
> Reason for revert: Trying to reland.
>
> Original change's description:
> > Revert "Enable any address ports by default."
> >
> > This reverts commit f04148c810aad2a0809dc8978650c55308381c47.
> >
> > Reason for revert: Speculative revert. I suspect this is breaking a
> > downstream test (I'll reland if it is not the culprit).
> >
> > Original change's description:
> > > Enable any address ports by default.
> > >
> > > Ports not bound to any specific network interface are allocated by
> > > default. These any address ports are pruned after allocation,
> > > conditional on the allocation results of normal ports that are bound to
> > > the enumerated interfaces.
> > >
> > > Bug: webrtc:9313
> > > Change-Id: I3ce12eeab0cf3547224e5f8c188d061fc530e145
> > > Reviewed-on: https://webrtc-review.googlesource.com/78383
> > > Commit-Queue: Qingsi Wang <qingsi@google.com>
> > > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
> > > Cr-Commit-Position: refs/heads/master@{#23673}
> >
> > TBR=deadbeef@webrtc.org ,pthatcher@webrtc.org,qingsi@google.com
> >
> > Change-Id: I3b3dc42c7de46d198d4b9c270020dcf1100dd907
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: webrtc:9313
> > Reviewed-on: https://webrtc-review.googlesource.com/84300
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#23678}
>
> TBR=deadbeef@webrtc.org ,mbonadei@webrtc.org,pthatcher@webrtc.org,qingsi@google.com
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: webrtc:9313
> Change-Id: I98442346babb5d8953d37dc5825efaf79804ed7f
> Reviewed-on: https://webrtc-review.googlesource.com/85000
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Qingsi Wang <qingsi@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#23720}
TBR=deadbeef@webrtc.org ,mbonadei@webrtc.org,pthatcher@webrtc.org,qingsi@google.com,qingsi@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:9313
Change-Id: Ie5da4133a371532f717af144f183e299e759f152
Reviewed-on: https://webrtc-review.googlesource.com/95340
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Qingsi Wang <qingsi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24374}
2018-08-22 07:24:40 +00:00
Mirko Bonadei
ac5bbd940e
Reland "Enable any address ports by default."
...
This reverts commit 056a68da896d9a578b9ea83e56d261648ea0adc6.
Reason for revert: Trying to reland.
Original change's description:
> Revert "Enable any address ports by default."
>
> This reverts commit f04148c810aad2a0809dc8978650c55308381c47.
>
> Reason for revert: Speculative revert. I suspect this is breaking a
> downstream test (I'll reland if it is not the culprit).
>
> Original change's description:
> > Enable any address ports by default.
> >
> > Ports not bound to any specific network interface are allocated by
> > default. These any address ports are pruned after allocation,
> > conditional on the allocation results of normal ports that are bound to
> > the enumerated interfaces.
> >
> > Bug: webrtc:9313
> > Change-Id: I3ce12eeab0cf3547224e5f8c188d061fc530e145
> > Reviewed-on: https://webrtc-review.googlesource.com/78383
> > Commit-Queue: Qingsi Wang <qingsi@google.com>
> > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#23673}
>
> TBR=deadbeef@webrtc.org ,pthatcher@webrtc.org,qingsi@google.com
>
> Change-Id: I3b3dc42c7de46d198d4b9c270020dcf1100dd907
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:9313
> Reviewed-on: https://webrtc-review.googlesource.com/84300
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#23678}
TBR=deadbeef@webrtc.org ,mbonadei@webrtc.org,pthatcher@webrtc.org,qingsi@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:9313
Change-Id: I98442346babb5d8953d37dc5825efaf79804ed7f
Reviewed-on: https://webrtc-review.googlesource.com/85000
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Qingsi Wang <qingsi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23720}
2018-06-22 17:27:34 +00:00
Mirko Bonadei
056a68da89
Revert "Enable any address ports by default."
...
This reverts commit f04148c810aad2a0809dc8978650c55308381c47.
Reason for revert: Speculative revert. I suspect this is breaking a
downstream test (I'll reland if it is not the culprit).
Original change's description:
> Enable any address ports by default.
>
> Ports not bound to any specific network interface are allocated by
> default. These any address ports are pruned after allocation,
> conditional on the allocation results of normal ports that are bound to
> the enumerated interfaces.
>
> Bug: webrtc:9313
> Change-Id: I3ce12eeab0cf3547224e5f8c188d061fc530e145
> Reviewed-on: https://webrtc-review.googlesource.com/78383
> Commit-Queue: Qingsi Wang <qingsi@google.com>
> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#23673}
TBR=deadbeef@webrtc.org ,pthatcher@webrtc.org,qingsi@google.com
Change-Id: I3b3dc42c7de46d198d4b9c270020dcf1100dd907
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9313
Reviewed-on: https://webrtc-review.googlesource.com/84300
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23678}
2018-06-20 07:53:30 +00:00
Qingsi Wang
f04148c810
Enable any address ports by default.
...
Ports not bound to any specific network interface are allocated by
default. These any address ports are pruned after allocation,
conditional on the allocation results of normal ports that are bound to
the enumerated interfaces.
Bug: webrtc:9313
Change-Id: I3ce12eeab0cf3547224e5f8c188d061fc530e145
Reviewed-on: https://webrtc-review.googlesource.com/78383
Commit-Queue: Qingsi Wang <qingsi@google.com>
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23673}
2018-06-20 04:22:23 +00:00
Steve Anton
eae3e65394
Enable the clang style plugin for the stunprober target
...
Bug: webrtc:163
Change-Id: I77c92dfc05626cb5e83d4e93d735c1370ed4af23
Reviewed-on: https://webrtc-review.googlesource.com/15783
Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org>
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20435}
2017-10-26 04:40:25 +00:00
Mirko Bonadei