16 Commits

Author SHA1 Message Date
tommi@webrtc.org
c4709a2930 Split C++ class from macro overrides to fix Chromium build
BUG=chromium:468375
TBR=kjellander@webrtc.org,ajm@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/51409004

Cr-Commit-Position: refs/heads/master@{#8786}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8786 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-19 07:26:21 +00:00
tommi@webrtc.org
f696e49c9a Re-landing perf improvement for libjingle logging after reverting the general change.
This contains only a part of r8635 that I just reverted to unblock the roll.

TBR=perkj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/42259004

Cr-Commit-Position: refs/heads/master@{#8643}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8643 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-07 12:18:14 +00:00
tommi@webrtc.org
52130b6412 Revert 8635 "Make LS_ logging constants to match Chromium's logg..."
LibjingleLoggingTests in Chromium started failing so more thought needs to be applied here.
Would be good to get he perf improvement in though.

> Make LS_ logging constants to match Chromium's logging constants when building with Chrome.
> This was causing logging to be done at incorrect levels and filters not work as expected.
> 
> R=perkj@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/40239004

TBR=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/43649004

Cr-Commit-Position: refs/heads/master@{#8642}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8642 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-07 12:09:40 +00:00
tommi@webrtc.org
66f153f89f Make LS_ logging constants to match Chromium's logging constants when building with Chrome.
This was causing logging to be done at incorrect levels and filters not work as expected.

R=perkj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/40239004

Cr-Commit-Position: refs/heads/master@{#8635}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8635 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-06 15:56:46 +00:00
aluebs@webrtc.org
30142bbe07 Add arraysize to overrides to avoid macros redefinitions in Chromium
This fixes the Webrtc in Chrome FYI bots breaking.

TBR=ajm

Review URL: https://webrtc-codereview.appspot.com/36149004

Cr-Commit-Position: refs/heads/master@{#8371}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8371 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-14 02:46:13 +00:00
andresp@webrtc.org
ff689be3c0 Use std::min and std::max instead of self-defined functions such as rtc::_min/_max.
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/35079004

Cr-Commit-Position: refs/heads/master@{#8347}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8347 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-12 11:55:32 +00:00
andresp@webrtc.org
53d9012faf Clean kForever from basictypes and move it to the interfaces that actually have it.
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/33269004

Cr-Commit-Position: refs/heads/master@{#8296}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8296 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-09 14:19:39 +00:00
kwiberg@webrtc.org
2ebfac5649 Remove COMPILE_ASSERT and use static_assert everywhere
COMPILE_ASSERT is no longer needed now that we have C++11's
static_assert.

R=aluebs@webrtc.org, andrew@webrtc.org, hellner@chromium.org, henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/39469004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@8058 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-14 10:51:54 +00:00
pbos@webrtc.org
e728ee03ba Remove or rename typedefs with _t prefixes.
_t prefixes are reserved for additional typenames in POSIX.

R=henrik.lundin@webrtc.org, hta@webrtc.org, stefan@webrtc.org
BUG=162

Review URL: https://webrtc-codereview.appspot.com/36559004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7931 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-17 13:43:55 +00:00
pbos@webrtc.org
dc8dcb4b8c Narrower include for constructormagic.h in Chromium.
Replacing #include of "base/basictypes.h" in
overrides/webrtc/base/constructormagic.h with "base/macros.h". Our
version of constructormagic.h is not meant to include the base types,
only DISALLOW_COPY_AND_ASSIGN etc.

This fix is also a workaround for our overrides in Chromium seemingly
including the wrong things for certain webrtc targets like
audio_processing, so it looks like this #include "base/basictypes.h"
didn't include Chromium's base/basictypes.h but webrtc/base/basictypes.h
somehow, hence DISALLOW_COPY_AND_ASSIGN wasn't defined, causing the
revert in r7151.

R=henrike@webrtc.org, tommi@webrtc.org
BUG=3070
TEST=Chromium still builds locally with this change.

Review URL: https://webrtc-codereview.appspot.com/27509004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7204 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-17 07:44:33 +00:00
glaznev@webrtc.org
ab7073a1e8 Partial implementation of rtc::LogMessage in chromium overrides.
rtc::LogMessage::LogToDebug used in peerconnection_jni.cc.

BUG=https://crbug.com/412276
R=glaznev@webrtc.org, niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/25459004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7186 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-15 19:16:21 +00:00
henrike@webrtc.org
a148704b4b Rename webrtc/base's IS_ALIGNED macro to RTC_IS_ALIGNED to avoid conflict between webrtc/base/basictypes.h and third_party/.../vpx_codec.h.
BUG=3380
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/17579005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6215 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-21 16:52:14 +00:00
pbos@webrtc.org
6aeeac95ca Fix Windows debug compile of overrides/ logging.
Compile error detected when trying to roll to chromium. Adding a cast
of base::PlatformThread::CurrentId() to base::subtle::Atomic32 to match
types in DCHECK_EQ().

See logging.cc error in:
http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_dbg/builds/19944/steps/compile%20%28with%20patch%29/logs/stdio

R=mflodman@webrtc.org, perkj@webrtc.org
TBR=henrike@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/17529004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6173 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-15 13:56:56 +00:00
henrike@webrtc.org
f048872e91 Adds a modified copy of talk/base to webrtc/base. It is the first step in
migrating talk/base to webrtc/base.

BUG=N/A
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/17479005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
perkj@webrtc.org
e9a604accd Revert 6107 "Adds a modified copy of talk/base to webrtc/base. I..."
This breaks Chromium FYI builds and prevent roll of webrtc/libjingle to Chrome.

http://chromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win%20Builder/builds/457


> Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base.
> 
> BUG=N/A
> R=andrew@webrtc.org, wu@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/12199004

TBR=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14479004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6116 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 08:15:48 +00:00
henrike@webrtc.org
2c7d1b39b9 Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base.
BUG=N/A
R=andrew@webrtc.org, wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12199004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6107 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-12 18:03:09 +00:00