This makes it easier to update devices in th e future (avoiding multiple
CLs to change names, etc..).
Bug: b/259076774
Change-Id: I20ae940823978fbae84495d266345e4990184130
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283720
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38650}
* Use the same logdog_butler as Chromium instead of redefining one.
* Use luci-auth to prevent "local auth - HTTP 400" errors.
Change-Id: I2a0d1393f9f0e1e41b2bcc9a9fec2c50c19675f3
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283520
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38637}
This CL will also make PipeWire tests retried 3 times in case of failures.
Change-Id: I9c66351f7ee171e29266fe4b8dcd52ca282c8f6d
Bug: webrtc:14644
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282820
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38595}
Linux Debug (ARM) builder is still using Goma.
https://ci.chromium.org/ui/p/webrtc/builders/ci/Linux32%20Debug%20(ARM)/18995/overview
`Override MB config to use reclient` step fails to replace use_goma=true with use_remoteexec=true because there is no use_goma=true in this builder's mb config.
I don't know why the builder uses Goma without use_goma=true.
But, maybe this is due to the default setting or some recipe logic.
Bug: b:239908030
Change-Id: Iabf0c857144769e842c5f4080fe01339841d8c0c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/281820
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Auto-Submit: Junji Watanabe <jwata@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
Cr-Commit-Position: refs/heads/main@{#38550}
Also run IWYU on a file picked for testing and check in the result.
Bug: none
Change-Id: Ide36bc59d126064f2bab7af441f72a6e8477c848
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/280601
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38481}
Command [1] on openssl 1.1.1m and newer generates output
containing "unsigned char the_(subject_name|public_key|certificate)"
records, making it incompatible with current version of the script
that relies on "unsigned char XXX_".
This patch handles both cases by using regular expression so as
to match strings and provide an adequate replacement.
[1] - openssl x509 -in <path-to-cacert.pem> -noout -C
Bug: webrtc:11710
Change-Id: I46b87d2980ec2dd26660b93fcf9019254950ce12
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257420
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38173}
This is required to restore a lot of Windows bots that are failing to
compile after the attempt to roll libc++.
Bug: None
Change-Id: Id9f9dba0a529eddae7edd3fc56e73b453ef2acd0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/275120
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38058}
All CI builders on Linux with standlone.py recipe have already been migrated to reclient.
This is the only remaining Linux builder with libfuzzer.py recipe.
Test:
[pass] https://ci.chromium.org/swarming/task/5d4962978d596a10
Bug: b/239908030
Change-Id: I861ded5672f2296f61d42b1f4678cd5602d50030
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/275061
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Junji Watanabe <jwata@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Takuto Ikuta <tikuta@google.com>
Cr-Commit-Position: refs/heads/main@{#38057}
When working within chromium, we need to move up two more levels before
we can import the "find_depot_tools" module. Previously this was
managed by a loop that kept moving up until it found a directory named
'src', but this didn't work if the base-level webrtc code was not in
a directory named 'src'.
Bug: webrtc:14411
Change-Id: I2729603d6d2fd8242a1294ae5d95d946db619d0a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273561
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37971}
According to Xcode 14 documentation [1]:
> Xcode no longer builds bitcode by default and generates a warning
> message if a project explicitly enables bitcode: “Building with
> bitcode is deprecated. Please update your project and/or target
> settings to disable bitcode.” The capability to build with bitcode
> will be removed in a future Xcode release. IPAs that contain bitcode
> will have the bitcode stripped before being submitted to the App
> Store. Debug symbols for past bitcode submissions remain available
> for download. (86118779)
[1]: https://developer.apple.com/documentation/Xcode-Release-Notes/xcode-14-release-notes
Bug: webrtc:14237
Change-Id: I39fb618409e1978f8e7b42aa71208e00ed69d85f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267407
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#37415}
The styleguide prefers using condensed library nam "foo" instead of
"foo:foo" whenever possible. The script would address absolute and
relative paths in other directories but not the ones in the current
directory.
Bug: None
Change-Id: Ibc7850cd26edfe8fb864ce5baa2f460a95a7c96d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266489
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37315}
The recent change in chromium, libevent, was moved from
base/third_party to third_party. While GN build works by transient GN
build targets, building an android archive does not work because it
requires libevent's license file in the specific path.
To unblock autoroller, temporarily make generate_license.py work with
non-existing paths.
Bug: chromium:1335194
Change-Id: Icb79a27c4c41f603e5ffc9170f4ecb7440ec9e29
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266520
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com>
Cr-Commit-Position: refs/heads/main@{#37307}
Since the Perf tester is actually compiling histogram code, it needs
to have it's own native OS gclient and GN config. The Builder has already
built and cached the MacOS arm64 binaries to be tested for M1.
I got confused and thought the tester was also compiling something for
the bot it shards to.
Bug: b/232347569
Change-Id: I0468945a04905d2d647626229af77c00d1f632fd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/263200
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36969}
This is a follow up of this CL: https://crrev.com/c/3611486.
Bug: b/231404336
Change-Id: I3b6f4b780aa1939b6b2d0f1d08d1746a3a6f86dc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261080
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36752}
