47 Commits

Author SHA1 Message Date
Mirko Bonadei
08574aeb44 Revert "Reland "Switch from "rtc_ios_xctest_test" to "rtc_test".""
This reverts commit 60c25a303fac85dccb2ccdd9e8d6d71be13b7541.

Reason for revert: Breaks downstream iOS testers.
From an offline discussion, the GN argument is not needed and only
the 3 xctest needs the behavior of that argument. So I am reverting
this one and preparing 2 CLs to properly fix.

Original change's description:
> Reland "Switch from "rtc_ios_xctest_test" to "rtc_test"."
>
> This is a reland of 7a73c772e21983857e46cb4fcedc6cfa3f42c03e
>
> The change to fix the downstream issue is just the switch from
> "test" to "rtc_test" which is a GN template that expands to
> "test".
>
> Original change's description:
> > Switch from "rtc_ios_xctest_test" to "test".
> >
> > Using the "test" GN template instead of the "ios_xctest_test" one we
> > will get iOS support for isolates via MB and GN for free, making it
> > easier to migrate the iOS recipe and fix bugs.webrtc.org/11604.
> >
> > Bug: webrtc:11881
> > Change-Id: I72b90f8494c473fa567e6296caf7a771e4caba92
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/182680
> > Reviewed-by: Dirk Pranke <dpranke@google.com>
> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#32064}
>
> Bug: webrtc:11881
> Change-Id: Ia5338859f4e893b9f19bcca6b26b8cf66d5984e8
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183766
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Cr-Commit-Position: refs/heads/master@{#32075}

TBR=mbonadei@webrtc.org,dpranke@google.com,jeffyoon@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: webrtc:11881, webrtc:11937
Change-Id: Ie6eea6b2a8ba5c46af40b115c6db4fd0a38a25b0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184340
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32112}
2020-09-16 09:17:42 +00:00
Mirko Bonadei
60c25a303f Reland "Switch from "rtc_ios_xctest_test" to "rtc_test"."
This is a reland of 7a73c772e21983857e46cb4fcedc6cfa3f42c03e

The change to fix the downstream issue is just the switch from
"test" to "rtc_test" which is a GN template that expands to
"test".

Original change's description:
> Switch from "rtc_ios_xctest_test" to "test".
>
> Using the "test" GN template instead of the "ios_xctest_test" one we
> will get iOS support for isolates via MB and GN for free, making it
> easier to migrate the iOS recipe and fix bugs.webrtc.org/11604.
>
> Bug: webrtc:11881
> Change-Id: I72b90f8494c473fa567e6296caf7a771e4caba92
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/182680
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#32064}

Bug: webrtc:11881
Change-Id: Ia5338859f4e893b9f19bcca6b26b8cf66d5984e8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183766
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#32075}
2020-09-10 20:03:34 +00:00
Mirko Bonadei
fb39998140 Revert "Switch from "rtc_ios_xctest_test" to "test"."
This reverts commit 7a73c772e21983857e46cb4fcedc6cfa3f42c03e.

Reason for revert: Breaks downstream test.

Original change's description:
> Switch from "rtc_ios_xctest_test" to "test".
> 
> Using the "test" GN template instead of the "ios_xctest_test" one we
> will get iOS support for isolates via MB and GN for free, making it
> easier to migrate the iOS recipe and fix bugs.webrtc.org/11604.
> 
> Bug: webrtc:11881
> Change-Id: I72b90f8494c473fa567e6296caf7a771e4caba92
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/182680
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#32064}

TBR=mbonadei@webrtc.org,dpranke@google.com,jeffyoon@google.com

Change-Id: Ia4d6257fee42661c10303217980bd0a9126d2709
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:11881
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183765
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32068}
2020-09-10 09:53:17 +00:00
Mirko Bonadei
7a73c772e2 Switch from "rtc_ios_xctest_test" to "test".
Using the "test" GN template instead of the "ios_xctest_test" one we
will get iOS support for isolates via MB and GN for free, making it
easier to migrate the iOS recipe and fix bugs.webrtc.org/11604.

Bug: webrtc:11881
Change-Id: I72b90f8494c473fa567e6296caf7a771e4caba92
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/182680
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32064}
2020-09-09 20:44:35 +00:00
Mirko Bonadei
52e2dbf1c1 Add voip_unittests to gn_isolate_map.pyl
Adding gn isolate configs for //:voip_unittests in order to run it on
bots.

Bug: webrtc:11251
Change-Id: I00636cb136db116a3b90a7aad4c55c4e4697534b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/172804
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30993}
2020-04-03 09:52:33 +00:00
Mirko Bonadei
e3cfe2c32c Add more missing targets to gn_isolate_map.pyl.
This CL should fix the following error:
MBErr: target "android_examples_junit_tests" not found in //testing/buildbot/gn_isolate_map.pyl
target "android_sdk_junit_tests" not found in //testing/buildbot/gn_isolate_map.pyl

TBR=phoglund@webrtc.org

No-Try: True
Bug: webrtc:11262
Change-Id: Ib1d05401fc9170fe3025e971a1148c4e4cac9506
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/172083
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30930}
2020-03-28 22:28:21 +00:00
Mirko Bonadei
83bae29d58 Add missing xctest targets to gn_isolate_map.pyl.
This CL should fix the following error:

MBErr: target "apprtcmobile_tests" not found in //testing/buildbot/gn_isolate_map.pyl
target "sdk_unittests" not found in //testing/buildbot/gn_isolate_map.pyl
target "sdk_framework_unittests" not found in //testing/buildbot/gn_isolate_map.pyl

It looks like the MB analyze wrapper around GN requires the targets to be
in the gn_isolate_map.pyl in order to retrieve the target label.

I am not sure the type is correct.

TBR=phoglund@webrtc.org

Bug: webrtc:11262
Change-Id: I28ab5aa3cb3962ef56f1b85dfc367c377aca06cc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/172081
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30928}
2020-03-28 16:48:43 +00:00
Oleh Prypin
3a51b0e9d1 Reland "Reland "Add wrapper to normalize flags.""
This is a reland of bd33ce26202272177af6c52e195e7c13f0d1bf23

Now it doesn't apply flags_compatibility to Android, because the device runner actually requires it to be dashes (so it can intercept the flag and substitute it with an Android-local file path), but that's OK because the runner also already passes the flag with underscores: https://cs.chromium.org/?q=%22--isolated_script_test_perf_output%22

Original change's description:
> Reland "Add wrapper to normalize flags."
>
> This is a reland of 642a49d1eb20b8c5744e745de79ddb585e0f7472
>
> The change has the same effect but is now implemented through mb, rather than specifying a 'script', so that Android's special handling is not skipped.
>
> Original change's description:
> > Add wrapper to normalize flags.
> >
> > Bug: None
> > Change-Id: I9d43602cc66198a29dbc0e7586d948ee76c5ec84
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145204
> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> > Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#28532}
>
> Bug: webrtc:10616
> Change-Id: I60ebd4891dbe8de18c653f8af88181ea966307de
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145409
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#28572}

Bug: webrtc:10616
Change-Id: I56aae5475aed62f069c5cecc01b75d7d6ffcf568
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145920
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28589}
2019-07-17 14:09:29 +00:00
Mirko Bonadei
12849c7025 Revert "Reland "Add wrapper to normalize flags.""
This reverts commit bd33ce26202272177af6c52e195e7c13f0d1bf23.

Reason for revert: Breaks Android perf tests.

Original change's description:
> Reland "Add wrapper to normalize flags."
> 
> This is a reland of 642a49d1eb20b8c5744e745de79ddb585e0f7472
> 
> The change has the same effect but is now implemented through mb, rather than specifying a 'script', so that Android's special handling is not skipped.
> 
> Original change's description:
> > Add wrapper to normalize flags.
> >
> > Bug: None
> > Change-Id: I9d43602cc66198a29dbc0e7586d948ee76c5ec84
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145204
> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> > Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#28532}
> 
> Bug: webrtc:10616
> Change-Id: I60ebd4891dbe8de18c653f8af88181ea966307de
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145409
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#28572}

TBR=mbonadei@webrtc.org,oprypin@webrtc.org

Change-Id: Ic0c6677b707397b03edd540a3fec1488d57cb70a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10616
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145728
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28576}
2019-07-16 11:34:31 +00:00
Mirko Bonadei
bd33ce2620 Reland "Add wrapper to normalize flags."
This is a reland of 642a49d1eb20b8c5744e745de79ddb585e0f7472

The change has the same effect but is now implemented through mb, rather than specifying a 'script', so that Android's special handling is not skipped.

Original change's description:
> Add wrapper to normalize flags.
>
> Bug: None
> Change-Id: I9d43602cc66198a29dbc0e7586d948ee76c5ec84
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145204
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#28532}

Bug: webrtc:10616
Change-Id: I60ebd4891dbe8de18c653f8af88181ea966307de
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145409
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28572}
2019-07-16 08:34:58 +00:00
Artem Titarenko
01d04fac75 Revert "Add wrapper to normalize flags."
This reverts commit 642a49d1eb20b8c5744e745de79ddb585e0f7472.

Reason for revert: Speculative revert, may cause infra failures on perf waterfall

Original change's description:
> Add wrapper to normalize flags.
>
> Bug: None
> Change-Id: I9d43602cc66198a29dbc0e7586d948ee76c5ec84
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145204
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#28532}

TBR=mbonadei@webrtc.org,oprypin@webrtc.org

# Not skipping CQ checks because original CL landed > 1 day ago.

No-Try: True
Bug: None
Change-Id: I1a559931b51b2b4614e765978200d47ee37f9186
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145328
Commit-Queue: Artem Titarenko <artit@webrtc.org>
Reviewed-by: Artem Titarenko <artit@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28554}
2019-07-12 10:07:47 +00:00
Mirko Bonadei
642a49d1eb Add wrapper to normalize flags.
Bug: None
Change-Id: I9d43602cc66198a29dbc0e7586d948ee76c5ec84
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145204
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28532}
2019-07-10 18:11:14 +00:00
Mirko Bonadei
2c648f5fb7 Stop running 'bwe_simulations_tests'.
The test binary will be remove by
https://webrtc-review.googlesource.com/c/src/+/140945.

Bug: webrtc:9883
Change-Id: I4d5276c51796586615e089339fba1cf8b0010927
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/142229
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28304}
2019-06-18 10:02:02 +00:00
Oleh Prypin
e8cbf30231 Remove loopback video quality test from configs
Bug: webrtc:10030
Change-Id: Ia09af1453605f7c24361fd6bca7cb0b51e1e4c08
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/123061
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27589}
2019-04-12 12:32:42 +00:00
Mirko Bonadei
f4ce0e4a9f Configs to run slow_tests.
This test binary has been introduced in [1] and should be run on bots.

[1] - https://webrtc-review.googlesource.com/c/src/+/107345

Bug: webrtc:9518
Change-Id: I77e1aebd5fae73a9168f09334ac09be0e865ae90
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/c/110701
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25614}
2018-11-13 10:55:03 +00:00
Mirko Bonadei
2558c4e938 Remove ortc folder.
Since it is currently unused and not actively maintained, code under
ortc/ will be deleted by this CL.

Bug: webrtc:9824
Change-Id: I20f890b1a1e5e1dbd2b3949af916ae0a6bc8a032
Reviewed-on: https://webrtc-review.googlesource.com/c/102601
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25082}
2018-10-10 09:06:57 +00:00
Mirko Bonadei
b56706fcd9 Reland "Compile frame analyzer for the host machine on perf tests."
This is a reland of d8ff3f29ce92e27529e100ecf71afbae6334419f.

See https://webrtc-review.googlesource.com/c/src/+/100681/1..4 for
the fix. Error "Failed to open video file for emulated camera" should
be addressed by that change.

Original change's description:
> Compile frame analyzer for the host machine on perf tests.
>
> Bug: webrtc:9665
> Change-Id: I05c01ee4bef0995556b1a679498b3d9132de7c26
> Reviewed-on: https://webrtc-review.googlesource.com/100360
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#24756}

TBR=phoglund@webrtc.org, oprypin@webrtc.org

Bug: webrtc:9665
Change-Id: If6a4f2259dabf50718abf47c9cf303d143a1895a
Reviewed-on: https://webrtc-review.googlesource.com/100681
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24762}
2018-09-18 09:51:19 +00:00
Mirko Bonadei
6d800030ab Revert "Compile frame analyzer for the host machine on perf tests."
This reverts commit d8ff3f29ce92e27529e100ecf71afbae6334419f.

Reason for revert: It breaks perf tests.

Original change's description:
> Compile frame analyzer for the host machine on perf tests.
> 
> Bug: webrtc:9665
> Change-Id: I05c01ee4bef0995556b1a679498b3d9132de7c26
> Reviewed-on: https://webrtc-review.googlesource.com/100360
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#24756}

TBR=phoglund@webrtc.org,mbonadei@webrtc.org,oprypin@webrtc.org

Change-Id: I9d75dee68ef9257c707fe547ec32a22572ff582c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9665
Reviewed-on: https://webrtc-review.googlesource.com/100680
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24758}
2018-09-17 12:45:24 +00:00
Mirko Bonadei
d8ff3f29ce Compile frame analyzer for the host machine on perf tests.
Bug: webrtc:9665
Change-Id: I05c01ee4bef0995556b1a679498b3d9132de7c26
Reviewed-on: https://webrtc-review.googlesource.com/100360
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24756}
2018-09-17 11:23:40 +00:00
Patrik Höglund
adc4879909 Make sure video_capture_tests run sequentially.
Making video_capture_tests have the non_parallel_console_test_launcher
type will pass --workers=1 to gtest-parallel, which ensures the tests
execute sequentially. This is necessary now that we're accessing a
real physical webcam, which is a system-wide resource that doesn't
work well if several processes access it concurrently.

Follow-ups:
1) get video_capture_test back up on Linux
2) drop sw webcams for Mac and Win
3) remove ensure_webcam_is_running.pu and surrounding machinery

Bug: webrtc:9292
Change-Id: I5e3347ad234f6b942de736513075097d79c0fd36
Reviewed-on: https://webrtc-review.googlesource.com/94761
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24325}
2018-08-17 09:54:52 +00:00
Sami Kalliomäki
3dc427fe34 Fix remaining target name for AppRTCMobile_stubbed_video_io_test_apk.
Fixes a target name that was missed in the last CL.

TBR=phoglund

Bug: webrtc:9588
No-Try: True
Change-Id: I704325666b758cee7eb080f8628fc839ab89831d
Reviewed-on: https://webrtc-review.googlesource.com/92389
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24188}
2018-08-03 14:17:55 +00:00
Sami Kalliomäki
d54f5f5c76 Rename rtc_instrumentation_test_apk targets to end with _test_apk.
This matches Chromium pattern of naming instrumentation test apks with
a name ending in _test_apk. The old naming confuses generate_gradle.py.

Renames:
 - AppRTCMobileTest
   -> AppRTCMobile_test_apk
 - AppRTCMobileTestStubbedVideoIO
   -> AppRTCMobile_stubbed_video_io_test_apk
 - libjingle_peerconnection_android_unittest
   -> android_instrumentation_test_apk

Bug: webrtc:9588
TBR: phoglund
Change-Id: Idb82dc4bd089bc7c90e9373f7c3d572f9fd2d95a
Reviewed-on: https://webrtc-review.googlesource.com/92380
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24184}
2018-08-03 12:44:40 +00:00
Oleh Prypin
739b8169ef Reland "Add support for launching webcam software for use in recipes"
This is a reland of cd469a4ce5315fee62bb77b5e781a18a99da506d
With vpython specified

Original change's description:
> Add support for launching webcam software for use in recipes
>
> * Copy ensure_webcam_is_running.py from recipes repo
> * Turn it into a wrapper that can launch another script
>   (fix_python_path is copied from test_env.py as _ForcePythonInterpreter)
> * Support it in mb.py
> * Add it to video_capture_unittests
>
> No-Try: True
> Bug: chromium:755660
> Change-Id: I376724a77e443620724add7818592e9368d02079
> Reviewed-on: https://webrtc-review.googlesource.com/77320
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#23275}

No-Try: True
Bug: chromium:755660
Change-Id: Ibf4fbe3fea4b003a23b12332b3a6078a2db99a8d
Reviewed-on: https://webrtc-review.googlesource.com/77460
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23279}
2018-05-17 11:42:21 +00:00
Oleh Prypin
e62e18fe13 Revert "Add support for launching webcam software for use in recipes"
This reverts commit cd469a4ce5315fee62bb77b5e781a18a99da506d.

Reason for revert: ImportError: No module named psutil

Original change's description:
> Add support for launching webcam software for use in recipes
> 
> * Copy ensure_webcam_is_running.py from recipes repo
> * Turn it into a wrapper that can launch another script
>   (fix_python_path is copied from test_env.py as _ForcePythonInterpreter)
> * Support it in mb.py
> * Add it to video_capture_unittests
> 
> No-Try: True
> Bug: chromium:755660
> Change-Id: I376724a77e443620724add7818592e9368d02079
> Reviewed-on: https://webrtc-review.googlesource.com/77320
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#23275}

TBR=phoglund@webrtc.org,oprypin@webrtc.org

Change-Id: I611e49e1c8d8668fe405e462ec4b83e364c3d6e7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:755660
Reviewed-on: https://webrtc-review.googlesource.com/77440
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23278}
2018-05-17 11:24:01 +00:00
Oleh Prypin
cd469a4ce5 Add support for launching webcam software for use in recipes
* Copy ensure_webcam_is_running.py from recipes repo
* Turn it into a wrapper that can launch another script
  (fix_python_path is copied from test_env.py as _ForcePythonInterpreter)
* Support it in mb.py
* Add it to video_capture_unittests

No-Try: True
Bug: chromium:755660
Change-Id: I376724a77e443620724add7818592e9368d02079
Reviewed-on: https://webrtc-review.googlesource.com/77320
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23275}
2018-05-17 11:13:01 +00:00
Oleh Prypin
c1a8603a00 Add video_capture_tests to isolate map
TBR: phoglund@webrtc.org
No-Try: True
Bug: chromium:755660
Change-Id: Ib2a63835e4184f6cdf2ed6ff76b78f3f818c0336
Reviewed-on: https://webrtc-review.googlesource.com/76541
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23214}
2018-05-14 12:31:59 +00:00
Oleh Prypin
8cf0a87bc3 Reland "Split perf-test-specific resources in low_bandwidth_audio_test"
This is a reland of 4bbc150b18e961811991e3e524378e703b6d5b31

Now with explicitly specified `write_runtime_deps`

Original change's description:
> Split perf-test-specific resources in low_bandwidth_audio_test
>
> Bug: chromium:755660
> Change-Id: I7c60a47b26ad86892218497f28a09a04574077e6
> Reviewed-on: https://webrtc-review.googlesource.com/61961
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#22439}

Bug: chromium:755660
TBR: phoglund@webrtc.org
Change-Id: I3d4bcc5156ee25de399ab23773ecb73cd995075c
Reviewed-on: https://webrtc-review.googlesource.com/62660
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22483}
2018-03-19 09:30:01 +00:00
Oleh Prypin
650a826cda Revert "Reland "Split perf-test-specific resources in low_bandwidth_audio_test""
This reverts commit b3808dcc36e4dca8b3d2b68c79e20c5888397690.

Reason for revert: Still fails to generate runtime_deps

Original change's description:
> Reland "Split perf-test-specific resources in low_bandwidth_audio_test"
> 
> This is a reland of 4bbc150b18e961811991e3e524378e703b6d5b31
> 
> Now using rtc_source_set to be able to generate runtime deps
> 
> Original change's description:
> > Split perf-test-specific resources in low_bandwidth_audio_test
> >
> > Bug: chromium:755660
> > Change-Id: I7c60a47b26ad86892218497f28a09a04574077e6
> > Reviewed-on: https://webrtc-review.googlesource.com/61961
> > Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> > Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#22439}
> 
> No-Try: True
> Bug: chromium:755660
> Change-Id: I66eda6f016c98e2a8a99f230d9e0323cc09e4976
> Reviewed-on: https://webrtc-review.googlesource.com/62020
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#22450}

TBR=phoglund@webrtc.org,oprypin@webrtc.org

Change-Id: I781e3172416164e6d313574a31e4c982de8bcd9c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:755660
Reviewed-on: https://webrtc-review.googlesource.com/62120
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22454}
2018-03-15 13:52:47 +00:00
Oleh Prypin
b3808dcc36 Reland "Split perf-test-specific resources in low_bandwidth_audio_test"
This is a reland of 4bbc150b18e961811991e3e524378e703b6d5b31

Now using rtc_source_set to be able to generate runtime deps

Original change's description:
> Split perf-test-specific resources in low_bandwidth_audio_test
>
> Bug: chromium:755660
> Change-Id: I7c60a47b26ad86892218497f28a09a04574077e6
> Reviewed-on: https://webrtc-review.googlesource.com/61961
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#22439}

No-Try: True
Bug: chromium:755660
Change-Id: I66eda6f016c98e2a8a99f230d9e0323cc09e4976
Reviewed-on: https://webrtc-review.googlesource.com/62020
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22450}
2018-03-15 13:04:57 +00:00
Oleh Prypin
aaa882cea5 Revert "Split perf-test-specific resources in low_bandwidth_audio_test"
This reverts commit 4bbc150b18e961811991e3e524378e703b6d5b31.

Reason for revert: Breaks on perf Mac bot
https://build.chromium.org/p/client.webrtc.perf/builders/Mac%2010.11/builds/5696

Original change's description:
> Split perf-test-specific resources in low_bandwidth_audio_test
> 
> Bug: chromium:755660
> Change-Id: I7c60a47b26ad86892218497f28a09a04574077e6
> Reviewed-on: https://webrtc-review.googlesource.com/61961
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#22439}

TBR=phoglund@webrtc.org,oprypin@webrtc.org

Change-Id: I235301020417416745c1e754b4dd57726dfb27ea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:755660
Reviewed-on: https://webrtc-review.googlesource.com/61980
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22442}
2018-03-15 10:47:47 +00:00
Oleh Prypin
4bbc150b18 Split perf-test-specific resources in low_bandwidth_audio_test
Bug: chromium:755660
Change-Id: I7c60a47b26ad86892218497f28a09a04574077e6
Reviewed-on: https://webrtc-review.googlesource.com/61961
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22439}
2018-03-15 10:22:56 +00:00
Edward Lemur
0c15a09293 Don't use gtest-parallel when running webrtc_perf_tests.
When we run webrtc_perf_tests with gtest-parallel, each test is run
individually, and this results in the file with the perf results being
overwritten each time.

To avoid this, we won't use gtest-parallel when running webrtc_perf_tests,
so we will simply run the binary directly.

TBR=phoglund@chromium.org

Bug: chromium:755660
Change-Id: I24db36e512fcf604a3de2adf4d0b4325b2c3d1ae
Reviewed-on: https://webrtc-review.googlesource.com/49340
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21982}
2018-02-12 13:10:04 +00:00
Edward Lemur
70ba9b453c Reland "Make it possible to run video_quality_loopback_test in swarming."
This is a reland of 1175ecd09599194caa05ecafdc4503e940809fc9.

Original change's description:
> Make it possible to run video_quality_loopback_test in swarming.
> 
> I made two changes to video_quality_loopback_test to make it possible
> to run it on swarming.
> 
> 1. We need to know the path to frame_analyzer when we're generating
>    the build files, and it must be already present.
>    I made frame_analyzer a resource, so it's downloaded to a known path
>    before generating the build files.
> 2. The .zip files for apprtc and golang are downloaded and isolated.
>    The script now extracts them and installs AppRTC.
> 
> Passing task:
>  https://chromium-swarm.appspot.com/task?id=3b230bcc04128210
> 
> Bug: chromium:755660
> Change-Id: I34090897402421d5b7e29f21fbed354551197f92
> Reviewed-on: https://webrtc-review.googlesource.com/40920
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#21716}

Bug: chromium:755660
Change-Id: Ie3ca62d64b4fe856485287b7d9d3d9e3f75dc091
Reviewed-on: https://webrtc-review.googlesource.com/42860
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21733}
2018-01-23 13:03:17 +00:00
Edward Lemur
9c1848952e Revert "Make it possible to run video_quality_loopback_test in swarming."
This reverts commit 1175ecd09599194caa05ecafdc4503e940809fc9.

Reason for revert: Breaks the bots.

Original change's description:
> Make it possible to run video_quality_loopback_test in swarming.
> 
> I made two changes to video_quality_loopback_test to make it possible
> to run it on swarming.
> 
> 1. We need to know the path to frame_analyzer when we're generating
>    the build files, and it must be already present.
>    I made frame_analyzer a resource, so it's downloaded to a known path
>    before generating the build files.
> 2. The .zip files for apprtc and golang are downloaded and isolated.
>    The script now extracts them and installs AppRTC.
> 
> Passing task:
>  https://chromium-swarm.appspot.com/task?id=3b230bcc04128210
> 
> Bug: chromium:755660
> Change-Id: I34090897402421d5b7e29f21fbed354551197f92
> Reviewed-on: https://webrtc-review.googlesource.com/40920
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#21716}

TBR=phoglund@webrtc.org,ehmaldonado@webrtc.org

Change-Id: Id25d26adc547ff6f9ab178601e37527459c8b5ef
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:755660
Reviewed-on: https://webrtc-review.googlesource.com/42800
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21723}
2018-01-22 16:12:10 +00:00
Edward Lemur
1175ecd095 Make it possible to run video_quality_loopback_test in swarming.
I made two changes to video_quality_loopback_test to make it possible
to run it on swarming.

1. We need to know the path to frame_analyzer when we're generating
   the build files, and it must be already present.
   I made frame_analyzer a resource, so it's downloaded to a known path
   before generating the build files.
2. The .zip files for apprtc and golang are downloaded and isolated.
   The script now extracts them and installs AppRTC.

Passing task:
 https://chromium-swarm.appspot.com/task?id=3b230bcc04128210

Bug: chromium:755660
Change-Id: I34090897402421d5b7e29f21fbed354551197f92
Reviewed-on: https://webrtc-review.googlesource.com/40920
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21716}
2018-01-22 14:40:28 +00:00
Fredrik Solenberg
f39617f76f Remove references to voice_engine_unittests from bots.
TBR=phoglund@webrtc.org

Bug: webrtc:4690
Change-Id: I59649595658e37dfa342217f223a34fa0435ec8d
Reviewed-on: https://webrtc-review.googlesource.com/39720
Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org>
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21626}
2018-01-16 08:29:32 +00:00
Edward Lemur
09d90147fb Reland "Make it possible to isolate bwe_simulations_tests"
Nothing is different from the original change.
The original change was reverted because it was thought it might
have caused an outage for the windows bots. (It didn't.)

This is a reland of 28addd03c1040fc5a634ed92a7edde2aea811e79
Original change's description:
> Make it possible to isolate bwe_simulations_tests
> 
> Add missing data dependencies and add it to gn_isolate_map.pyl
> 
> Bug: chromium:749648
> Change-Id: I6b6c1bb2e4d647471a2747042788a691ce2e1e5d
> Reviewed-on: https://webrtc-review.googlesource.com/8721
> Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#20258}

Bug: chromium:749648
No-Try: true
Change-Id: I5531c5f8b58e0d5b8b6ceeea90acb4bd8e6e6e4f
Reviewed-on: https://webrtc-review.googlesource.com/9320
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20280}
2017-10-13 11:54:26 +00:00
Patrik Höglund
69cc48bb8b Revert "Make it possible to isolate bwe_simulations_tests"
This reverts commit 28addd03c1040fc5a634ed92a7edde2aea811e79.

Reason for revert: Speculative revert: looks like all win bots turned purple

Original change's description:
> Make it possible to isolate bwe_simulations_tests
> 
> Add missing data dependencies and add it to gn_isolate_map.pyl
> 
> Bug: chromium:749648
> Change-Id: I6b6c1bb2e4d647471a2747042788a691ce2e1e5d
> Reviewed-on: https://webrtc-review.googlesource.com/8721
> Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#20258}

TBR=kjellander@webrtc.org,ehmaldonado@webrtc.org,stefan@webrtc.org

Change-Id: I8d07560ba3a60b97cf6525723a0f9888a72a1b1d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:749648
Reviewed-on: https://webrtc-review.googlesource.com/8860
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20259}
2017-10-12 11:10:56 +00:00
Edward Lemur
28addd03c1 Make it possible to isolate bwe_simulations_tests
Add missing data dependencies and add it to gn_isolate_map.pyl

Bug: chromium:749648
Change-Id: I6b6c1bb2e4d647471a2747042788a691ce2e1e5d
Reviewed-on: https://webrtc-review.googlesource.com/8721
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20258}
2017-10-12 09:04:24 +00:00
Edward Lemur
2011075a58 MB: Add support for isolating scripts + isolate low_bandwidth_audio_test.py.
NOTRY=True

Bug: chromium:755660
Change-Id: I92de99cd1e3dd206f6cd366dbfd1c8c211d37cc7
Reviewed-on: https://webrtc-review.googlesource.com/4420
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20089}
2017-10-02 16:57:09 +00:00
Edward Lemur
beffdd4c6a MB: Make it possible to specify timeout.
webrtc_perf_tests needs more than 15 min to run.

NOTRY=True

Bug: chromium:755660
Change-Id: Ibabfae3679206105d585c35f80b839f0046f9ccc
Reviewed-on: https://webrtc-review.googlesource.com/4021
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19996}
2017-09-27 11:49:06 +00:00
Edward Lemur
4d5030f8e6 Fix isac_fix_test on swarming perf bot.
NOTRY=True

Bug: chromium:755660
Change-Id: I32ad056b6f8b687d547bbd58c946dcd1bc630779
Reviewed-on: https://webrtc-review.googlesource.com/3742
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19984}
2017-09-27 06:32:15 +00:00
Mirko Bonadei
92ea95e34a Fixing WebRTC after moving from src/webrtc to src/
In https://webrtc-review.googlesource.com/c/src/+/1560 we moved WebRTC
from src/webrtc to src/ (in order to preserve an healthy git history).
This CL takes care of fixing header guards, #include paths, etc...

NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=tommi@webrtc.org


Bug: chromium:611808
Change-Id: Iea91618212bee0af16aa3f05071eab8f93706578
Reviewed-on: https://webrtc-review.googlesource.com/1561
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19846}
2017-09-15 05:02:56 +00:00
ehmaldonado
a827c087fa Make webrtc_perf_tests run serially on swarming.
BUG=chromium:755660
NOTRY=True

Review-Url: https://codereview.webrtc.org/3012973002
Cr-Commit-Position: refs/heads/master@{#19783}
2017-09-11 19:14:58 +00:00
ehmaldonado
25586cefdd Make it possible to isolate isac_fix_test.
Successful swarming run:
https://chromium-swarm.appspot.com/task?id=38769e8dd5d3e110&refresh=10&show_raw=1

BUG=chromium:755660
NOTRY=True

Review-Url: https://codereview.webrtc.org/3009203002
Cr-Commit-Position: refs/heads/master@{#19738}
2017-09-08 06:18:35 +00:00
kjellander
d2b63cf131 Move webrtc/{tools => rtc_tools}
Leaving compatibility script in webrtc/tools/compare_videos.py to
avoid breaking our video quality tests in Chromium.
Forwarding GN targets are left in webrtc/tools/BUILD.gn.

BUG=webrtc:7855
NOTRY=True
NOPRESUBMIT=True

Review-Url: https://codereview.webrtc.org/2965593002
Cr-Commit-Position: refs/heads/master@{#18848}
2017-06-30 10:04:59 +00:00
Henrik Kjellander
90fd7d84fd Rename tools-webrtc -> tools_webrtc
This aligns with established naming convention for all
other directories.

BUG=webrtc:7593
NOTRY=True
NOTREECHECKS=True
R=ehmaldonado@webrtc.org, mbonadei@webrtc.org
TBR=henrika@webrtc.org

Review-Url: https://codereview.webrtc.org/2864213004 .
Cr-Commit-Position: refs/heads/master@{#18059}
2017-05-09 06:30:13 +00:00