pkasting@chromium.org
16825b1a82
Use int64_t more consistently for times, in particular for RTT values.
...
Existing code was inconsistent about whether to use uint16_t, int, unsigned int,
or uint32_t, and sometimes silently truncated one to another, or truncated
int64_t. Because most core time-handling functions use int64_t, being
consistent about using int64_t unless otherwise necessary minimizes the number
of explicit or implicit casts.
BUG=chromium:81439
TEST=none
R=henrik.lundin@webrtc.org , holmer@google.com , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/31349004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8045 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-12 21:51:21 +00:00
pkasting@chromium.org
4591fbd09f
Use size_t more consistently for packet/payload lengths.
...
See design doc at https://docs.google.com/a/chromium.org/document/d/1I6nmE9D_BmCY-IoV6MDPY2V6WYpEI-dg2apWXTfZyUI/edit?usp=sharing for more information.
This CL was reviewed and approved in pieces in the following CLs:
https://webrtc-codereview.appspot.com/24209004/
https://webrtc-codereview.appspot.com/24229004/
https://webrtc-codereview.appspot.com/24259004/
https://webrtc-codereview.appspot.com/25109004/
https://webrtc-codereview.appspot.com/26099004/
https://webrtc-codereview.appspot.com/27069004/
https://webrtc-codereview.appspot.com/27969004/
https://webrtc-codereview.appspot.com/27989004/
https://webrtc-codereview.appspot.com/29009004/
https://webrtc-codereview.appspot.com/30929004/
https://webrtc-codereview.appspot.com/30939004/
https://webrtc-codereview.appspot.com/31999004/
Committing as TBR to the original reviewers.
BUG=chromium:81439
TEST=none
TBR=pthatcher,henrik.lundin,tina.legrand,stefan,tkchin,glaznev,kjellander,perkj,mflodman,henrika,asapersson,niklas.enbom
Review URL: https://webrtc-codereview.appspot.com/23129004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7726 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-20 22:28:14 +00:00
xians@webrtc.org
3cefbc99f4
Mark all virtual overrides in the hierarchy of Transport as virtual + OVERRIDE.
...
This also marks all virtual overrides of other classes in the same files.
This will make a subsequent change I intend to do safer, where I'll change the
argument types of the base Transport functions, by breaking the compile if I
miss any overrides.
This also highlighted a number of unused functions. I've removed some of these.
TBR=mflodman@webrtc.org , pkasting@chromium.org
BUG=none
TEST=none
Review URL: https://webrtc-codereview.appspot.com/28709004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7421 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-10 09:42:53 +00:00
henrik.lundin@webrtc.org
1972ff8a6e
Mark all virtual overrides in the hierarchy of Module as virtual and OVERRIDE.
...
This will make a subsequent change I intend to do safer, where I'll change the
return type of one of the base Module functions, by breaking the compile if I
miss any overrides.
This also highlighted a number of unused functions (in many cases apparently
virtual "overrides" of no-longer-existent base functions). I've removed some of
these.
This also highlighted several cases where "virtual" was used unnecessarily to
mark a function that was only defined in one class. Removed "virtual" in those
cases.
BUG=none
TEST=none
R=andrew@webrtc.org , henrik.lundin@webrtc.org , mallinath@webrtc.org , mflodman@webrtc.org , stefan@webrtc.org , turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/24419004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7146 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-11 06:20:28 +00:00
henrike@webrtc.org
88fbb2d86b
Switch to using base/constructormagic.h and remove system_wrappers/interface/constructor_magic.h.
...
Same as https://webrtc-codereview.appspot.com/19519004 . The issue in
http://chromegw.corp.google.com/i/internal.chromium.webrtc.fyi/builders/Linux ...
is solved by this change
http://src.chromium.org/viewvc/chrome/trunk/src/third_party/libjingle/libjing ...
(tested locally).
BUG=3380
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/17619005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6218 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-21 21:18:46 +00:00
mcasas@webrtc.org
2fa7f79094
Revert 6202 "Switch to using base/constructormagic.h and remove ..."
...
> Switch to using base/constructormagic.h and remove system_wrappers/interface/constructor_magic.h.
>
> BUG=N/A
> R=andrew@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/19519004
TBR=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14579007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6210 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-21 11:07:29 +00:00
henrike@webrtc.org
125ffd709d
Switch to using base/constructormagic.h and remove system_wrappers/interface/constructor_magic.h.
...
BUG=N/A
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19519004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6202 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-20 15:20:44 +00:00
wu@webrtc.org
6c75c98964
Propagate capture ntp timestamp from rtp to renderer.
...
Mostly the interface changes, the real implementation of ntp timestamp will come in a follow up cl.
TEST=new tests and try bots
BUG=3111
R=niklas.enbom@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/11469004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5911 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-15 17:46:33 +00:00
solenberg@webrtc.org
fc320466d1
Remove ViE external encryption API.
...
BUG=
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8079005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5525 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-11 15:27:49 +00:00
stefan@webrtc.org
faada6e604
Integrate fake_network_pipe into direct_transport.
...
TEST=trybots
R=mflodman@webrtc.org , pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5529004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5321 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-18 20:28:25 +00:00
wu@webrtc.org
9dba525627
* Update libjingle to 50389769.
...
* Together with "Add texture support for i420 video frame." from
wuchengli@chromium.org .
https://webrtc-codereview.appspot.com/1413004
RISK=P1
TESTED=try bots
R=fischman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1967004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4489 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-05 20:36:57 +00:00
pbos@webrtc.org
12dc1a38ca
Switch C++-style C headers with their C equivalents.
...
The C++ headers define the C functions within the std:: namespace, but
we mainly don't use the std:: namespace for C functions. Therefore we
should include the C headers.
BUG=1833
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1917004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4486 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-05 16:22:53 +00:00
stefan@webrtc.org
c74c3c2447
Adds integration test for RTX and fixes bugs found.
...
BUG=1811
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1529004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4096 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-23 13:48:22 +00:00
pbos@webrtc.org
f5d4cb1958
Include files from webrtc/.. paths in video_engine/
...
BUG=1662
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1492004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4056 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-17 13:44:48 +00:00
pbos@webrtc.org
b238d1210b
WebRtc_Word32 -> int32_t in video_engine/
...
BUG=314
Review URL: https://webrtc-codereview.appspot.com/1302005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3801 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-09 13:41:51 +00:00
pwestin@webrtc.org
26e35e1d06
Move the VIE tests to use external transport instead of the built in udp transport
...
Review URL: https://webrtc-codereview.appspot.com/1216010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3712 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-22 19:21:27 +00:00
pwestin@webrtc.org
684f0577fb
Revert r3667 and r3665
...
Review URL: https://webrtc-codereview.appspot.com/1199004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3668 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-13 23:20:57 +00:00
pwestin@webrtc.org
361bac7a4f
Removed the engine API:s related to transport such as SetSendDestination, the functionality is now provided via the test frame work.
...
Review URL: https://webrtc-codereview.appspot.com/1029004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3665 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-13 17:52:42 +00:00
stefan@webrtc.org
77a584be1d
Made ViEToFileRenderer use a separate thread for rendering frames to file.
...
Review URL: https://webrtc-codereview.appspot.com/1021011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3373 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-15 16:34:34 +00:00
mikhal@webrtc.org
0b18fb38e6
vie auto test: Adding a constructor for NetworkParameters
...
BUG=
Review URL: https://webrtc-codereview.appspot.com/995013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3310 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-18 19:47:52 +00:00
mikhal@webrtc.org
622c8bd0cc
ViE autotest: Adding loss models to the external transport
...
Review URL: https://webrtc-codereview.appspot.com/1000004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3309 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-18 17:21:51 +00:00
mflodman@webrtc.org
7acb65a870
Added jitter to fake network pipe.
...
Review URL: https://webrtc-codereview.appspot.com/988004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3283 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-13 15:53:11 +00:00
stefan@webrtc.org
71258c594b
Add a third full stack test and support for random jitter in ext transport.
...
BUG=
Review URL: https://webrtc-codereview.appspot.com/975005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3260 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-11 15:14:56 +00:00
mflodman@webrtc.org
eaf7cf26fe
Adding a simple fake network pipe to use for testing. Next CL will contain an external transport implementation using this link and I'll follow up later making this more advanced.
...
Review URL: https://webrtc-codereview.appspot.com/935032
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3259 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-11 11:47:22 +00:00
phoglund@webrtc.org
273ccad59d
Fixed standard PSNR/SSIM test.
...
BUG=1103
Review URL: https://webrtc-codereview.appspot.com/971005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3197 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-29 10:08:16 +00:00
stefan@webrtc.org
ad7f1fefad
Fixes (or at least reduces) the flakiness in the full stack test by making sure the different frame monitors are registered and deregistered in the right order. Also makes sure only local preview frames which are actually transmitted are rendered by moving the local preview rendering to an effect filter.
...
BUG=
Review URL: https://webrtc-codereview.appspot.com/969005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3157 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-23 11:19:29 +00:00
andrew@webrtc.org
94caca7105
Reorganize modules/video_capture.
...
- The usual elimination of main/source etc.
- Fully qualify "public" includes.
- Use lowercase for all directory names.
Review URL: https://webrtc-codereview.appspot.com/933010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3025 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-30 21:58:00 +00:00
mikhal@webrtc.org
9fedff7c17
Switching to I420VideoFrame
...
Review URL: https://webrtc-codereview.appspot.com/922004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2983 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-24 18:33:04 +00:00
andrew@webrtc.org
14b43beb7c
Move src/ -> webrtc/
...
TBR=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/915006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2963 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-22 18:19:23 +00:00