henrike@webrtc.org
fe526ff10f
fix after r6472 in rtp_sender, comparison between signed and unsigned integer expressions.
...
BUG=N/A
R=pwestin@webrtc.org , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/15909004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6539 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-25 20:59:51 +00:00
asapersson@webrtc.org
3b84b3a58c
Add RTCP packet types to packet builder:
...
REMB, TMMBR, TMMBN and
extended reports: RRTR, DLRR, VoIP metric.
BUG=2450
R=mflodman@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/9299005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6537 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-25 12:22:17 +00:00
minyue@webrtc.org
6568e97d10
This is to compare NetEq with various codecs under a shared packet loss pattern.
...
TEST=passed_all_trybots
R=henrik.lundin@webrtc.org , tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/15529004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6536 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-25 12:17:41 +00:00
bjornv@webrtc.org
d5075bdbb5
Neon version of FilterFar()
...
The performance gain on a Nexus 7 reported by audioproc is ~3.5%.
The output is bit exact.
BUG=3131
TESTED=verified performance manually, passed trybots
R=bjornv@webrtc.org , cd@webrtc.org , kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12799005
Patch from Scott LaVarnway <slavarnw@gmail.com>.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6535 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-25 12:15:46 +00:00
henrik.lundin@webrtc.org
1ed1af9b31
Remove payload duplication in AudioDecoderTest
...
This hack was made to come around issue 845. Now that is solved, and
the test code can be cleaned up.
BUG=845
R=kwiberg@webrtc.org , tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/21709004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6534 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-25 07:59:40 +00:00
henrik.lundin@webrtc.org
eecf5e6ba7
Removing neteq decode lock and friends
...
NetEq is thread-safe by virtue of it's own lock, and in r6404 the
ACMISAC class was made thread-safe. Therefore, the neteq decode lock
is no longer needed.
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/18599004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6531 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-24 13:11:22 +00:00
bjornv@webrtc.org
04fbc38c4a
Neon version of ScaleErrorSignal()
...
The performance gain on a Nexus 7 reported by audioproc is ~4.7%
The output is NOT bit exact. Any difference seen is +-1.
BUG=3131
R=bjornv@webrtc.org , cd@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12779004
Patch from Scott LaVarnway <slavarnw@gmail.com>.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6529 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-24 10:25:00 +00:00
henrik.lundin@webrtc.org
b338ca6557
Annotating the rest of AcmGenericCodec
...
A few locks had to be acquired to fully annotate the class, and a few
others had to be moved.
Removing an API method that was not used.
BUG=3401
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12759004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6526 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-24 05:51:34 +00:00
andrew@webrtc.org
f6d37de466
Fix array declarations in aec_core.c
...
Was causing warnings in Chromium such as:
warning C4742: 'WebRtcAec_overDriveCurve' has different alignment in 'E:\src\buildbot\build\slave\fake_slave\build\src\third_party\webrtc\modules\audio_processing\aec\aec_core_sse2.c' and 'E:\src\buildbot\build\slave\fake_slave\build\src\third_party\webrtc\modules\audio_processing\aec\aec_core.c': 4 and 16
warning C4744: 'WebRtcAec_overDriveCurve' has different type in 'E:\src\buildbot\build\slave\fake_slave\build\src\third_party\webrtc\modules\audio_processing\aec\aec_core_sse2.c' and 'E:\src\buildbot\build\slave\fake_slave\build\src\third_party\webrtc\modules\audio_processing\aec\aec_core.c': 'array (260 bytes)' and '__declspec(align(16)) array (260 bytes)'
warning C4742: 'WebRtcAec_weightCurve' has different alignment in 'E:\src\buildbot\build\slave\fake_slave\build\src\third_party\webrtc\modules\audio_processing\aec\aec_core_sse2.c' and 'E:\src\buildbot\build\slave\fake_slave\build\src\third_party\webrtc\modules\audio_processing\aec\aec_core.c': 4 and 16
warning C4744: 'WebRtcAec_weightCurve' has different type in 'E:\src\buildbot\build\slave\fake_slave\build\src\third_party\webrtc\modules\audio_processing\aec\aec_core_sse2.c' and 'E:\src\buildbot\build\slave\fake_slave\build\src\third_party\webrtc\modules\audio_processing\aec\aec_core.c': 'array (260 bytes)' and '__declspec(align(16)) array (260 bytes)'
BUG=https://code.google.com/p/chromium/issues/detail?id=336620
R=andrew@webrtc.org , cd@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/15869004
Patch from Sebastien Marchand <sebmarchand@chromium.org>.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6525 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-23 22:40:58 +00:00
henrik.lundin@webrtc.org
ceb5a1d724
Annotating the rest of AudioCodingModuleImpl
...
A few extra locks had to be acquired as a result of the annotation.
BUG=3401
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/15819004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6524 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-23 19:52:27 +00:00
kjellander@webrtc.org
1227ab89a7
GN: Add BUILD.gn files + kjellander to OWNERS
...
This should work as a foundation for all the work that is
left to do to make the parts of WebRTC that Chromium uses
to build with GN.
I implemented some the smaller modules myself in this CL.
The remaining work (TODO's in the .gn files) will be distributed
to various team members.
I'm adding myself to OWNERS files for BUILD.gn files in all the
directories where I'm adding a BUILD.gn file.
BUG=3441
TEST=
Successful compilation of WebRTC as standalone:
gn gen out/Default --args="build_with_chromium=false" && ninja -C out/Default
gn gen out/Default --args="build_with_chromium=false is_clang=true clang_use_chrome_plugins=false" && ninja -C out/Default
I built successfully from a Chromium checkout (with
https://codereview.chromium.org/321313006/ applied) using:
gn gen out/Default && ninja -C out/Default webrtc
R=brettw@chromium.org , niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/13749004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6523 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-23 19:21:07 +00:00
bjornv@webrtc.org
b6ebe75806
Disables tests that breaks Android bots
...
BUG=
TBR=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/15859004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6520 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-23 09:14:03 +00:00
kjellander@webrtc.org
27ab19d9b4
Roll chromium_revision 272489:277350 + fix sanitizer options
...
Rolling to this new Chromium revision required us to introduce
a sanitizer_options similar to the one in Chromium's base
(see https://code.google.com/p/chromium/codesearch#chromium/src/base/base.gyp&l=977
and https://codereview.chromium.org/238123003 ) in order
to get the same defaults for ASan and LSan. Without it
compilation will break since LeakSanitizer (LSan) is enabled by
default in Clang r209387 that is pulled with this roll.
I setup so that we pull in the sanitizer_options.cc and
tsan_suppressions.cc files using DEPS, so we don't have to maintain
them separately for now. We can still use our own TSan suppressions.txt
file as we do today with no changes needed.
This roll also brings in http://crrev.com/276676 so we can enable
GN build for WebRTC.
Overview of changes in Chrome DEPS:
$ svn diff http://src.chromium.org/chrome/trunk/src/DEPS -r 272489:277350
which can be compared with the output of:
$ svn cat http://webrtc.googlecode.com/svn/trunk/DEPS | grep chromium_deps | sed 's/^ *//' | sort | uniq
in a WebRTC checkout, gives the following relevant changes:
* third_party/android_tools 6fc0e1:c6e658
* third_party/libjpeg_turbo 263594:272637
* third_party/libyuv 1000:1007
* third_party/nss 271760:277057
* tools/gyp 1921:1927
* tools/swarming_client ae8085:aea506
The following also shows that Clang is upgraded from r206824 to r209387:
$ svn diff http://src.chromium.org/chrome/trunk/src/tools/clang/scripts/update.sh -r 272489:277350
BUG=3441
TEST=Trybots are not passing since after the recipe switch, SVN-based try jobs doesn't seem to support auto-detecting that a sync is needed if there's a DEPS change.
R=andrew@webrtc.org , pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12729004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6516 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-21 19:30:29 +00:00
glaznev@webrtc.org
a24d366e1c
- Exit from a camera thread lopper loop() method only after all camera release calls are completed. This fixes camera exceptions observed from time to time when calling camera functions on a terminated looper.
...
- Allocate real texture for camera preview.
- Add fps and camera frame duration logging.
- Get camera frame timestamp in Java code and pass it to jni code so the frame timestamp is assigned as soon as possible. Jni code will not use these timestamps yet until timestamp ntp correction and zeroing in webrtcvideengine.cc will be addressed.
R=fischman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/16729004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6513 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-20 20:55:54 +00:00
braveyao@webrtc.org
0b893b1e05
Do not hold the critical section in VideoCaptureAndroid::SetCaptureRotation since it would case possible deadlock with OS Camear thread.
...
BUT=3464
TEST=Manual Test with WebRTCDemo
R=glaznev@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/21719004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6509 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-20 16:00:30 +00:00
jiayl@webrtc.org
594aefa807
Do not call CaptureCursor in ScreenCapturerWinGdi if no MouseShapeObserver.
...
It's wasted work and affects frame rate adaptation in Chrome.
BUG=
R=sergeyu@chromium.org
Review URL: https://webrtc-codereview.appspot.com/19789004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6499 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-19 22:04:41 +00:00
fgalligan@google.com
304ca76be1
Revert 6481 and 6482
...
Revert 6482 "Update webrtc to fix unpack_lib expansion."
Revert 6481 "Update generated asm offsets scripts."
The roll has not been successful. Reverted based on the request of the
committer.
TBR=turaj
Review URL: https://webrtc-codereview.appspot.com/17759004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6495 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-19 17:08:46 +00:00
turaj@webrtc.org
8de8c9155e
Maintain constantness of the input to iSAC-fix decoder, and prevent heap-buffer overflow.
...
To save memory in iSAC-fix, decoder operated directly on the recieved bitstream. However, this breaks constantness of input when decoder performed in-place big to little Endian conversion. Furthermore, for bit-streams with odd lengths, this meant writing outside the memory. That is because the last byte will be shifted to the Most Significat Byte which might be outside the allocated memory.
If we care about memory, the solution is to do a big-to-little Endian conversion everytime we read a Word16 from the bitstream.
BUG=845,chrome:379458
R=henrik.lundin@webrtc.org , tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/15829004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6494 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-19 15:47:09 +00:00
henrik.lundin@webrtc.org
9158df2aa4
Adding an empty constructor implementation to the AudioSink class
...
Turns out it was needed.
TBR=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/15849004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6493 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-19 12:34:31 +00:00
bjornv@webrtc.org
84f8ec1f9c
Changes to tests and tools in audio_processing.
...
- Disables ApmTest.EchoCancellationReportsCorrectDelays
This test relys completely on the structure of how reported system delays are handled in AEC. In addition it assumes a fix setup of delay logging buffers. This test should be refactored.
- Adds flag to turn off reported_delay in audioproc
Now it is feasible to turn on and off the use of reported system delays.
BUG=N/A
R=aluebs@webrtc.org , kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/16749004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6492 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-19 12:14:33 +00:00
stefan@webrtc.org
077593b805
Ensure that the start bitrate can be set multiple times.
...
If the start bitrate is set twice, it will be set to the sum of the start
bitrates of the currently registered bitrate observers, or left unchanged
if the current estimate actually is greater than the sum.
BUG=3503
R=henrik.lundin@webrtc.org , pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/15839004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6491 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-19 12:13:00 +00:00
henrik.lundin@webrtc.org
496a98463b
Adding test::AudioSink interface and derived classes
...
The AudioSink interface is supposed to be used by tests that produce
audio output. Two implementation classes are also provided:
OutputAudioFile: Writes the audio to a pcm file.
AudioChecksum: Calculates the MD5 checksum of the audio.
These will both be used in future changes.
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/17729004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6490 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-19 10:02:11 +00:00
bjornv@webrtc.org
5c3f4e3b0f
Fixes and re-enables tests disabled on Android
...
Several tests were disabled in r6325 and r6326. Also, see issue 3445. This CL fixes the remaining four of the audio_processing related ones. Affects the tests:
- SystemDelayTest.CorrectDelayAfterStableBufferBuildUp
- SystemDelayTest.CorrectDelayDuringDrift
- SystemDelayTest.ShouldRecoverAfterGlitch
- ApmTest.EchoCancellationReportsCorrectDelays
The tests assumes reported delays are used, which now is explicitly set.
BUG=3445
TESTED=trybots
R=aluebs@webrtc.org , kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19769004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6489 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-19 09:51:29 +00:00
fgalligan@google.com
a19b930b5b
Update webrtc to fix unpack_lib expansion.
...
Add on fix for:https://webrtc-codereview.appspot.com/12789004/
*NOTE* This CL will break the Android bots as they are built in a
Chromium checkout, which will pull in old libvpx DEPS. They will
cycle to green when we roll libvpx into Chromium. We must do the
rolls in this order because we have to land webrtc and libvpx at
the same time into Chromium.
BUG=377062
TBR=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/20729004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6482 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-18 19:20:45 +00:00
fgalligan@google.com
8f06a8aeb0
Update generated asm offsets scripts.
...
Libvpx updated the unpack scripts to fix building dependencies.
Roll libvpx 269083:278063
See https://codereview.chromium.org/295313002/
https://codereview.chromium.org/298063002/
https://codereview.chromium.org/305533008/
https://codereview.chromium.org/305703002/
https://codereview.chromium.org/298383003/
https://codereview.chromium.org/302863004/
https://codereview.chromium.org/320923003/
https://codereview.chromium.org/325313007/
https://codereview.chromium.org/346563002/
for the libvpx changes.
See https://codereview.chromium.org/313243004/
for the WebView changes.
*NOTE* This CL will break the Android bots as they are built in a
Chromium checkout, which will pull in old libvpx DEPS. They will
cycle to green when we roll libvpx into Chromium. We must do the
rolls in this order because we have to land webrtc and libvpx at
the same time into Chromium.
BUG=377062
TBR=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12789004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6481 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-18 17:38:08 +00:00
bjornv@webrtc.org
b947d954a5
Neon version of FilterAdaptation()
...
The performance gain on a Nexus 7 reported by audioproc is ~5.2%.
The output is bit exact.
Measured total of 15% speed gain on N7 compared to C.
R=bjornv@webrtc.org , cd@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/17699004
Patch from Scott LaVarnway <slavarnw@gmail.com>.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6480 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-18 14:55:49 +00:00
henrik.lundin@webrtc.org
12396aba42
Update PacketSource and RtpFileSource
...
The NextPacket method should now return NULL when the end of the
source was reached. In the RtpFileSource, this means that when
the end of file is reached, NULL is returned. Also, when an RTCP
packet is encountered, the next packet will be read from file
immediately.
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/20699004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6479 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-18 12:20:31 +00:00
henrik.lundin@webrtc.org
d8de0669c9
Revert "Restore ptypes.txt file"
...
This reverts r6460. It turns out the file was no longer needed after
all.
BUG=2996
TBR=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12769004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6478 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-18 11:09:53 +00:00
turaj@webrtc.org
ec869bf781
Revert 6473 "Update generated asm offsets scripts."
...
The roll has not been successful. Reverted based on the request of the committer.
> Update generated asm offsets scripts.
>
> Libvpx updated the unpack scripts to fix building dependencies.
>
> Roll libvpx 269083:277778
> See https://codereview.chromium.org/295313002/
> https://codereview.chromium.org/298063002/
> https://codereview.chromium.org/305533008/
> https://codereview.chromium.org/305703002/
> https://codereview.chromium.org/298383003/
> https://codereview.chromium.org/302863004/
> https://codereview.chromium.org/320923003/
> https://codereview.chromium.org/325313007/
> for the libvpx changes.
>
> See https://codereview.chromium.org/313243004/
> for the WebView changes.
>
> *NOTE* This CL will break the Android bots as they are built in a
> Chromium checkout, which will pull in old libvpx DEPS. They will
> cycle to green when we roll libvpx into Chromium. We must do the
> rolls in this order because we have to land webrtc and libvpx at
> the same time into Chromium.
>
> BUG=377062
> TBR=andrew@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/15809004
TBR=fgalligan@google.com
Review URL: https://webrtc-codereview.appspot.com/18589004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6475 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-17 19:07:56 +00:00
fgalligan@google.com
32196decd6
Update generated asm offsets scripts.
...
Libvpx updated the unpack scripts to fix building dependencies.
Roll libvpx 269083:277778
See https://codereview.chromium.org/295313002/
https://codereview.chromium.org/298063002/
https://codereview.chromium.org/305533008/
https://codereview.chromium.org/305703002/
https://codereview.chromium.org/298383003/
https://codereview.chromium.org/302863004/
https://codereview.chromium.org/320923003/
https://codereview.chromium.org/325313007/
for the libvpx changes.
See https://codereview.chromium.org/313243004/
for the WebView changes.
*NOTE* This CL will break the Android bots as they are built in a
Chromium checkout, which will pull in old libvpx DEPS. They will
cycle to green when we roll libvpx into Chromium. We must do the
rolls in this order because we have to land webrtc and libvpx at
the same time into Chromium.
BUG=377062
TBR=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/15809004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6473 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-17 17:55:23 +00:00
stefan@webrtc.org
a15fbfdcde
Add round-robin selection of send stream to pad on.
...
BUG=1812
R=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/21669004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6472 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-17 17:32:05 +00:00
niklas.enbom@webrtc.org
9c09e6ee2b
Add high perf mode to VP8
...
R=marpan@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14709004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6470 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-17 16:32:08 +00:00
minyue@webrtc.org
d42da54768
Revert 6458 "Since NetEq4 is ready to handle 48 kHz codec, it is..."
...
> Since NetEq4 is ready to handle 48 kHz codec, it is good to remove the 48-to-32kHz downsampling of Opus output. This facilitates webrtc to make full use of Opus's bandwidth and eliminates unneeded computation in resampling.
>
> TEST=passed_all_trybots
> R=henrik.lundin@webrtc.org , tina.legrand@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/16619005
TBR=minyue@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/17719004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6462 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-17 09:50:12 +00:00
henrik.lundin@webrtc.org
2ca2188906
Restore ptypes.txt file
...
The file was lost when the neteq folders where moved and renamed.
BUG=2996
TBR=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/13729004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6460 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-17 08:51:01 +00:00
minyue@webrtc.org
8f8503d947
Since NetEq4 is ready to handle 48 kHz codec, it is good to remove the 48-to-32kHz downsampling of Opus output. This facilitates webrtc to make full use of Opus's bandwidth and eliminates unneeded computation in resampling.
...
TEST=passed_all_trybots
R=henrik.lundin@webrtc.org , tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/16619005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6458 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-17 08:02:05 +00:00
asapersson@webrtc.org
4b12d40008
Add SDES, APP, IJ, SLI and PLI packet types to RTCP packet class.
...
BUG=2450
R=mflodman@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19559004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6449 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-16 14:09:28 +00:00
bjornv@webrtc.org
b099a6f9ab
Adds aluebs@webrtc.org as owner to audio_processing
...
BUG=N/A
TESTED=trybots
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/17709004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6445 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-16 10:30:58 +00:00
bjornv@webrtc.org
721f970cba
common_audio: Removes macro WEBRTC_SPL_LSHIFT_U16
...
We should avoid macros in general (see style guide) and the shift ones are particular dangerous since they assume that the user apply a non-negative shift.
Related CL: https://webrtc-codereview.appspot.com/16669004
BUG=3348,3353
TESTED=trybots and manually on linux
R=turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19719004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6444 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-16 10:30:14 +00:00
henrik.lundin@webrtc.org
63e46077a3
Add thread annotations to parts of ACMGenericCodec
...
This change adds annotations to all member variables that could be
annotated without acquiring any new locks, or changing the lock
structure in any other way.
BUG=3041
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/18539004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6441 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-16 08:02:25 +00:00
glaznev@webrtc.org
ab23d493e0
Add glaznev@ to OWNERS for webrtc/modules/video_capture and talk/app/webrtc.
...
Review URL: https://webrtc-codereview.appspot.com/20659004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6436 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-13 23:31:35 +00:00
bjornv@webrtc.org
af6f02f7bd
Neon version of OverdriveAndSuppress()
...
audioproc reports the average frame time going from 279us to 255us with the test data used.
the output does not match the c version, but the difference seen is +-1.
Performance gain on Nexus7: 8.8%
BUG=3131
TESTED=trybots and manually
R=bjornv@webrtc.org , cd@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19539004
Patch from Scott LaVarnway <slavarnw@gmail.com>.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6433 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-13 14:50:23 +00:00
kjellander@webrtc.org
a1bfc50a72
Pass GYP DEPTH variable to isolate.
...
Similar change to https://codereview.chromium.org/322403003/
This will make it possible to handle different
directory levels for special builds of WebRTC, without
breaking GYP when the .isolate files are processed and
their contents is verified.
Also update all our .isolate files to use the <(DEPTH)
variable.
BUG=343106
TEST=Successful compile+test on Linux using:
ninja -C out/Release
tools/swarming_client/isolate.py run -s out/Release/tools_unittests.isolated
Also trybots passing all tests.
R=pbos@webrtc.org
TBR=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/13679004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6427 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-13 09:02:15 +00:00
wu@webrtc.org
8e256eec4f
Revert 6415 "Update generated asm offsets scripts."
...
> Update generated asm offsets scripts.
>
> This is the same CL as https://webrtc-codereview.appspot.com/16629004/
> Relanding and TBR from previous lgtm.
>
> Libvpx updated the unpack scripts to fix building dependencies.
>
> Roll libvpx 269083:275816
> See https://codereview.chromium.org/295313002/
> https://codereview.chromium.org/298063002/
> https://codereview.chromium.org/305533008/
> https://codereview.chromium.org/305703002/
> https://codereview.chromium.org/298383003/
> https://codereview.chromium.org/302863004/
> https://codereview.chromium.org/320923003/
> for the libvpx changes.
>
> See https://codereview.chromium.org/313243004/
> for the WebView changes.
>
> *NOTE* This CL will break the Android bots as they are built in a
> Chromium checkout, which will pull in old libvpx DEPS. They will
> cycle to green when we roll libvpx into Chromium. We must do the
> rolls in this order becuase we have to land webrtc and libvpx at
> the same time into Chromium.
>
> BUG=377062
> TBR=andrew@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/17689004
TBR=fgalligan@google.com
Review URL: https://webrtc-codereview.appspot.com/13709004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6423 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-12 23:03:17 +00:00
stefan@webrtc.org
cb254aac3b
Enable pacing by default and remove the option to disable it from the new API.
...
BUG=1672
R=mflodman@webrtc.org , pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/17659004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6416 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-12 15:12:25 +00:00
fgalligan@google.com
27f062ae6f
Update generated asm offsets scripts.
...
This is the same CL as https://webrtc-codereview.appspot.com/16629004/
Relanding and TBR from previous lgtm.
Libvpx updated the unpack scripts to fix building dependencies.
Roll libvpx 269083:275816
See https://codereview.chromium.org/295313002/
https://codereview.chromium.org/298063002/
https://codereview.chromium.org/305533008/
https://codereview.chromium.org/305703002/
https://codereview.chromium.org/298383003/
https://codereview.chromium.org/302863004/
https://codereview.chromium.org/320923003/
for the libvpx changes.
See https://codereview.chromium.org/313243004/
for the WebView changes.
*NOTE* This CL will break the Android bots as they are built in a
Chromium checkout, which will pull in old libvpx DEPS. They will
cycle to green when we roll libvpx into Chromium. We must do the
rolls in this order becuase we have to land webrtc and libvpx at
the same time into Chromium.
BUG=377062
TBR=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/17689004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6415 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-12 14:59:28 +00:00
kjellander@webrtc.org
7e3d62d709
Revert 6411 "Revert 6407 "Revert 6405 "Update generated asm offs..."
...
Turns out the previous revert was based on invalid assumptions.
The libvpx in Chromium was reverted in
http://chromegw.corp.google.com/viewvc/chrome?view=rev&revision=271259
which ends up with libvpx r269083. Therefore we should restore
that same libvpx revision for WebRTC, which this revert will do.
> Revert 6407 "Revert 6405 "Update generated asm offsets scripts.""
>
> > Revert 6405 "Update generated asm offsets scripts."
> >
> > TBR=fgalligan@google.com
> > BUG=N/A
> >
> > Review URL: https://webrtc-codereview.appspot.com/20639004
>
> TBR=henrike@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/15739004
TBR=minyue@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/15749004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6413 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-12 11:07:07 +00:00
minyue@webrtc.org
c01cc3d3a8
Revert 6407 "Revert 6405 "Update generated asm offsets scripts.""
...
> Revert 6405 "Update generated asm offsets scripts."
>
> TBR=fgalligan@google.com
> BUG=N/A
>
> Review URL: https://webrtc-codereview.appspot.com/20639004
TBR=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/15739004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6411 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-12 08:48:34 +00:00
henrike@webrtc.org
286cd7683c
Revert 6405 "Update generated asm offsets scripts."
...
TBR=fgalligan@google.com
BUG=N/A
Review URL: https://webrtc-codereview.appspot.com/20639004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6407 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-12 00:38:32 +00:00
fgalligan@google.com
4aeb94186a
Update generated asm offsets scripts.
...
Libvpx updated the unpack scripts to fix building dependencies.
Roll libvpx 269083:275816
See https://codereview.chromium.org/295313002/
https://codereview.chromium.org/298063002/
https://codereview.chromium.org/305533008/
https://codereview.chromium.org/305703002/
https://codereview.chromium.org/298383003/
https://codereview.chromium.org/302863004/
https://codereview.chromium.org/320923003/
for the libvpx changes.
See https://codereview.chromium.org/313243004/
for the WebView changes.
BUG=377062
R=andrew@webrtc.org , michaelbai@chromium.org
Review URL: https://webrtc-codereview.appspot.com/16629004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6405 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-11 17:12:51 +00:00
henrik.lundin@webrtc.org
5b111b06fa
Re-land "Create a joint encoder/decoder wrapper for iSAC in ACM"
...
The change was reverted since it was thought to cause a flaky test.
But the test kept flaking after the change was reverted.
This effectively reverts r6394, relanding r6377.
BUG=3496
TBR=minyue@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/20629004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6404 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-11 14:37:21 +00:00