Stefan Holmer
d67717f9ad
Make opus memcheck suppression more generic
...
TBR=kjellander@webrtc.org
BUG=webrtc:5651
Review URL: https://codereview.webrtc.org/1799093002 .
Cr-Commit-Position: refs/heads/master@{#11979}
2016-03-14 15:00:12 +00:00
Stefan Holmer
479a04cbb7
Suppress invalid read in Opus.
...
TBR=kjellander@webrtc.org
BUG=webrtc:5651
Review URL: https://codereview.webrtc.org/1803533002 .
Cr-Commit-Position: refs/heads/master@{#11975}
2016-03-14 09:23:08 +00:00
kjellander@webrtc.org
2875077458
Roll chromium_revision db8316d..6a56b54 (380688:380836): MSVS 2015 switch
...
This CL switches over to using Microsoft Visual Studio 2015 by default
on Windows. This large effort is described in more detail in
https://crbug.com/440500 .
Change log: db8316d..6a56b54
Full diff: db8316d..6a56b54
No dependencies changed.
No update to Clang.
TBR=tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1792633002 .
Cr-Commit-Position: refs/heads/master@{#11974}
2016-03-14 05:49:17 +00:00
kjellander@webrtc.org
8110482297
Rename gtest_exclude for rtc_pc_unittests
...
This was forgotten in https://codereview.webrtc.org/1694813002/
Also clean up no-longer-used files for libjignle_unittest (renamed
to rtc_unittests a long time ago).
BUG=webrtc:5419
TBR=pbos@webrtc.org
Review URL: https://codereview.webrtc.org/1698123002 .
Cr-Commit-Position: refs/heads/master@{#11625}
2016-02-15 12:00:58 +00:00
Peter Boström
56e6269e11
Rename gtest_exclude for rtc_media_unittests.
...
Previous suppressions for libjingle_media_unittest stopped working when
the target was renamed rtc_media_unittests causing the bots to start
flaking.
BUG=
TBR=kjellander@webrtc.org
Review URL: https://codereview.webrtc.org/1698873002 .
Cr-Commit-Position: refs/heads/master@{#11624}
2016-02-15 10:59:21 +00:00
Peter Boström
88c52a7e7b
Disable VerifyHistogramStatsWithRed on DrMemory.
...
Flaky due to using a real VP8 encoder.
BUG=webrtc:5264
TBR=deadbeef@webrtc.org , stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1695103003 .
Cr-Commit-Position: refs/heads/master@{#11623}
2016-02-15 10:31:48 +00:00
Peter Boström
395939781b
Reland of Don't send FEC for H.264 with NACK enabled. (patchset #1 id:1 of https://codereview.webrtc.org/1692783005/ )
...
Reason for revert:
Disabling tests on memcheck that time out due to using real VP8 encoders.
Original issue's description:
> Revert of Don't send FEC for H.264 with NACK enabled. (patchset #5 id:80001 of https://codereview.webrtc.org/1687303002/ )
>
> Reason for revert:
> Broke the VerifyHistogramStatsWithRed test on the Windows DrMemory Full bot and Linux Memcheck bot. Please fix the test and reland.
>
> Original issue's description:
> > Don't send FEC for H.264 with NACK enabled.
> >
> > The H.264 does not contain picture IDs and are not sufficient to
> > determine that a packet may be skipped. This causes retransmission
> > requests for FEC that are currently dropped by the sender (since they
> > should be redundant).
> >
> > The receiver is then unable to continue without having the packet gap
> > filled (unlike VP8/VP9 which moves on since it has a consecutive stream
> > of picture IDs).
> >
> > Even if FEC retransmission did work it's a huge waste of bandwidth,
> > since it just adds additional overhead that has to be unconditionally
> > transmitted. This bandwidth is better used to send higher-quality
> > frames.
> >
> > BUG=webrtc:5264
> > R=stefan@webrtc.org
> >
> > Committed: https://crrev.com/25558ad819b4df41ba51537e26a77480ace1e525
> > Cr-Commit-Position: refs/heads/master@{#11601}
>
> TBR=stefan@webrtc.org ,pbos@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:5264
>
> Committed: https://crrev.com/29ffdc1a15e31bd81e806ff135c2100d811714f0
> Cr-Commit-Position: refs/heads/master@{#11607}
TBR=stefan@webrtc.org ,deadbeef@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:5264
Review URL: https://codereview.webrtc.org/1697093002 .
Cr-Commit-Position: refs/heads/master@{#11621}
2016-02-15 10:27:22 +00:00
danilchap
5c35cf9f8e
Re-enable RestartingSendStreamPreservesRtpState.
...
based on https://codereview.webrtc.org/1457283002/
Packets allowed now to come out of order.
BUG=webrtc:3552
R=pbos@webrtc.org
Review URL: https://codereview.webrtc.org/1661923002
Cr-Commit-Position: refs/heads/master@{#11477}
2016-02-03 22:14:57 +00:00
tnakamura
cc71c4107f
Revert "Disable P2PTransport...TestFailoverControlledSide on Memcheck"
...
This reverts commit 1a8240c32a14a31b1417b6e06f511f2a16d81b19.
Per comments in bug 5136, the affected test should no longer be flaky.
BUG=webrtc:5136
Review URL: https://codereview.webrtc.org/1616273004
Cr-Commit-Position: refs/heads/master@{#11360}
2016-01-22 20:45:07 +00:00
kjellander
becf9ee48c
Roll chromium_revision 6a04368..1728ddf (370362:370595)
...
Our valgrind script needed to be updated due to
6a04368..1728ddf /tools/valgrind/chrome_tests.py
Change log: 6a04368..1728ddf
Full diff: 6a04368..1728ddf
Changed dependencies:
* src/third_party/ffmpeg: 7deada1..2dc5618
* src/third_party/libsrtp: ebfcc9a..9cc4f2f
* src/third_party/libvpx_new/source/libvpx: b520882..c0307e6
* src/tools/gyp: 54b7dfc..aa0301b
DEPS diff: 6a04368..1728ddf /DEPS
No update to Clang.
TBR=marpan@webrtc.org , stefan@webrtc.org ,
NOTRY=True
Review URL: https://codereview.webrtc.org/1610253003
Cr-Commit-Position: refs/heads/master@{#11330}
2016-01-21 09:46:00 +00:00
kjellander
436ff3129e
Update exclude files for renamed test
...
The test binary libjingle_peerconnection_unittest was
renamed to peerconnection_unittests in
https://codereview.webrtc.org/1602443004/ but these
files were not renamed.
TBR=perkj@webrtc.org
NOTRY=True
Review URL: https://codereview.webrtc.org/1599413007
Cr-Commit-Position: refs/heads/master@{#11314}
2016-01-20 08:19:23 +00:00
marpan
8432e1f4b8
Re-enable tests that failed under Linux_Msan.
...
Fixed in latest libvpx roll.
Keep EndToEndTest.TransportSeqNumOnAudioAndVideo disabled on
Win_DrMemory for now as it seems to time-out/too slow.
TBR=stefan@webrtc.org , kjellander@webrtc.org
BUG=webrtc:5402
NOTRY=True
Review URL: https://codereview.webrtc.org/1577313003
Cr-Commit-Position: refs/heads/master@{#11240}
2016-01-13 16:35:51 +00:00
kjellander
3c05e6c9c3
Disable EndToEndTest.TransportSeqNumOnAudioAndVideo for Dr Memory.
...
It started failing at the roll in
https://codereview.webrtc.org/1556273002
BUG=webrtc:5402
TBR=marpan@webrtc.org
NOTRY=True
Review URL: https://codereview.webrtc.org/1574813002
Cr-Commit-Position: refs/heads/master@{#11198}
2016-01-10 05:46:42 +00:00
Guo-wei Shieh
684e995464
Disable 2 video tests which fail on DrMemoryFull
...
TBR=kjellander@webrtc.org
BUG=5417
Review URL: https://codereview.webrtc.org/1575433003 .
Cr-Commit-Position: refs/heads/master@{#11193}
2016-01-09 03:03:50 +00:00
deadbeef
523702136f
Disabling CritSectTest on Windows DrMemory bot.
...
BUG=webrtc:5390
Review URL: https://codereview.webrtc.org/1554673002
Cr-Commit-Position: refs/heads/master@{#11148}
2016-01-04 19:50:50 +00:00
Henrik Kjellander
4138e08eb6
Convert DOS->Unix line endings for Dr memory exclude file.
...
NOTRY=True
NOPRESUBMIT=True
TBR=deadbeef@webrtc.org
Review URL: https://codereview.webrtc.org/1555043003 .
Cr-Commit-Position: refs/heads/master@{#11146}
2016-01-04 12:02:05 +00:00
Stefan Holmer
498ae00f39
Disable ThreadTest.ThreeThreadsInvoke on DrMemory bots.
...
BUG=webrtc:5199
TBR=pbos@webrtc.org
Review URL: https://codereview.webrtc.org/1524073002 .
Cr-Commit-Position: refs/heads/master@{#11020}
2015-12-15 08:46:18 +00:00
solenberg
b562c33f15
Remove ancient VoE suppressions.
...
BUG=webrtc:332
Review URL: https://codereview.webrtc.org/1511413007
Cr-Commit-Position: refs/heads/master@{#10988}
2015-12-11 13:32:42 +00:00
deadbeef
7c73bdbd82
Renaming JsepPeerConnectionP2PTestClient back to P2PTestConductor.
...
Updating blacklists as well.
Review URL: https://codereview.webrtc.org/1508683004
Cr-Commit-Position: refs/heads/master@{#10980}
2015-12-10 23:10:52 +00:00
minyuel
af3b9cb4d3
Removing DrMemory suppresssion on PushResampler.
...
BUG=webrtc:2321
R=kjellander@webrtc.org
Review URL: https://codereview.webrtc.org/1502183006 .
Cr-Commit-Position: refs/heads/master@{#10950}
2015-12-09 12:52:09 +00:00
Peter Boström
ab82cbbfd9
Disable RtcEventLogTest.DropOldEvents on memcheck.
...
BUG=webrtc:5312
TBR=terelius@webrtc.org
Review URL: https://codereview.webrtc.org/1506763003 .
Cr-Commit-Position: refs/heads/master@{#10914}
2015-12-07 14:30:22 +00:00
Peter Boström
fcdcf4a927
Disable RtcEventLogTest.DropOldEvents on DrMemory.
...
BUG=webrtc:5312
R=terelius@webrtc.org
Review URL: https://codereview.webrtc.org/1495093004 .
Cr-Commit-Position: refs/heads/master@{#10894}
2015-12-04 13:19:19 +00:00
Stefan Holmer
f0a431a283
Exclude EndToEndTest.ReceivesTransportFeedback and TransportFeedbackNotConfigured from DrMemory.
...
R=kjellander@webrtc.org
Review URL: https://codereview.webrtc.org/1468993002 .
Cr-Commit-Position: refs/heads/master@{#10748}
2015-11-23 11:59:18 +00:00
ivoc
49a6c99d1f
Disables BitrateEstimatorTest.SwitchesToASTThenBackToTOFForVideo on win_drmemory_full due to flakiness.
...
NOTRY=true
TBR=solenberg@webrtc.org
BUG=webrtc:5225
Review URL: https://codereview.webrtc.org/1456013002
Cr-Commit-Position: refs/heads/master@{#10690}
2015-11-18 15:04:41 +00:00
Peter Boström
cc4989a458
Remove BaseUnitTest suppression.
...
Test no longer exists and doesn't need to be suppressed on DrMemory.
BUG=webrtc:3904
TBR=kjellander@webrtc.org
Review URL: https://codereview.webrtc.org/1427843006 .
Cr-Commit-Position: refs/heads/master@{#10529}
2015-11-05 17:21:09 +00:00
Peter Boström
586c066cfc
Remove DrMemory gtest_exclude for dead test.
...
VideoSendStreamTest.RetransmitsNackOverRtxWithPacing no longer exists
and doesn't have to be suppressed.
BUG=webrtc:3471
TBR=kjellander@webrtc.org
Review URL: https://codereview.webrtc.org/1409933011 .
Cr-Commit-Position: refs/heads/master@{#10528}
2015-11-05 17:15:19 +00:00
henrik.lundin
a81a239ecd
Remove DrMemory suppressions for NetEq
...
BUG=webrtc:2515
NOTRY=true
TBR=kjellander@webrtc.org
Review URL: https://codereview.webrtc.org/1414283007
Cr-Commit-Position: refs/heads/master@{#10518}
2015-11-05 12:10:53 +00:00
Henrik Lundin
1a8240c32a
Disable P2PTransport...TestFailoverControlledSide on Memcheck
...
The test is flaky on the bot.
BUG=webrtc:5136
TBR=kjellander@webrtc.org
NOTRY=true
Review URL: https://codereview.webrtc.org/1426003003 .
Cr-Commit-Position: refs/heads/master@{#10441}
2015-10-29 08:28:32 +00:00
henrik.lundin
605db69130
Disable EndToEndTest.AssignsTrans... for memcheck
...
The test is flaky on the bot.
BUG=webrtc:5134
TBR=sprang@webrtc.org
NOTRY=true
Review URL: https://codereview.webrtc.org/1406063006
Cr-Commit-Position: refs/heads/master@{#10436}
2015-10-28 15:27:11 +00:00
Peter Boström
ba0f0a51d6
Disable flaky WebRtcVideoChannel2BaseTest.* on DrMemory/memcheck.
...
BUG=webrtc:4963
R=kjellander@webrtc.org
Review URL: https://codereview.webrtc.org/1388693002 .
Cr-Commit-Position: refs/heads/master@{#10163}
2015-10-05 08:11:07 +00:00
Henrik Kjellander
96a70f0183
Exclude WebRtcVideoChannel2BaseTest.AddRemoveCapturerMultipleSources on Dr Memory.
...
The test is flaky on Dr Memory (not at Linux memcheck as previously
committed in https://codereview.webrtc.org/1388663002 ).
BUG=5050
TBR=pbos@webrtc.org
Review URL: https://codereview.webrtc.org/1377183004 .
Cr-Commit-Position: refs/heads/master@{#10161}
2015-10-05 03:42:50 +00:00
Henrik Kjellander
b5fd46edec
Exclude WebRtcVideoChannel2BaseTest.AddRemoveCapturerMultipleSources on Memcheck
...
The test is flaky on Linux Memcheck.
BUG=5050
TBR=pbos@webrtc.org
Review URL: https://codereview.webrtc.org/1388663002 .
Cr-Commit-Position: refs/heads/master@{#10160}
2015-10-05 03:33:17 +00:00
Marco
f9c23ca1b9
Exclude WebRtcVideoChannel2BaseTest.GetStats on linux memcheck
...
BUG=webrtc:5048
TBR=pbos@webrtc.org
Review URL: https://codereview.webrtc.org/1377713005 .
Cr-Commit-Position: refs/heads/master@{#10152}
2015-10-02 18:26:14 +00:00
Peter Thatcher
7cbd188c5e
Remove GICE (again).
...
R=guoweis@webrtc.org
Review URL: https://codereview.webrtc.org/1353713002 .
Cr-Commit-Position: refs/heads/master@{#9979}
2015-09-18 01:55:03 +00:00
Åsa Persson
f08fb29aa5
Disable flaky test (WebRtcVideoChannel2Base.AddRemoveCapturer) on Dr. Memory.
...
BUG=webrtc:4963
R=kjellander@webrtc.org
Review URL: https://codereview.webrtc.org/1340433002 .
Cr-Commit-Position: refs/heads/master@{#9923}
2015-09-11 07:56:19 +00:00
guoweis
d12140a68e
Revert change which removes GICE.
...
There are still dependencies on this functionality.
TBR=pthatcher@webrtc.org
BUG=526399
Review URL: https://codereview.webrtc.org/1336553003
Cr-Commit-Position: refs/heads/master@{#9920}
2015-09-10 20:32:21 +00:00
Åsa Persson
d944067a03
Disable flaky test (WebRtcVideoChannel2Base.GetStatsMultipleSendStreams) on Dr. Memory.
...
BUG=webrtc:4963
R=kjellander@webrtc.org
Review URL: https://codereview.webrtc.org/1330893002 .
Cr-Commit-Position: refs/heads/master@{#9902}
2015-09-09 07:53:10 +00:00
Åsa Persson
76b3147bd8
Disable flaky WebRtcVideoChannel2Base, EndToEndTest tests on Dr. Memory.
...
BUG=webrtc:4963, webrtc:4979
R=kjellander@webrtc.org , pbos@webrtc.org
Review URL: https://codereview.webrtc.org/1315323008 .
Cr-Commit-Position: refs/heads/master@{#9895}
2015-09-08 14:21:44 +00:00
Marco
250bdc77f8
Exclude VideoSendStreamTest.VP9FlexMode on linux_memcheck.
...
BUG=webrtc:4969
TBR=stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1314823012 .
Cr-Commit-Position: refs/heads/master@{#9863}
2015-09-04 18:45:55 +00:00
Peter Thatcher
2159b89fa2
Reland "Remove GICE (gone forever!) and PORTALLOCATOR_ENABLE_SHARED_UFRAG (enabled forever)." becauese remoting code is using dead constants and breaks the FYI bots.
...
This reverts commit 5bdafd44c86ee46bd7e040f19828324583418b33.
Original CL: https://codereview.webrtc.org/1263663002/
R=guoweis@webrtc.org
Review URL: https://codereview.webrtc.org/1303393002 .
Cr-Commit-Position: refs/heads/master@{#9761}
2015-08-22 03:46:18 +00:00
Peter Boström
4b91bd0897
Move frame input (ViECapturer) to webrtc/video/.
...
Renames ViECapturer to VideoCaptureInput and initializes several
parameters on construction instead of setters.
Also removes an old deadlock suppression.
BUG=1695, 2999
R=asapersson@webrtc.org , mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/53559004 .
Cr-Commit-Position: refs/heads/master@{#9508}
2015-06-26 04:58:23 +00:00
Marco
0e1b229013
Disable TestGetAllPortsNoUdpSocketsNoTcpListen on valgrind memcheck.
...
Disable due to flakiness.
BUG=webrtc:4743
TBR=kjellander@webrtc.org
Review URL: https://codereview.webrtc.org/1170763004
Cr-Commit-Position: refs/heads/master@{#9395}
2015-06-08 21:32:14 +00:00
Erik Språng
3b2f67d90f
Disable some PortAllocatorTest on valgrind memcheck due to flakiness
...
BUG=webrtc:4743
R=kjellander@webrtc.org
Review URL: https://codereview.webrtc.org/1146923006
Cr-Commit-Position: refs/heads/master@{#9382}
2015-06-05 09:11:02 +00:00
Peter Boström
2251d6e174
Remove ViESender.
...
Registers transport on construction removing the need for ViESender as a
hop and removing a potential deadlock by removing RegisterSendTransport.
BUG=1695, 2999
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/57449004
Cr-Commit-Position: refs/heads/master@{#9309}
2015-05-28 12:10:48 +00:00
Peter Boström
36a1438a66
Remove ViEFrameProviderBase.
...
BUG=1695
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/49349004
Cr-Commit-Position: refs/heads/master@{#9252}
2015-05-21 15:00:05 +00:00
Minyue Li
261f644ce3
Suppressing VideoSendStreamTest.ReconfigureBitratesSetsEncoderBitratesCorrectly on Dr.Memory
...
BUG=4492
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/46789004
Cr-Commit-Position: refs/heads/master@{#9066}
2015-04-23 11:46:21 +00:00
tina.legrand@webrtc.org
c7d5a733b0
Disable flaky test on DrMemory bots
...
BUG=4454
R=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/47699004
Cr-Commit-Position: refs/heads/master@{#8793}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8793 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-19 14:44:13 +00:00
pbos@webrtc.org
119c12f6ef
Revert "Suppress memcheck error in video_engine_tests"
...
This reverts r8010. I removed TraceImpl::Run in r8529 so these added
suppressions no longer match any callstacks.
BUG=4147
R=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/40309004
Cr-Commit-Position: refs/heads/master@{#8692}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8692 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-12 10:37:21 +00:00
kjellander@webrtc.org
a743f6f17f
Widening memcheck suppressions for libjingle_peerconnection_unittest
...
Make the excluded tests filter match the ones for Dr Memory, since
these tests are probably flaky only due to the same slowdown caused
by memcheck as for Dr Memory.
BUG=4387
TBR=pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/46469004
Cr-Commit-Position: refs/heads/master@{#8624}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8624 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-06 07:16:46 +00:00
kjellander@webrtc.org
7008f2227c
Revert Clang roll in r8596 + add memcheck suppression.
...
The roll seems to cause leaks on our Linux Memcheck bot.
Added a suppression needed for Trusty in order to run
memcheck similar to the bot (that runs Precise).
Leave all the other source code edits from r8596 in place.
See also http://chromegw/i/client.webrtc/builders/Linux%20Memcheck/builds/3343
TBR=pbos@webrtc.org
TESTED=Can no longer repro memcheck failure with this patch applied:
GYP_DEFINES="build_for_tool=memcheck" webrtc/build/gyp_webrtc
ninja -C out/Release libjingle_peerconnection_unittest
tools/valgrind-webrtc/webrtc_tests.sh --test libjingle_peerconnection_unittest --tool memcheck --target Release --build-dir out --gtest_filter=WebRtcSessionTest.TestIncorrectMLinesInLocalAnswer
Review URL: https://webrtc-codereview.appspot.com/47419004
Cr-Commit-Position: refs/heads/master@{#8612}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8612 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-05 08:53:44 +00:00