admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
5,681 Commits 1 Branch 0 Tags
Commit Graph

2187 Commits

Author SHA1 Message Date
sergeyu@chromium.org
e384104166 Fix DesktopAndCursorComposer not to crash 
DesktopAndCursorComposer was crashing when screen/window
capturer returns a NULL frame due to an error.

BUG=crbug.com/344093
R=jiayl@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8769004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5573 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-18 23:26:34 +00:00
andrew@webrtc.org
27c6980239 Move the volume quantization workaround from VoE to AGC. 
Voice engine shouldn't really have to manage this. Instead, have AGC
keep track of the last input volume, so that it can avoid getting stuck
under coarsely quantized conditions.

Add a test to verify the behavior.

TESTED=unittests, and observed that AGC didn't get stuck on a MacBook
where this problem can actually occur.

R=bjornv@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8729004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5571 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-18 20:24:56 +00:00
solenberg@webrtc.org
00844d7bef Remove obsolete voe_unit_test. 
BUG=
R=henrika@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8839004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5570 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-18 18:50:50 +00:00
mflodman@webrtc.org
c320027d6a Don't print a warning if RTPPacketHistory::SetStorePacketStatus is called 
twice with the same settings.

Without this change, setting up a call with the new video API will
print a trace warning.

R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8859004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5566 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-18 14:51:00 +00:00
turaj@webrtc.org
2086e0fbf3 Remove unnecessary warnings. 
BUG=
TEST=try job
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8719005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5565 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-18 14:22:20 +00:00
solenberg@webrtc.org
a07923339b Remove external encryption API for VoE. 
BUG=
R=henrika@webrtc.org, henrikg@webrtc.org, phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8459004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5564 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-18 11:27:22 +00:00
sprang@webrtc.org
346094cb01 Incorrect overhead calculation when using FEC + RTP extension headers. 
When frames are fragmented inte multiple RTP packets in order to not
exceed a maximum packet size, the header overhead calculation must
take into account that FEC redundancy packets may use more than the
12 bytes of the basic RTP header. For example, a csrc list or extension
headers may be present.

BUG=2899
R=phoglund@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8769005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5562 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-18 08:40:33 +00:00
asapersson@webrtc.org
b60346e951 Reset estimate if no frame has been seen for a certain time (to avoid large jitter if stop sending). 
Add delay before start processing after a reset.

BUG=1577
R=mflodman@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8699006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5561 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-17 19:02:15 +00:00
henrik.lundin@webrtc.org
340746aa13 Misc small nits in NetEq 
Fixing a few small things found recently. This is mostly cosmetics.

R=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8749005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5558 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-17 11:37:16 +00:00
andrew@webrtc.org
f92aaff104 AudioProcessing is not a Module. 
Remove Module as the base class of AudioProcessing. The inherited
methods were all no-ops.

TBR=bjornv

Review URL: https://webrtc-codereview.appspot.com/8779004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5556 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-15 04:22:49 +00:00
bjornv@webrtc.org
e2fc13e42f Refactoring common_audio/signal_processing: Removed two macros used by isac only. 
Removed a macro for malloc() and one for free().  They are only used by the audio codec isac, where I replaced the macro with its implementation.
Further, the includes were updated with full paths and put in alphabetical order.

BUG=N/A
TESTED=trybots,module_tests,module_unittests
R=turaj@webrtc.org, turajs@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8449004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5554 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-14 23:12:34 +00:00
stefan@webrtc.org
9075d519a2 Adding a critical section missing in r5543. 
This fixes a race caught by the linux tsan bot.

R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8739004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5551 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-14 09:45:58 +00:00
andrew@webrtc.org
38bf249049 Initialize output_will_be_muted_. 
TBR=aluebs

Review URL: https://webrtc-codereview.appspot.com/8659004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5546 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-13 17:43:44 +00:00
asapersson@webrtc.org
8f690bc222 Increase overuse and normal use thresholds for Mac. 
BUG=1577
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8629004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5544 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-13 14:43:18 +00:00
stefan@webrtc.org
ae2563ae2f Fixes a race when writing to send_padding_. 
TEST=trybots
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8619004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5543 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-13 13:48:38 +00:00
henrik.lundin@webrtc.org
fcfc6a990e Small refactoring of NetEq unittest for CNG with clock drift 
Converting the test to a method within the test fixture, and setting
up two tests that call this method. One for positive and one for
negative clock drift. The one with positive clock drift is disabled
for now since it does not pass, but will be re-enabled shortly.

This change is only made for NetEq4.

R=tlegrand@google.com

Review URL: https://webrtc-codereview.appspot.com/8599004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5541 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-13 11:42:28 +00:00
andrew@webrtc.org
17342e5092 Add a method to inform AudioProcessing that its output will be muted. 
R=turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8559004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5538 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-12 22:28:31 +00:00
jiayl@webrtc.org
de782180b0 Change the type of propagation delta from int64 to int. 
The delta value never exceeds the range of int. Changing it to int will save memory and copying cost.

BUG=2910
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8549004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5537 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-12 19:19:23 +00:00
andrew@webrtc.org
07b5950c12 Initialize key_pressed_. 
Was resulting in an error on Mac Asan:
[ RUN      ] ApmTest.DebugDump
[libprotobuf FATAL ../../third_party/protobuf/src/google/protobuf/message_lite.cc:224] CHECK failed: !coded_out.HadError():

TBR=aluebs

Review URL: https://webrtc-codereview.appspot.com/8539004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5536 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-12 16:41:13 +00:00
andrew@webrtc.org
ce8e077cf0 Add a keypress field to the audioproc debug proto. 
Log the value in AudioProcessing, and unpack it to a new file in the
unpacking tool.

TESTED=
- The new tool can unpack old dumps.
- The old tool can unpack new dumps (without keypress.bool).
- Unpacking a new dump from voe_cmd_test produces a keypress.bool that
appears correct when examined.

R=aluebs@webrtc.org, bjornv@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8509005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5535 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-12 15:28:30 +00:00
pbos@webrtc.org
8118f1861f Set pacing bitrates in SetEncoder. 
Before the change no padding was allowed before the first remote bitrate
estimation was received. This bitrate estimation is based on what's
actually sent. In tests I set codec.startBitrate to 300 instead of
325, which incidentally means that only the first layer gets encoded.
As we only send ~150kbps instead of 300, the first REMB will
significantly pull down the remote bitrate estimate instead of keeping
the existing rate, even though there's no problem with the link.

This was detected in RampUpTest.PacingWithRtx,
(send_config.codec.startBitrate=300), which caused the tests to become a
lot slower, and flake out more. By allowing padding initially we're able
to keep our initial bitrate estimate.

R=stefan@webrtc.org
TEST=Running RampUpTest.WithPacingAndRtx with startBandwidth=300.
BUG=

Review URL: https://webrtc-codereview.appspot.com/8529004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5534 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-12 14:50:29 +00:00
solenberg@webrtc.org
67e70442b5 Remove unused and not working voe_extended_test. 
BUG=2913
R=henrikg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8439004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5533 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-12 09:58:49 +00:00
andrew@webrtc.org
b659e2844d Reduce mixing threshold in test to avoid flakiness. 
Flake observed here:
http://chromegw/i/client.webrtc/builders/Win32%20Release%20%5Blarge%20tests%5D/builds/953/steps/voe_auto_test/logs/stdio

TBR=andresp

Review URL: https://webrtc-codereview.appspot.com/8489004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5530 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-11 21:52:50 +00:00
andrew@webrtc.org
75dd2885c5 Add an interface for accepting keypress signals to AudioProcessing. 
R=aluebs@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8429004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5529 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-11 20:52:30 +00:00
andrew@webrtc.org
aa1278de46 Rename merged webrtc lib to libwebrtc_merged.a. 
The name "libwebrtc.a" was conflicting with the newish webrtc target,
resulting in this error:
$ ./webrtc/build/gyp_webrtc merged_lib.gyp
$ ninja -C out/Debug
ninja: warning: multiple rules generate libwebrtc.a. builds involving
this target will not be correct; continuing anyway
ninja: error: dependency cycle: no_op -> libwebrtc.a -> no_op

BUG=b/12955740
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8409005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5528 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-11 18:22:29 +00:00
fischman@webrtc.org
8685af7ea0 Remove "Too long processing time of Incoming frame" logspam. 
This isn't indicative of anything actionable and spams android logcat with times
in the 10-30ms range several times per second.

BUG=2732
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8419004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5527 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-11 17:48:11 +00:00
turaj@webrtc.org
a80be4b23c Add boundary checking to supress gcc 4.8.3 warning. 
BUG=2888
Test=try, voe_cmd_test

R=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8389004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5526 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-11 16:38:45 +00:00
solenberg@webrtc.org
fc320466d1 Remove ViE external encryption API. 
BUG=
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8079005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5525 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-11 15:27:49 +00:00
michaelbai@google.com
82ebb463fd Use libvpx's obj_int_extract and unpack_lib_posix to generate offset header file. 
This patch removes generate_asm_header.gypi and uses libvpx's obj_int_extract and
unpack_lib_posix to generate offset header files.

It make the simliar feature's implementation consistent.

R=andrew@webrtc.org, fischman@webrtc.org, fischman@chromium.org
BUG=334447

Committed: https://code.google.com/p/webrtc/source/detail?r=5517

Review URL: https://webrtc-codereview.appspot.com/7769006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5524 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-11 04:48:27 +00:00
andrew@webrtc.org
16c08f03da Restore mixing integration tests. 
These high level tests were disabled over time. Since they depend on
real-time results and the filesystem, they tended to be flaky on the
bots. We now give it a very generous 1 second to start up all channels
before verification and a further relaxed file length check. If we
continue to see problems, I will up the startup delay.

The restored tests would have caught the AGC bug fixed here:
https://code.google.com/p/webrtc/source/detail?r=5454

Add a new "real audio" stress test to exercise more code paths. This
would have caught the refactor bug fixed here:
https://code.google.com/p/webrtc/source/detail?r=5437

BUG=2164,2844
TESTED=git try. Verified it would have caught the aforementioned bugs
by reintroducing them.

R=andresp@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8009004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5522 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-10 23:04:39 +00:00
michaelbai@google.com
a65abf9d3a Revert "Use libvpx's obj_int_extract and unpack_lib_posix to generate offset header file." 
This reverts commit 7686f0ddda717a9e776be0e219f039f68a10f9ed.

BUG=

TBR=andrew@webrtc.org, fischman@webrtc.org,

Review URL: https://webrtc-codereview.appspot.com/8369004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5520 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-10 19:26:26 +00:00
jiayl@webrtc.org
1f64f06784 Add stats of incoming frame delays for debugging bandwidth estimation. 
BUG=crbug/338380
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8119004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5519 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-10 19:12:14 +00:00
michaelbai@google.com
7686f0ddda Use libvpx's obj_int_extract and unpack_lib_posix to generate offset header file. 
This patch removes generate_asm_header.gypi and uses libvpx's obj_int_extract and
unpack_lib_posix to generate offset header files.

It make the simliar feature's implementation consistent.

R=andrew@webrtc.org, fischman@webrtc.org, fischman@chromium.org
BUG=334447

Review URL: https://webrtc-codereview.appspot.com/7769006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5517 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-10 17:42:34 +00:00
sprang@webrtc.org
6f0ca57fb2 Add experiment: SkipEncodingUnusedStreams 
BUG=
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7889004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5514 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-10 09:20:51 +00:00
kjellander@webrtc.org
607c805b87 Roll chromium_revision 245382:249215 
The find_depot_tools.py is needed to workaround the import
error we get from gyp_chromium when importing it in
webrtc/build/gyp_webrtc (to avoid code duplication).
gyp_chromium introduced a dependency on it in
http://crrev.com/245412 but as we cannot sync all of Chrome's
src/tools (it's quite big), we'll work around this by
adding an empty find_depot_tools module.

The removal of the Cygwin relates to
http://crrev.com/248802 which is a step on the way to remove
Cygwin in Chromium. We seem to already be able to remove it
entirely for WebRTC though.

Changes in the isolate framework required us to update our
copies of the isolate.gypi files.

BUG=none
TEST=trybots passing on all platforms
R=andrew@webrtc.org, fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8099004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5512 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-09 18:38:31 +00:00
sergeyu@chromium.org
ad3035fc9e Fix WindowCapturerWin to unselect bitmap before destroying DC. 
BUG=https://code.google.com/p/webrtc/issues/detail?id=2901
R=wez@chromium.org

Review URL: https://webrtc-codereview.appspot.com/8229004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5504 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-07 21:24:04 +00:00
sprang@webrtc.org
9510e53cc0 Make VideoReceiveStream::GetStats() const. 
BUG=
R=mflodman@webrtc.org, pbos@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8169004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5501 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-07 15:32:45 +00:00
sprang@webrtc.org
09315705b9 Wire up statistics in video receive stream of new API 
This CL includes Call tests that test both send and receive sides.

BUG=2235
R=mflodman@webrtc.org, pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8049004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5499 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-07 12:06:29 +00:00
stefan@webrtc.org
77c917a6ee Plot the capacity of a trace-based delivery filter. 
Breaks out the instantaneous rate counters to its own class.

R=solenberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7999005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5494 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-06 16:34:47 +00:00
michaelbai@google.com
f928f5c87c Use system's cpu_features library 
Remove the copied cpu_featrues.c/h
Use the NDK's cpu_features.a or the one build from android source.
This issue blocked libvpx roll.

BUG=334447
R=andrew@webrtc.org, fischman@webrtc.org, henrike@webrtc.org, wjia@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8019004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5492 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-05 18:43:46 +00:00
stefan@webrtc.org
c88d3368d5 Add delay and send/receive throughput plots to BWE simulation. 
R=mflodman@webrtc.org, solenberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7999004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5491 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-05 15:57:14 +00:00
henrik.lundin@webrtc.org
75642fcd9a Implementing replacement audio support in neteq_rtpplay 
This CL makes it possible to replace the payload in an RTP stream
with audio from another (PCM) file. The new payload will be encoded as
PCM16b. The RTP headers will be updated to reflect this change of
payload type.

BUG=2834
R=turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7659004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5490 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-05 08:49:13 +00:00
henrik.lundin@webrtc.org
e6ab21b9ca Fixing a bug in DummyRTPpacket 
This bug caused writing outside allocated memory when RTP header
extensions were used.

BUG=2834
TBR=turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8009005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5489 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-05 08:46:46 +00:00
andrew@webrtc.org
54744918ef Update AudioProcessing::Create docs. 
TBR=bjornv

Review URL: https://webrtc-codereview.appspot.com/8039004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5488 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-05 06:30:29 +00:00
jiayl@webrtc.org
20a60ea39d Fix a cursor capturing issue on Windows. 
The input position to WindowFromPoint should be relative to the desktop, not
relative to the window; if the result from WindowFromPoint is a child window
of the shared top window, it should be captured.

BUG=
R=sergeyu@chromium.org

Review URL: https://webrtc-codereview.appspot.com/7959004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5487 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-04 17:49:12 +00:00
stefan@webrtc.org
0e5a2b5de6 Handle the invalid case of setting multiple stream_bitrates if there is only a single send stream registered. 
This can happen when switching between multiple streams and a single while getting feedback from the receiver.

BUG=2881
TEST=trybots
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7899004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5486 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-04 14:38:25 +00:00
pbos@webrtc.org
3e6c41c48f Revert "Disable the test: DtmfTest.ManualSuccessfullySendsIn/OutOfBandTelephoneEvents" 
This reverts commit r5479.

R=henrika@webrtc.org
BUG=2880

Review URL: https://webrtc-codereview.appspot.com/7989004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5485 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-04 10:45:14 +00:00
pbos@webrtc.org
064b32acbb Fix locking in LoopBackTransport::StorePacket. 
The critical section in StorePacket was unnamed and only existed in
expression scope. Added GUARDED_BY annotations (which caught the bug),
then fixed it by naming the variable.

BUG=2880
R=henrika@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7979004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5484 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-04 09:42:02 +00:00
andrew@webrtc.org
f6a638e001 Trivial rename of non-compile time consts. 
R=henrik.lundin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7669006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5482 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-04 01:31:28 +00:00
marpan@webrtc.org
f6b8f496ee Disable the test: DtmfTest.ManualSuccessfullySendsIn/OutOfBandTelephoneEvents 
Issue: https://code.google.com/p/webrtc/issues/detail?id=2880

R=andrew@webrtc.org
TBR=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7939004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5479 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-02-03 21:34:35 +00:00