admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
5,681 Commits 1 Branch 0 Tags
Commit Graph

35 Commits

Author SHA1 Message Date
henrike@webrtc.org
f2aafe4355 Added include of assert.h for files calling assert but missing the include. 
BUG=N/A
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19409005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6022 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-04-29 17:54:17 +00:00
andrew@webrtc.org
8f69330310 Replace scoped_array<T> with scoped_ptr<T[]>. 
scoped_array is deprecated. This was done using a Chromium clang tool:
http://src.chromium.org/viewvc/chrome/trunk/src/tools/clang/rewrite_scoped_ar...

except for the few not-built-on-Linux files which were updated manually.

TESTED=trybots
BUG=2515
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12429004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5985 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-04-25 23:10:28 +00:00
kjellander@webrtc.org
7de47bce12 Remove use of tmpnam. 
This solves compilation with the Mac SDK 10.9.

BUG=3120, 3151
TEST=git try -t modules_tests:VideoProcessorIntegrationTest*
R=fischman@webrtc.org, henrike@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/10739005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5917 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-04-16 08:04:26 +00:00
andrew@webrtc.org
9080518a39 Restore severity precondition to logging.h. 
I mistakenly ommitted the checks when logging.h was ported from
libjingle to webrtc. This caused a significant CPU cost for logs which
were later filtered out anyway.

Verified with LS_VERBOSE logging in neteq4, running:
$ out/Release/modules_unittests \
--gtest_filter=NetEqDecodingTest.TestBitExactness \
--gtest_repeat=50 > time.txt
$ grep "case ran" time.txt | grep "[0-9]* ms" -o | sort

Results on a MacBook Retina, averaged over 5 runs:
Verbose logs disabled:                          666 ms
Exisiting implementation, verbose logs enabled: 944 ms (1.42x)
New implementation, verbose logs enabled:       673 ms (1.01x)

BUG=2314
R=henrik.lundin@webrtc.org, henrike@webrtc.org, kjellander@webrtc.org, turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2160005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4682 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-05 16:40:43 +00:00
kjellander@webrtc.org
de499669ef Fix fileutils.cc for tests running under Win memory tools. 
On Windows, when tests are run under memory tools like
DrMemory and TSan, slashes occur in the path as directory
separators. This makes the fileutils.cc fail to figure out
the project root, making paths to resource files invalid.

By replacing slashes in the path with backslashes for Windows
this can be fixed.

BUG=2318
TEST=running the same command as the bot locally, succeeding after this patch is applied.
R=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2137004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4640 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-29 11:26:41 +00:00
kjellander@webrtc.org
f746f4f07c Fix metrics_unittests on Android. 
The metrics_unittests tried to write an empty file to the
current working directory, which caused a crash on Android. By
using the output folder instead, this is avoided.
This makes it possible to re-enable the tests disabled in r4474
and also remove the empty dummy test added in r4627.

BUG=1882,
TEST=Setup a Chromium+WebRTC checkout as described in issue 1882
. build/android/envsetup.sh
export GYP_DEFINES="$GYP_DEFINES include_tests=1 enable_tracing=1"
gclient runhooks
ninja -C out/Release metrics_unittests_apk
build/android/test_runner.py gtest -s metrics_unittests --verbose --release

R=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2127006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4634 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-28 18:31:54 +00:00
kjellander@webrtc.org
e141373b8a Add isolate configuration for Android for all tests. 
In https://code.google.com/p/webrtc/source/detail?r=4407
henrike@ added the path to the WebRTC resources and
data directories for Android that are required in order to
use isolate for test execution on Android.

This CL adds similar entries to the rest of the .isolate
files added in
https://code.google.com/p/webrtc/source/detail?r=4590.

It also removes three accidentally added .isolate files that originated
from old test names:
* audio_device_test_api
* video_capture_module_test
* video_render_module_test

BUG=1882,1916
TEST=trybots passing.
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2107004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4627 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-27 12:10:09 +00:00
pbos@webrtc.org
12dc1a38ca Switch C++-style C headers with their C equivalents. 
The C++ headers define the C functions within the std:: namespace, but
we mainly don't use the std:: namespace for C functions. Therefore we
should include the C headers.

BUG=1833
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1917004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4486 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-05 16:22:53 +00:00
henrike@webrtc.org
89c674053e Adds all unittests to android NDK-APK framework. 
BUG=N/A
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1872004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4474 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-02 16:53:47 +00:00
pbos@webrtc.org
e6c3966530 Fix some chromium-style warnings in webrtc/test/ 
BUG=163
R=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1907004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4428 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-07-30 13:08:38 +00:00
pbos@webrtc.org
fc496d95df Add root_path_android.cc to webrtc/test/Android.mk. 
Fixes the broken android-platform build (build that uses .mk files).

TBR=andrew@webrtc.org,henrike@webrtc.org
BUG=

Review URL: https://webrtc-codereview.appspot.com/1777004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4314 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-07-09 15:24:16 +00:00
henrike@webrtc.org
a950300b0e Disables unit tests that don't work on Android for Android. 
BUG=N/A
R=andrew@webrtc.org, kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1747004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4306 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-07-08 18:53:54 +00:00
henrike@webrtc.org
34773d9b6b Unreverts revert: Makes it possible to find files used by some unit tests when running them as Chrome native tests. 
TBR=andrew@webrtc.org

BUG=N/A

Review URL: https://webrtc-codereview.appspot.com/1754005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4303 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-07-08 14:55:23 +00:00
pbos@webrtc.org
db7d82f26f Revert 4298 "Makes it possible to find files used by some unit t..." 
> Makes it possible to find files used by some unit tests when running them as Chrome native tests.
> 
> BUG=N/A
> R=andrew@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/1749004

Broke Android NDK/Android.mk builds.

TBR=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1752006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4299 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-07-05 08:49:09 +00:00
henrike@webrtc.org
caf2fcca6a Makes it possible to find files used by some unit tests when running them as Chrome native tests. 
BUG=N/A
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1749004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4298 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-07-05 04:15:38 +00:00
pbos@webrtc.org
9aca5b34e1 Remove #pragma once 
BUG=1830
R=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1568004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4130 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-05-29 13:19:09 +00:00
pbos@webrtc.org
34741c8b0e Include files from webrtc/.. paths in test/ 
BUG=1662
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1549004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4105 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-05-27 08:02:22 +00:00
andrew@webrtc.org
59aaebc3cd Add an option to override the TestToStderr trace printout time. 
This is useful for offline file-based tests.

R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1407004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3960 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-05-05 19:44:19 +00:00
kjellander@webrtc.org
f09016744d Revert "Updating test file contents to emmastjernloef" 
This reverts r3861

TEST=none
BUG=none
TBR=phoglund

Review URL: https://webrtc-codereview.appspot.com/1317005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3863 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-04-17 14:59:28 +00:00
kjellander@webrtc.org
11959d3476 Updating test file contents to emmastjernloef 
This way, we honour Emma Stjernlöf in the Stockholm office.

TEST=test_support_unittests
BUG=none

Review URL: https://webrtc-codereview.appspot.com/1320009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3861 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-04-17 13:58:54 +00:00
pbos@webrtc.org
a5f1787f63 WebRtc_Word32 -> int32_t in test/ 
BUG=314

Review URL: https://webrtc-codereview.appspot.com/1302004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3794 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-04-09 11:10:21 +00:00
andrew@webrtc.org
b87cc85beb Refactor unittest trace printouts to a separate class. 
This allows other tests/tools which don't depend on TestSuite to reuse the functionality.

BUG=

Review URL: https://webrtc-codereview.appspot.com/1245004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3721 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-03-25 16:23:37 +00:00
andrew@webrtc.org
83663efba4 Replace gtest_prod.h include with our own FRIEND_TEST macro. 
This small bit of duplication avoids depending on any part of GTest in
production code.

TBR=phoglund
BUG=1395

Review URL: https://webrtc-codereview.appspot.com/1098013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3541 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-02-19 23:43:57 +00:00
kjellander@webrtc.org
9c4e662ea8 Fix Windows x64 errors in video_codecs_test_framework 
Fixed a few size_t converted to int warnings (interpreted as errors).
Fixed cpplint warnings.

BUG=webrtc:1323
TEST=manual compile on Windows with GYP_DEFINES=target_arch=x64 and
ninja -C out\Debug_x64 (also compiled with Release_x64)

Review URL: https://webrtc-codereview.appspot.com/1097011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3507 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-02-13 09:35:12 +00:00
kjellander@webrtc.org
fa53d8717c Fixing/disabling Windows x64 warnings 
Disabled MSVC #4267 warnings in common.gypi to enable x64 builds
for Windows.
Fixed MSVC #4267 warnings in test/testsupport.
Added third_party/directxsdk to .gitignore.

With http://review.webrtc.org/1070008 landed, this should make it possible
to build for x64 on Windows.

BUG=1348
TEST=Compiling with http://review.webrtc.org/1070008 applied:
set GYP_DEFINES="target_arch=x64"
set GYP_GENERATORS=ninja
gclient sync
ninja -C out\Debug_x64

Review URL: https://webrtc-codereview.appspot.com/1060008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3464 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-02-04 10:07:17 +00:00
kjellander@webrtc.org
b2d7497faf Fix Win64 warnings 
This change fixes warnings about converting size_t to int.

BUG=webrtc:1323
TEST=trybots passing

Review URL: https://webrtc-codereview.appspot.com/1064004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3419 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-01-26 16:36:40 +00:00
phoglund@webrtc.org
d005468e9b Generalized mechanism for excluding gtests on platforms, disabled broken tests on mac. 
BUG=1268
TEST=vie_auto_test on mac and linux
TBR=mflodman, kjellander

Review URL: https://webrtc-codereview.appspot.com/1027006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3347 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-01-09 16:53:42 +00:00
mikhal@webrtc.org
658d423e81 Using Convert in lieu of ExtractBuffer: Less error prone (as we don't need to compute buffer sizes etc.). This cl is first in a series (doing all of WebRtc would make it quite a big cl). While at it, fixing a few headers. 
BUG=988

Review URL: https://webrtc-codereview.appspot.com/995014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3343 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-01-08 19:19:59 +00:00
phoglund@webrtc.org
5b689efe8e Will now only require near-perfect PSNR and SSIM. 
BUG=
TEST=Ran test and checked we accept somewhat lower values.

Committed: https://code.google.com/p/webrtc/source/detail?r=3269

Review URL: https://webrtc-codereview.appspot.com/964031

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3278 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-12-13 10:15:06 +00:00
andrew@webrtc.org
d8aeb30d55 Revert 3269 
> Will now only require near-perfect PSNR and SSIM.
> 
> BUG=
> TEST=Ran test and checked we accept somewhat lower values.
> 
> Review URL: https://webrtc-codereview.appspot.com/964031

TBR=phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/989004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3270 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-12-12 20:58:32 +00:00
phoglund@webrtc.org
735a6cec96 Will now only require near-perfect PSNR and SSIM. 
BUG=
TEST=Ran test and checked we accept somewhat lower values.

Review URL: https://webrtc-codereview.appspot.com/964031

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3269 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-12-12 15:20:34 +00:00
phoglund@webrtc.org
273ccad59d Fixed standard PSNR/SSIM test. 
BUG=1103

Review URL: https://webrtc-codereview.appspot.com/971005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3197 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-11-29 10:08:16 +00:00
andrew@webrtc.org
2009f6b236 Add Chromium's perf_test to testsupport. 
Review URL: https://webrtc-codereview.appspot.com/936027

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3133 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-11-20 00:20:20 +00:00
kjellander@webrtc.org
a56d759723 Removing use of raw buffers for I420PSNR and I420SSIM functions 
BUG=none
TEST=metrics_unittest, video_codecs_test_framework_integrationtests in normal and memcheck mode.

Review URL: https://webrtc-codereview.appspot.com/937013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3041 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-11-02 22:36:14 +00:00
andrew@webrtc.org
14b43beb7c Move src/ -> webrtc/ 
TBR=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/915006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2963 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-10-22 18:19:23 +00:00