118 Commits

Author SHA1 Message Date
tommi@webrtc.org
8187877402 Reland 3135 - Previous failure was bot flakiness.
*****

Restructure the video_capture code a bit to make room for a Media Foundation class implementation.
This change includes the following:

* Skeleton classes for a couple of base MediaFoundation classes (no code yet).  See *_mf.*.
* Renaming the DirectShow based implementation from "_windows" to "_ds".
* Move the VideoCaptureImpl::CreateDeviceInfo() method into video_capture_factory_windows.cc
  The reason for this is that that's where the other VideoCaptureImpl factory function is
  and the factory function won't be implementation specific.
* Removed use of <initguid.h> from a header file to avoid defining the same guids in multiple object files.
  (more info here: http://msdn.microsoft.com/en-us/library/windows/desktop/dd375463(v=vs.85).aspx)
* Moved a couple of global variables from the capture_delay_values_windows.h header and into
  device_info_ds.cc since that's the only file that uses those variables.
* Delete capture_delay_values_windows.h.
* Added a factory function: DeviceInfoDS::Create() that'll create the DirectShow specific implementation.

TEST=This is mostly moving code around.  The code that is added, is currently "dead". No manual testing needed.
BUG=chromium:140545
Review URL: https://webrtc-codereview.appspot.com/967008

TBR=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/934017

TBR=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/934018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3137 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-20 13:35:33 +00:00
tommi@webrtc.org
951b6c404a Revert 3135 - This broke the Mac bots somehow. Here's the error:
[ RUN      ] ViEStandardIntegrationTest.RunsBaseTestWithoutErrors
2012-11-20 13:06:59.625 vie_auto_test[4001:f07] An uncaught exception was raised
2012-11-20 13:06:59.625 vie_auto_test[4001:f07] Error (1000) creating CGSWindow on line 259
2012-11-20 13:06:59.670 vie_auto_test[4001:f07] (
	0   CoreFoundation                      0x9a4e912b __raiseError + 219
	1   libobjc.A.dylib                     0x95ee252e objc_exception_throw + 230
	2   CoreFoundation                      0x9a448bbb +[NSException raise:format:] + 139
	3   AppKit                              0x996b4757 _NSCreateWindowWithOpaqueShape2 + 302
	4   AppKit                              0x996b2f40 -[NSWindow _commonAwake] + 1823
	5   AppKit                              0x9966fa77 -[NSWindow _commonInitFrame:styleMask:backing:defer:] + 1652
	6   AppKit                              0x9966eb3f -[NSWindow _initContent:styleMask:backing:defer:contentView:] + 1063
	7   AppKit                              0x9966e704 -[NSWindow initWithContentRect:styleMask:backing:defer:] + 70
	8   vie_auto_test                       0x0015c232 -[TestCocoaUi createWindows:] + 338
	9   libobjc.A.dylib                     0x95eef5d3 -[NSObject performSelector:withObject:] + 70
	10  Foundation                          0x969050c0 __NSThreadPerformPerform + 395
	11  CoreFoundation                      0x9a3bf66f __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 15
	12  CoreFoundation                      0x9a3bf099 __CFRunLoopDoSources0 + 233
	13  CoreFoundation                      0x9a3e4e46 __CFRunLoopRun + 934
	14  CoreFoundation                      0x9a3e463a CFRunLoopRunSpecific + 378
	15  CoreFoundation                      0x9a3e44ab CFRunLoopRunInMode + 123
	16  Foundation                          0x9690d946 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 278
	17  vie_auto_test                       0x002e490a main + 522
	18  vie_auto_test                       0x000b1835 start + 53

*****


Restructure the video_capture code a bit to make room for a Media Foundation class implementation.
This change includes the following:

* Skeleton classes for a couple of base MediaFoundation classes (no code yet).  See *_mf.*.
* Renaming the DirectShow based implementation from "_windows" to "_ds".
* Move the VideoCaptureImpl::CreateDeviceInfo() method into video_capture_factory_windows.cc
  The reason for this is that that's where the other VideoCaptureImpl factory function is
  and the factory function won't be implementation specific.
* Removed use of <initguid.h> from a header file to avoid defining the same guids in multiple object files.
  (more info here: http://msdn.microsoft.com/en-us/library/windows/desktop/dd375463(v=vs.85).aspx)
* Moved a couple of global variables from the capture_delay_values_windows.h header and into
  device_info_ds.cc since that's the only file that uses those variables.
* Delete capture_delay_values_windows.h.
* Added a factory function: DeviceInfoDS::Create() that'll create the DirectShow specific implementation.

TEST=This is mostly moving code around.  The code that is added, is currently "dead". No manual testing needed.
BUG=chromium:140545
Review URL: https://webrtc-codereview.appspot.com/967008

TBR=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/934017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3136 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-20 12:17:05 +00:00
tommi@webrtc.org
704eb8fa15 Restructure the video_capture code a bit to make room for a Media Foundation class implementation.
This change includes the following:

* Skeleton classes for a couple of base MediaFoundation classes (no code yet).  See *_mf.*.
* Renaming the DirectShow based implementation from "_windows" to "_ds".
* Move the VideoCaptureImpl::CreateDeviceInfo() method into video_capture_factory_windows.cc
  The reason for this is that that's where the other VideoCaptureImpl factory function is
  and the factory function won't be implementation specific.
* Removed use of <initguid.h> from a header file to avoid defining the same guids in multiple object files.
  (more info here: http://msdn.microsoft.com/en-us/library/windows/desktop/dd375463(v=vs.85).aspx)
* Moved a couple of global variables from the capture_delay_values_windows.h header and into
  device_info_ds.cc since that's the only file that uses those variables.
* Delete capture_delay_values_windows.h.
* Added a factory function: DeviceInfoDS::Create() that'll create the DirectShow specific implementation.

TEST=This is mostly moving code around.  The code that is added, is currently "dead". No manual testing needed.
BUG=chromium:140545
Review URL: https://webrtc-codereview.appspot.com/967008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3135 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-20 11:27:25 +00:00
mikhal@webrtc.org
0f34fd7660 Updating Memory allocation for rotation and related tests.
Review URL: https://webrtc-codereview.appspot.com/943004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3132 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-19 21:15:35 +00:00
tommi@webrtc.org
12773eaa8c Minor cleanup of the videocapture code. No "real" code change :)
Remove declaration of a function that doesn't exist.
Remove call to GetProductId from video_capture_factory_windows that's not necessary.
This was the only dependency on device_info_windows.h outside of video_capture_windows.cc.

TEST=There's no code change, so no manual testing is required.
BUG=none
Review URL: https://webrtc-codereview.appspot.com/936025

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3114 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-16 09:03:12 +00:00
tommi@webrtc.org
2d0b81b8af Fix sorting issues in video_capture.gypi.
No code change.

TBR=henrikg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/937022

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3104 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-15 10:30:57 +00:00
mikhal@webrtc.org
701567a864 Capture module: Fixing size computation for u and v planes
TEST=trybots

Review URL: https://webrtc-codereview.appspot.com/932017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3070 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-09 18:45:12 +00:00
leozwang@webrtc.org
06d72d881f Add Android OWNER files
Message:
Add OWNER files so I can review and approve changes for Android.
I also should be owner for all .mk file, but it's OK for now,
please review.

BUG=None
TEST=None
Review URL: https://webrtc-codereview.appspot.com/932016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3069 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-09 17:51:55 +00:00
mikhal@webrtc.org
ac993fef2c Adding codecType to OnIncomingCapturedEncodedFrame
partially reverting r3013.

Review URL: https://webrtc-codereview.appspot.com/965010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3055 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-07 17:18:04 +00:00
kjellander@webrtc.org
f17d7d1dde Using proper GYP references for Strmiids.lib on Windows
This makes it possible to link properly using Ninja on Windows.

Another issue exists due to the path containing spaces in webrtc/modules/video_capture/windows/direct_show_base_classes.gyp but that can be worked around by copying the baseclasses dir from the SDK into a path without spaces and then overriding the direct_show_dir variable with GYP_DEFINES.

Example:

set GYP_DEFINES=direct_show_dir=C:/WinSDKv7.1_directshow_baseclasses/
gclient runhooks
ninja -C out/Debug

Notice that the ending slash is needed for the direct_show_dir variable.

BUG=none
TEST=local compilation with the baseclasses copied from Windows SDK 7.1 into C:/WinSDKv7.1_directshow_baseclasses.

Review URL: https://webrtc-codereview.appspot.com/936014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3043 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-05 13:13:05 +00:00
andrew@webrtc.org
e034f21d8d Remove video_capture/test/android
Review URL: https://webrtc-codereview.appspot.com/937011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3028 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-31 05:36:50 +00:00
andrew@webrtc.org
94caca7105 Reorganize modules/video_capture.
- The usual elimination of main/source etc.
- Fully qualify "public" includes.
- Use lowercase for all directory names.

Review URL: https://webrtc-codereview.appspot.com/933010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3025 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-30 21:58:00 +00:00
mikhal@webrtc.org
91a0340a61 Adding stride alignment
TEST= common_video_unittests and video_capture_module_test

BUG=985

Review URL: https://webrtc-codereview.appspot.com/965005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3023 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-30 19:19:32 +00:00
mikhal@webrtc.org
e83d3111d4 Removing codecType from capture API
Review URL: https://webrtc-codereview.appspot.com/964005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3013 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-29 15:59:40 +00:00
henrike@webrtc.org
bc48b8c803 Fixes http://code.google.com/p/webrtc/issues/detail?id=1002
BUG=1002

Review URL: https://webrtc-codereview.appspot.com/931006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3002 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-25 22:01:25 +00:00
mikhal@webrtc.org
9fedff7c17 Switching to I420VideoFrame
Review URL: https://webrtc-codereview.appspot.com/922004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2983 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-24 18:33:04 +00:00
andrew@webrtc.org
be8ec386c4 Fix a few include paths and update include TODO.
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/919007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2967 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-22 21:51:58 +00:00
andrew@webrtc.org
14b43beb7c Move src/ -> webrtc/
TBR=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/915006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2963 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-22 18:19:23 +00:00