18 Commits

Author SHA1 Message Date
tommi@webrtc.org
361981faa8 Use scoped_ptr for ThreadWrapper::CreateThread.
BUG=
R=henrika@webrtc.org, pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/45799004

Cr-Commit-Position: refs/heads/master@{#8794}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8794 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-19 14:45:42 +00:00
tommi@webrtc.org
fbef5c6293 Remove lock in ViEFrameProviderBase::IsFrameCallbackRegistered.
After looking at how this class is used I discovered that the threading model isn't completely crazy and that we can remove a lock from a method that's causing the most contention in getStats right now (and probably many other places).  IsFrameCallbackRegistered() looks innocent enough, but it contented with the frame encoder, which can make it wait for tens of milliseconds, unnecessarily.

In addition to removing the lock, I:

* Documented the threading model
* Added checks to guard against regressions
* Reduced lock scope in the Deregister function (not calling out to the notification while holding the lock).
*  made virtual functions non-virtual (since they're not really being overriden) and removed unnecessary method that, if called by other threads than the ctor thread, returned a value that wasn't necessarily correct.

BUG=2822
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/40859004

Cr-Commit-Position: refs/heads/master@{#8531}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8531 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-27 15:43:23 +00:00
pbos@webrtc.org
ece3890d3a Report total bitrate for all streams in GetStats.
This regression wasn't caught because I accidentally disabled multiple
streams for EndToEndTest.GetStats in a refactoring.

R=stefan@webrtc.org, xians@webrtc.org
BUG=1667

Review URL: https://webrtc-codereview.appspot.com/27179004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7701 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-14 11:52:04 +00:00
solenberg@webrtc.org
fc320466d1 Remove ViE external encryption API.
BUG=
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8079005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5525 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-11 15:27:49 +00:00
asapersson@webrtc.org
54a05518e2 Increase run-time for full stack test for the rtt to be added reliably to the delay measurement.
BUG=2592
R=holmer@google.com, phoglund@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/3719004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5146 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-21 07:45:08 +00:00
fischman@webrtc.org
4e65e07e41 VideoCaptureAndroid: rewrote the (standalone) implementation of video capture on Android.
Besides being ~40% the size of the previous implementation, this makes it so
that VideoCaptureAndroid can stop and restart capture, which is necessary to
support onPause/onResume reasonably on Android.

BUG=1407
R=henrike@webrtc.org, wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2334004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4915 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-03 18:23:13 +00:00
pbos@webrtc.org
12dc1a38ca Switch C++-style C headers with their C equivalents.
The C++ headers define the C functions within the std:: namespace, but
we mainly don't use the std:: namespace for C functions. Therefore we
should include the C headers.

BUG=1833
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1917004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4486 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-05 16:22:53 +00:00
mflodman@webrtc.org
1c986e7c89 Removed ViE file API.
R=asapersson@webrtc.org, niklas.enbom@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1723004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4267 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-06-26 09:12:49 +00:00
pbos@webrtc.org
4079c31c0a Include gflags with "gflags/gflags.h" instead of <>
BUG=
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1551004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4120 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-28 10:38:11 +00:00
pbos@webrtc.org
21632124dd Include gflags properly and X11 include order in VideoEngine.
BUG=

TBR=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1500004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4057 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-17 14:25:02 +00:00
pbos@webrtc.org
f5d4cb1958 Include files from webrtc/.. paths in video_engine/
BUG=1662
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1492004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4056 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-17 13:44:48 +00:00
pbos@webrtc.org
3004c79c6a Fix clang errors in non-GYP_DEFINES=clang=1 build
BUG=1623
R=stefan@webrtc.org, tina.legrand@webrtc.org, tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1368004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3968 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-07 12:36:21 +00:00
stefan@webrtc.org
1960219530 Make protection method, filename and resolution configurable for FullStackTest.
Review URL: https://webrtc-codereview.appspot.com/991007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3315 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-19 12:45:16 +00:00
stefan@webrtc.org
91c91df35a Track the actual render time rather than the decode time.
Review URL: https://webrtc-codereview.appspot.com/993004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3282 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-13 15:26:01 +00:00
stefan@webrtc.org
71258c594b Add a third full stack test and support for random jitter in ext transport.
BUG=

Review URL: https://webrtc-codereview.appspot.com/975005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3260 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-11 15:14:56 +00:00
phoglund@webrtc.org
849fb8ebd2 Removed codec comparison test: it didn't work and probably never will.
The central problem is that we cannot sync the frames in the input video with the output video, which makes PSNR/SSIM go crazy. The test only appeared to succeed earlier due to a bug in the test. We can consider this a failed experiment, but we did learn a lot from it :)

BUG=550

Review URL: https://webrtc-codereview.appspot.com/969006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3155 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-23 09:21:44 +00:00
andrew@webrtc.org
9841d92b8d Reorganize modules/video_render.
The usual elimination of main/source etc.

Review URL: https://webrtc-codereview.appspot.com/929011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3027 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-31 05:22:11 +00:00
andrew@webrtc.org
14b43beb7c Move src/ -> webrtc/
TBR=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/915006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2963 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-22 18:19:23 +00:00