pbos@webrtc.org
5a477a0bc6
DCHECK frame parameters instead of return codes.
...
We should never be creating video frames without width/height. If these
DCHECKs fire we should be fixing the calling code instead.
BUG=4359
R=magjed@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/46639004
Cr-Commit-Position: refs/heads/master@{#8779}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8779 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-18 14:12:38 +00:00
magjed@webrtc.org
2056ee3e3c
Revert "Changed argument occurences of const I420VideoFrame* to const I420VideoFrame& and non-const I420VideoFrame& to I420VideoFrame*."
...
This reverts commit r8731.
Reason for revert: Breakes Chromium FYI bots.
TBR=hbos, tommi
Review URL: https://webrtc-codereview.appspot.com/40359004
Cr-Commit-Position: refs/heads/master@{#8733}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8733 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-16 13:48:18 +00:00
hbos@webrtc.org
2dc5fa69b2
Changed argument occurences of const I420VideoFrame* to const I420VideoFrame& and non-const I420VideoFrame& to I420VideoFrame*.
...
R=magjed@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/40299004
Cr-Commit-Position: refs/heads/master@{#8731}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8731 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-16 13:02:19 +00:00
guoweis@webrtc.org
59140d6a5a
Remove VideoRotationMode to VideoRotation.
...
With this change, there is only one copy of rotation enum.
BUG=4145
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/48369004
Cr-Commit-Position: refs/heads/master@{#8654}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8654 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-09 17:08:20 +00:00
magjed@webrtc.org
fd33293d58
I420VideoFrame: Remove functions set_width and set_height
...
This is a partial reland of https://webrtc-codereview.appspot.com/39939004/ .
The functions set_width and set_height in I420VideoFrame are not needed and just add complexity.
R=perkj@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/41009004
Cr-Commit-Position: refs/heads/master@{#8556}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8556 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-02 13:57:44 +00:00
magjed@webrtc.org
7400e0b876
Revert "I420VideoFrame: Remove functions set_width, set_height, and ResetSize"
...
This reverts commit r8434.
Reason for revert: Introduced a race condition. If ViECaptureProcess() -> SwapCapturedAndDeliverFrameIfAvailable() is called twice without a call to OnIncomingCapturedFrame() in between (with both captured_frame_ and deliver_frame_ populated), an old frame will be delivered again, since captured_frame_->IsZeroSize() will never be true.
BUG=4352
TBR=perkj@webrtc.org , stefan@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/40129004
Cr-Commit-Position: refs/heads/master@{#8530}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8530 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-27 15:19:18 +00:00
kwiberg@webrtc.org
00b8f6b364
Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away
...
BUG=
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/36229004
Cr-Commit-Position: refs/heads/master@{#8517}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8517 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-26 14:43:50 +00:00
magjed@webrtc.org
be29b3b4c6
I420VideoFrame: Remove functions set_width, set_height, and ResetSize
...
The functions set_width, set_height, and ResetSize in I420VideoFrame are not needed and just add complexity.
R=perkj@webrtc.org , stefan@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39939004
Cr-Commit-Position: refs/heads/master@{#8434}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8434 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-19 15:35:50 +00:00
pkasting@chromium.org
4591fbd09f
Use size_t more consistently for packet/payload lengths.
...
See design doc at https://docs.google.com/a/chromium.org/document/d/1I6nmE9D_BmCY-IoV6MDPY2V6WYpEI-dg2apWXTfZyUI/edit?usp=sharing for more information.
This CL was reviewed and approved in pieces in the following CLs:
https://webrtc-codereview.appspot.com/24209004/
https://webrtc-codereview.appspot.com/24229004/
https://webrtc-codereview.appspot.com/24259004/
https://webrtc-codereview.appspot.com/25109004/
https://webrtc-codereview.appspot.com/26099004/
https://webrtc-codereview.appspot.com/27069004/
https://webrtc-codereview.appspot.com/27969004/
https://webrtc-codereview.appspot.com/27989004/
https://webrtc-codereview.appspot.com/29009004/
https://webrtc-codereview.appspot.com/30929004/
https://webrtc-codereview.appspot.com/30939004/
https://webrtc-codereview.appspot.com/31999004/
Committing as TBR to the original reviewers.
BUG=chromium:81439
TEST=none
TBR=pthatcher,henrik.lundin,tina.legrand,stefan,tkchin,glaznev,kjellander,perkj,mflodman,henrika,asapersson,niklas.enbom
Review URL: https://webrtc-codereview.appspot.com/23129004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7726 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-20 22:28:14 +00:00
magjed@webrtc.org
ea73ff7267
webrtc::Scaler: Preserve aspect ratio
...
BUG=3936
R=glaznev@webrtc.org , stefan@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=7679
Review URL: https://webrtc-codereview.appspot.com/28969004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7689 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-12 09:52:03 +00:00
magjed@webrtc.org
f7c5d4fac7
Revert 7679 "webrtc::Scaler: Preserve aspect ratio"
...
> webrtc::Scaler: Preserve aspect ratio
>
> BUG=3936
> R=glaznev@webrtc.org , stefan@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/28969004
TBR=magjed@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/30989004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7682 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-11 13:12:09 +00:00
magjed@webrtc.org
809986b95f
webrtc::Scaler: Preserve aspect ratio
...
BUG=3936
R=glaznev@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/28969004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7679 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-11 09:51:30 +00:00
pbos@webrtc.org
bc73871251
Remove the VPM denoiser.
...
The VPM denoiser give bad results, is slow and has not been used in
practice. Instead we use the VP8 denoiser. Testing this denoiser takes
up a lot of runtime on linux_memcheck (about 4 minutes) which we can do
without.
BUG=
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/16069004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6688 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-15 09:50:40 +00:00
wu@webrtc.org
21a5d449b7
Increase VPMVideoDecimator's initial max_frame_rate_ to 60, which allow us potentially do 60fps.
...
BUG=
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/21499006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6274 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-29 19:43:26 +00:00
andrew@webrtc.org
8f69330310
Replace scoped_array<T> with scoped_ptr<T[]>.
...
scoped_array is deprecated. This was done using a Chromium clang tool:
http://src.chromium.org/viewvc/chrome/trunk/src/tools/clang/rewrite_scoped_ar ...
except for the few not-built-on-Linux files which were updated manually.
TESTED=trybots
BUG=2515
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12429004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5985 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-25 23:10:28 +00:00
fbarchard@google.com
b5bc098e20
Clear empty video frames in unittest so DrMemory will allow them to be read without an uninitialized read error.
...
BUG=libyuv:263
TESTED=drmemory out\Debug\modules_unittests.exe --gtest_filter=*PreprocessorLogic
R=kjellander@webrtc.org , mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4319004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5168 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-25 09:06:33 +00:00
mikhal@webrtc.org
b43d8078a1
Reformatting VPM: First step - No functional changes.
...
R=marpan@google.com , marpan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2333004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4912 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-03 16:42:41 +00:00
pbos@webrtc.org
12dc1a38ca
Switch C++-style C headers with their C equivalents.
...
The C++ headers define the C functions within the std:: namespace, but
we mainly don't use the std:: namespace for C functions. Therefore we
should include the C headers.
BUG=1833
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1917004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4486 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-05 16:22:53 +00:00
henrike@webrtc.org
a950300b0e
Disables unit tests that don't work on Android for Android.
...
BUG=N/A
R=andrew@webrtc.org , kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1747004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4306 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-08 18:53:54 +00:00
pbos@webrtc.org
c66aaaf921
Rename unit_test.{cc,h} under module_unittest.
...
Squelches the following Windows trybot warning:
warning LNK4042: object specified more than once; extras ignored
BUG=
R=andrew@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1758004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4288 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-03 07:56:33 +00:00
pbos@webrtc.org
6f3d8fcfc0
Include files from webrtc/.. paths in video_processing/
...
BUG=1662
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1558004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4109 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-27 14:12:16 +00:00
pbos@webrtc.org
1ab45f6dd5
WebRtc_Word32 -> int32_t in video_processing/
...
BUG=314
Review URL: https://webrtc-codereview.appspot.com/1297006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3800 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-09 13:38:10 +00:00
mikhal@webrtc.org
658d423e81
Using Convert in lieu of ExtractBuffer: Less error prone (as we don't need to compute buffer sizes etc.). This cl is first in a series (doing all of WebRtc would make it quite a big cl). While at it, fixing a few headers.
...
BUG=988
Review URL: https://webrtc-codereview.appspot.com/995014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3343 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-08 19:19:59 +00:00
mikhal@webrtc.org
96dc6270d4
vpm unit test: Diasble frame dropping in tests
...
(follow up on r3284)
BUG=
Review URL: https://webrtc-codereview.appspot.com/991005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3285 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-13 19:53:26 +00:00
mikhal@webrtc.org
4493db5a3e
vpm: removing unnecessary memcpy
...
TEST=trybots
BUG=1128
Review URL: https://webrtc-codereview.appspot.com/966038
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3284 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-13 18:25:36 +00:00
wu@webrtc.org
2a749d3108
Verify output frame timestamp in VideoProcessingModuleTest.Resampler.
...
TEST=unit tests
BUG=1069
Review URL: https://webrtc-codereview.appspot.com/964014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3063 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-08 01:07:21 +00:00
phoglund@webrtc.org
4cebe6cded
Made TickTime immutable, rewrote tick utils to be fakeable.
...
BUG=
Review URL: https://webrtc-codereview.appspot.com/798004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3053 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-07 13:37:19 +00:00
mikhal@webrtc.org
9169b51fe7
Fixing vpm valgrind issues introduced in r2893
...
Review URL: https://webrtc-codereview.appspot.com/933007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2996 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-25 15:23:11 +00:00
mikhal@webrtc.org
1997ddb713
Fix valgrind issue introduced in r2983
...
Review URL: https://webrtc-codereview.appspot.com/936004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2986 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-24 21:34:21 +00:00
mikhal@webrtc.org
9fedff7c17
Switching to I420VideoFrame
...
Review URL: https://webrtc-codereview.appspot.com/922004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2983 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-24 18:33:04 +00:00
andrew@webrtc.org
14b43beb7c
Move src/ -> webrtc/
...
TBR=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/915006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2963 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-22 18:19:23 +00:00